[GitHub] [nifi] jfrazee commented on a change in pull request #4233: NIFI-7393: add max idle time and max idle connections parameter to InvokeHTTP

[GitBox <gi...@apache.org>]

jfrazee commented on a change in pull request #4233:
URL: https://github.com/apache/nifi/pull/4233#discussion_r435485319



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -214,6 +215,22 @@
             .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
             .build();
 
+    public static final PropertyDescriptor PROP_IDLE_TIMEOUT = new PropertyDescriptor.Builder()
+            .name("Idle Timeout")

Review comment:
       I missed this. But can you change this to `.displayName("Idle Timeout")` and add `.name("idle-timeout")`? Similar for the other property. I know the older props didn't do this, but it's good to do for newer ones. If you can't get to it, I can maybe do it on merge since it's a tiny change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org