You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Cahill <dc...@midokura.com> on 2013/03/13 10:30:05 UTC

Review Request: MidoNet Networking Plugin [1/2]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9897/
-----------------------------------------------------------

Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.


Description
-------

Feature spec:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Networking+Plugin

Jira ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-996

Notes:
This first commit is just a file move - if I squash it into one commit, it shows as a delete and add because over 50% of the file changed.


This addresses bug CLOUDSTACK-996.


Diffs
-----

  plugins/network-elements/midokura-midonet/src/com/cloud/network/element/MidokuraMidonetElement.java 48833b3 
  plugins/network-elements/midokura-midonet/src/com/cloud/network/guru/MidokuraMidonetGuestNetworkGuru.java ed0eb3c 
  plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java PRE-CREATION 
  plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java PRE-CREATION 

Diff: https://reviews.apache.org/r/9897/diff/


Testing
-------

Built and deployed, spun up Advanced Isolated network with two VMs, verified internal and external connectivity via MidoNet.


Thanks,

Dave Cahill


Re: Review Request: MidoNet Networking Plugin [1/2]

Posted by Hugo Trippaers <ht...@schubergphilis.com>.

> On April 3, 2013, 10:11 a.m., Hugo Trippaers wrote:
> > Ship It!

commit d392445f7e9adab7d6effd4daf0d76bb0e6f9bd9
Author: Dave Cahill <dc...@midokura.com>
Date:   Wed Mar 13 17:27:09 2013 +0900

    Rename MidoNetElement and MidoNetGuestNetworkGuru

    - Creating this as a separate commit so that it is marked as a rename
    - Over 50% code changed, so would count as a delete and add otherwise

    Signed-off-by: Dave Cahill <dc...@midokura.com>
    Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9897/#review18639
-----------------------------------------------------------


On March 13, 2013, 9:30 a.m., Dave Cahill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9897/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 9:30 a.m.)
> 
> 
> Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> Feature spec:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Networking+Plugin
> 
> Jira ticket:
> https://issues.apache.org/jira/browse/CLOUDSTACK-996
> 
> Notes:
> This first commit is just a file move - if I squash it into one commit, it shows as a delete and add because over 50% of the file changed.
> 
> 
> This addresses bug CLOUDSTACK-996.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/midokura-midonet/src/com/cloud/network/element/MidokuraMidonetElement.java 48833b3 
>   plugins/network-elements/midokura-midonet/src/com/cloud/network/guru/MidokuraMidonetGuestNetworkGuru.java ed0eb3c 
>   plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java PRE-CREATION 
>   plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9897/diff/
> 
> 
> Testing
> -------
> 
> Built and deployed, spun up Advanced Isolated network with two VMs, verified internal and external connectivity via MidoNet.
> 
> 
> Thanks,
> 
> Dave Cahill
> 
>


Re: Review Request: MidoNet Networking Plugin [1/2]

Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9897/#review18639
-----------------------------------------------------------

Ship it!


Ship It!

- Hugo Trippaers


On March 13, 2013, 9:30 a.m., Dave Cahill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9897/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 9:30 a.m.)
> 
> 
> Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> Feature spec:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Networking+Plugin
> 
> Jira ticket:
> https://issues.apache.org/jira/browse/CLOUDSTACK-996
> 
> Notes:
> This first commit is just a file move - if I squash it into one commit, it shows as a delete and add because over 50% of the file changed.
> 
> 
> This addresses bug CLOUDSTACK-996.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/midokura-midonet/src/com/cloud/network/element/MidokuraMidonetElement.java 48833b3 
>   plugins/network-elements/midokura-midonet/src/com/cloud/network/guru/MidokuraMidonetGuestNetworkGuru.java ed0eb3c 
>   plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java PRE-CREATION 
>   plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9897/diff/
> 
> 
> Testing
> -------
> 
> Built and deployed, spun up Advanced Isolated network with two VMs, verified internal and external connectivity via MidoNet.
> 
> 
> Thanks,
> 
> Dave Cahill
> 
>


RE: Review Request: MidoNet Networking Plugin [1/2]

Posted by Animesh Chaturvedi <an...@citrix.com>.
Chiradeep, Hugo can you review 9897,9898?

> -----Original Message-----
> From: Dave Cahill [mailto:noreply@reviews.apache.org] On Behalf Of Dave
> Cahill
> Sent: Wednesday, March 13, 2013 2:30 AM
> To: Chiradeep Vittal; Hugo Trippaers
> Cc: cloudstack; Dave Cahill
> Subject: Review Request: MidoNet Networking Plugin [1/2]
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9897/
> -----------------------------------------------------------
> 
> Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> Feature spec:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Netw
> orking+Plugin
> 
> Jira ticket:
> https://issues.apache.org/jira/browse/CLOUDSTACK-996
> 
> Notes:
> This first commit is just a file move - if I squash it into one commit, it shows as
> a delete and add because over 50% of the file changed.
> 
> 
> This addresses bug CLOUDSTACK-996.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/midokura-
> midonet/src/com/cloud/network/element/MidokuraMidonetElement.java
> 48833b3
>   plugins/network-elements/midokura-
> midonet/src/com/cloud/network/guru/MidokuraMidonetGuestNetworkGur
> u.java ed0eb3c
>   plugins/network-
> elements/midonet/src/com/cloud/network/element/MidoNetElement.java
> PRE-CREATION
>   plugins/network-
> elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkG
> uru.java PRE-CREATION
> 
> Diff: https://reviews.apache.org/r/9897/diff/
> 
> 
> Testing
> -------
> 
> Built and deployed, spun up Advanced Isolated network with two VMs,
> verified internal and external connectivity via MidoNet.
> 
> 
> Thanks,
> 
> Dave Cahill