You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wss4j-dev@ws.apache.org by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org> on 2008/04/16 17:47:21 UTC
[jira] Created: (WSS-113) Bug in WSHandler#getPassword
Bug in WSHandler#getPassword
----------------------------
Key: WSS-113
URL: https://issues.apache.org/jira/browse/WSS-113
Project: WSS4J
Issue Type: Bug
Reporter: Colm O hEigeartaigh
Assignee: Ruchith Udayanga Fernando
Priority: Minor
Attachments: wss4j_get_password.patch
WSHandler#getPassword tries to get a password by:
a) Trying to construct a password callback
b) Trying to get a password callback object from the Message Context
c) Trying to get the password directly from the Message Context, i.e. delegating this to a subclass of WSHandler
There are some problems with how the current code handles option (c). In particular, the action to be performed, as well as the username, are not preserved in the WSPasswordCallback object that gets returned. This in turn leads to problems with the UsernameTokenAction, which obtains the username from the WSPasswordCallback.
See attached for a patch for this problem. In addition, I added some fairly extensive unit testing of the getPassword method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Assigned: (WSS-113) Bug in WSHandler#getPassword
Posted by "Fred Dushin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fred Dushin reassigned WSS-113:
-------------------------------
Assignee: Fred Dushin (was: Ruchith Udayanga Fernando)
> Bug in WSHandler#getPassword
> ----------------------------
>
> Key: WSS-113
> URL: https://issues.apache.org/jira/browse/WSS-113
> Project: WSS4J
> Issue Type: Bug
> Reporter: Colm O hEigeartaigh
> Assignee: Fred Dushin
> Priority: Minor
> Attachments: wss4j_get_password.patch
>
>
> WSHandler#getPassword tries to get a password by:
> a) Trying to construct a password callback
> b) Trying to get a password callback object from the Message Context
> c) Trying to get the password directly from the Message Context, i.e. delegating this to a subclass of WSHandler
> There are some problems with how the current code handles option (c). In particular, the action to be performed, as well as the username, are not preserved in the WSPasswordCallback object that gets returned. This in turn leads to problems with the UsernameTokenAction, which obtains the username from the WSPasswordCallback.
> See attached for a patch for this problem. In addition, I added some fairly extensive unit testing of the getPassword method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Updated: (WSS-113) Bug in WSHandler#getPassword
Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm O hEigeartaigh updated WSS-113:
------------------------------------
Attachment: wss4j_get_password.patch
> Bug in WSHandler#getPassword
> ----------------------------
>
> Key: WSS-113
> URL: https://issues.apache.org/jira/browse/WSS-113
> Project: WSS4J
> Issue Type: Bug
> Reporter: Colm O hEigeartaigh
> Assignee: Ruchith Udayanga Fernando
> Priority: Minor
> Attachments: wss4j_get_password.patch
>
>
> WSHandler#getPassword tries to get a password by:
> a) Trying to construct a password callback
> b) Trying to get a password callback object from the Message Context
> c) Trying to get the password directly from the Message Context, i.e. delegating this to a subclass of WSHandler
> There are some problems with how the current code handles option (c). In particular, the action to be performed, as well as the username, are not preserved in the WSPasswordCallback object that gets returned. This in turn leads to problems with the UsernameTokenAction, which obtains the username from the WSPasswordCallback.
> See attached for a patch for this problem. In addition, I added some fairly extensive unit testing of the getPassword method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Resolved: (WSS-113) Bug in WSHandler#getPassword
Posted by "Fred Dushin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fred Dushin resolved WSS-113.
-----------------------------
Resolution: Fixed
Applied Colm's fix.
This change should be noncontroversial -- it's a simple refactor of the creation of the WSPasswordCallback object, and does not result in any change in behavior (except for the addition of information to the callback instance created)
> Bug in WSHandler#getPassword
> ----------------------------
>
> Key: WSS-113
> URL: https://issues.apache.org/jira/browse/WSS-113
> Project: WSS4J
> Issue Type: Bug
> Reporter: Colm O hEigeartaigh
> Assignee: Fred Dushin
> Priority: Minor
> Attachments: wss4j_get_password.patch
>
>
> WSHandler#getPassword tries to get a password by:
> a) Trying to construct a password callback
> b) Trying to get a password callback object from the Message Context
> c) Trying to get the password directly from the Message Context, i.e. delegating this to a subclass of WSHandler
> There are some problems with how the current code handles option (c). In particular, the action to be performed, as well as the username, are not preserved in the WSPasswordCallback object that gets returned. This in turn leads to problems with the UsernameTokenAction, which obtains the username from the WSPasswordCallback.
> See attached for a patch for this problem. In addition, I added some fairly extensive unit testing of the getPassword method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org