You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by mayunSaicmotor <gi...@git.apache.org> on 2017/03/11 06:50:26 UTC
[GitHub] incubator-carbondata pull request #646: [CARBONDATA-748] put if clause out o...
GitHub user mayunSaicmotor opened a pull request:
https://github.com/apache/incubator-carbondata/pull/646
[CARBONDATA-748] put if clause out of the for clause in method setFilterdIndexToBitSet
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[CARBONDATA-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- What manual testing you have done?
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #646
----
commit 252649eecee6a7b74eef5a7b7f17d58a363c09ea
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-09T05:13:22Z
use binary search to improve the performance in method
setFilterdIndexToBitSet
commit c50054fa519cc1004b78941cf88541f7ad838976
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-09T07:51:50Z
add binary range search and add test case
commit 25839b1425986cc95275b5e628e03d3fa8d19103
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-09T08:08:21Z
revert previous change
commit 0644946a8bb9877ccdafd96420b091364d126669
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-09T08:38:29Z
format changed code
commit 516c5541722f12dffe5c709238bbb8a2f64e65dc
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-09T09:09:06Z
change code format to pass check style
commit 141e26425ed7296b661a5382a4fe168e33fb71d1
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-09T09:51:22Z
revert the code to use inverted index
commit 0ca8472786974ea11551843b26ae472d422fc847
Author: mayun <ma...@10.100.56.61>
Date: 2017-03-10T15:53:34Z
add comments and change variables definition style
commit 618923cc8cd71257b34bb576779b90a65951f217
Author: mayun <si...@163.com>
Date: 2017-03-11T04:57:56Z
put the if clause out of the for clause and added test case
commit 70f50adae2e9436970b5744df07be81df8846457
Author: mayun <si...@163.com>
Date: 2017-03-11T05:15:35Z
Revert "put the if clause out of the for clause and added test case"
This reverts commit 618923cc8cd71257b34bb576779b90a65951f217.
commit 7acb4392b4a03fdd0810a12ad9cd5165dc12696b
Author: \u9a6c\u4e91 <si...@163.com>
Date: 2017-03-11T05:26:00Z
Merge pull request #3 from apache/master
merger from master
commit 9aeccb21f58bb5ebb309221da939595ca5da4be3
Author: mayun <si...@163.com>
Date: 2017-03-11T06:43:32Z
put if clause out of the for clause and add test case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #646: [CARBONDATA-748] put if clause out of the f...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/646
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #646: [CARBONDATA-748] put if clause out of the f...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/646
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #646: [CARBONDATA-748] put if clause out o...
Posted by mayunSaicmotor <gi...@git.apache.org>.
Github user mayunSaicmotor closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #646: [CARBONDATA-748] put if clause out of the f...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/646
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1089/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #646: [CARBONDATA-748] put if clause out of the f...
Posted by mayunSaicmotor <gi...@git.apache.org>.
Github user mayunSaicmotor commented on the issue:
https://github.com/apache/incubator-carbondata/pull/646
@Chen, Liang
Below is the step to change commit\u2019s author information in git. Just for reference.
I have run in my fork repository and raise PR. Please help to confirm. thanks very much.
1. find the previous commit id of the needing amend commit\uff0clook as below
872945f is committed by me and need to change the author email id
6713ffa is the previous commit id
2. run the below commit
git rebase -i -p 6713ffa
change the pick to edit before 872945f and type \u201cwq\u201d to exit
3. run the below command to amend author information
git commit --amend --author="mayun <si...@163.com>" --no-edit
git rebase -continue
4. run the below command to raise change to remote
git push --force --tags origin 'refs/heads/*' -u
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #646: [CARBONDATA-748] put if clause out of the f...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/646
@mayunSaicmotor please squash into one commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---