[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
URL: https://github.com/apache/incubator-superset/pull/8256#discussion_r325986954
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2594,16 +2594,16 @@ def validate_sql_json(self):
             return json_error_response(f"{msg}")
 
     @has_access_api
-    @expose("/sql_json/", methods=["POST", "GET"])
+    @expose("/sql_json/", methods=["POST"])
 
 Review comment:
   were we allowing `GET` for some caching reason? @betodealmeida might have context

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org