You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2022/08/08 07:32:28 UTC
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18822
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
KUDU-3386 Update macOS docs for ARM
This is the accompanying doc change to the ARM mac support patch [1].
The introductory line tells, that we now support ARM as well. Added a
link to the known not working tests for transparency, and to encourage
contributions. The range of Xcode versions is outlined which can be
used with ARM Kudu. Finally a pkg-config export is added for OpenSSL.
[1] https://gerrit.cloudera.org/#/c/18770/
Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
---
M docs/installation.adoc
1 file changed, 30 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18822/1
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 18:22:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@9
PS1, Line 9: ]
as this commit is merged already, it's better to use the commit hash instead of the gerrit link.
http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@13
PS1, Line 13: Finally
nit: comma
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@550
PS1, Line 550: macs
nit: Macs, and maybe mention Apple M chips for the first time in parentheses?
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609
PS1, Line 609: .ARM macs
is this only for ARM Macs? Shouldn't this be done on Intel Macs as well?
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 09:17:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 5:
Thank you for the patch!
I guess after you addressed Attila's comment on PS4, this patch is good to go.
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 19:27:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609
PS1, Line 609: .ARM macs
> Should I then move this out of the "ARM" label? Could someone please, with
I guess the build fails on macOS (both on Intel and ARM) if not pointing directly to openssl@1.1 because of some FIPS-related functions that our code uses: by default, newer versions of macOS include LibreSSL 2.8.x where that FIPS-related API is different from OpenSSL 1.x.x. Also, in many cases MacPorts and homebrew packages install OpenSSL 3.0.x by dependency, and there the FIPS-related API is also different from what it is in OpenSSL 1.x.x.
At least, that's what happens at my macOS (Intel) laptop.
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@568
PS2, Line 568: Xcode introduced support for Apple silicon in version
: link:https://developer.apple.com/documentation/xcode-release-notes/xcode-12_2-release-notes[12.2].
: Xcode versions up until 13.2.1 can be used with Kudu.
> Basically Xcode version 13.2.1 inclusive, can be used to build all thirdpar
Thanks for the clarification.
It would be great to add reference to KUDU-3391 along with the information on the highest version of Xcode which can be used to build Kudu: something like '..., for details see KUDU-3391.'
From the other side, I guess we could update gtest up to 1.12.1 version (it seems the issue has been fixed at least in 1.11.1) now and remove that constraint.
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Aug 2022 01:23:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
KUDU-3386 Update macOS docs for ARM
This is the accompanying doc change to the ARM Mac support patch [1].
As the introductory line says, we now support ARM. Added macOS 11
(Big Sur) and macOS 12 (Monterey) to the supported macOS versions. Added
a link to the known not working tests for transparency, and to encourage
contributions. The CMake OPENSSL_ROOT_DIR flag's location in the guide
does not work on ARM Macs, as the homebrew path is different. Both
Kudu and thirdparty JWT need proper OPENSSL_ROOT_DIR. A pkg-config
export is added for OpenSSL which works on both Intel and Apple Silicon.
This takes care of both Kudu and thirdparty JWT.
[1] commit hash: 543e128d473f8f7836e605bba8cd6512fa918550
Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Reviewed-on: http://gerrit.cloudera.org:8080/18822
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M docs/installation.adoc
1 file changed, 31 insertions(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 09:03:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Aug 2022 14:26:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Zoltan Chovan, Alexey Serbin, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18822
to look at the new patch set (#4).
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
KUDU-3386 Update macOS docs for ARM
This is the accompanying doc change to the ARM Mac support patch [1].
As the introductory line says, we now support ARM. Added macOS 11
(Big Sur) and macOS 12 (Monterey) to the supported macOS versions. Added
a link to the known not working tests for transparency, and to encourage
contributions. The CMake OPENSSL_ROOT_DIR flag's location in the guide
does not work on ARM Macs, as the homebrew path is different. Both
Kudu and thirdparty JWT need proper OPENSSL_ROOT_DIR. A pkg-config
export is added for OpenSSL which works on both Intel and Apple Silicon.
This takes care of both Kudu and thirdparty JWT.
[1] commit hash: 543e128d473f8f7836e605bba8cd6512fa918550
Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
---
M docs/installation.adoc
1 file changed, 30 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18822/4
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG@10
PS2, Line 10: The introductory line tells, that we now support ARM as well.
nit: Maybe rephrase to "As the introductory line says, we now support ARM.
http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG@12
PS2, Line 12: The range of Xcode versions is outlined which can be
: used with ARM Kudu
nit: rephrase to "The range of ARM Kudu compatible Xcode versions are outlined."
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 23:51:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 3:
Could you please give us a rendered site of the docs, for example, the github links？
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Aug 2022 08:55:48 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 4:
(2 comments)
> Could you please give us a rendered site of the docs, for example,
> the github links?
Please find the current patch on my github pages site, pointing to the relevant macOS part: https://martongreber.github.io/docs/installation.html#osx_from_source
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609
PS1, Line 609: +
> I guess the build fails on macOS (both on Intel and ARM) if not pointing di
Thank you for the detailed explanation! Moved this part out of the "ARM label" as it is applicable of Intel and ARM Macs as well.
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@568
PS2, Line 568: .ARM Macs
: ====
: Apple introduced support for Apple silicon in Xcode v
> Thanks for the clarification.
Thank you for making the gtest upgrade patch (9a8570b9c6b3d4e24e47ca830c089ab04667ef41)! Thanks to that Kudu is working with the latest Xcode as well (13.4.1). Thereby removed the version upper limit. Sometimes one might want to use older Xcode. For reference the lowest supported ARM version is kept here.
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 18:27:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18822/4/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/4/docs/installation.adoc@589
PS4, Line 589: . Add OpenSSL to the pkg-config path. Kudu and thirdparty JWT fail to build without proper
> nit: this line is too long
Done
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Sep 2022 10:04:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18822
to look at the new patch set (#2).
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
KUDU-3386 Update macOS docs for ARM
This is the accompanying doc change to the ARM mac support patch [1].
The introductory line tells, that we now support ARM as well. Added a
link to the known not working tests for transparency, and to encourage
contributions. The range of Xcode versions is outlined which can be
used with ARM Kudu. Finally, a pkg-config export is added for OpenSSL.
[1] commit hash: 543e128d473f8f7836e605bba8cd6512fa918550
Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
---
M docs/installation.adoc
1 file changed, 30 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18822/2
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Sep 2022 15:04:54 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Zoltan Chovan, Alexey Serbin, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18822
to look at the new patch set (#5).
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
KUDU-3386 Update macOS docs for ARM
This is the accompanying doc change to the ARM Mac support patch [1].
As the introductory line says, we now support ARM. Added macOS 11
(Big Sur) and macOS 12 (Monterey) to the supported macOS versions. Added
a link to the known not working tests for transparency, and to encourage
contributions. The CMake OPENSSL_ROOT_DIR flag's location in the guide
does not work on ARM Macs, as the homebrew path is different. Both
Kudu and thirdparty JWT need proper OPENSSL_ROOT_DIR. A pkg-config
export is added for OpenSSL which works on both Intel and Apple Silicon.
This takes care of both Kudu and thirdparty JWT.
[1] commit hash: 543e128d473f8f7836e605bba8cd6512fa918550
Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
---
M docs/installation.adoc
1 file changed, 31 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18822/5
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18822/4/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/4/docs/installation.adoc@589
PS4, Line 589: . Add OpenSSL to the pkg-config path. Kudu and thirdparty JWT fail to build without proper OPENSSL_ROOT_DIR. If one sets the following environment variable, it takes care of both cases.
nit: this line is too long
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 20:33:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18822
to look at the new patch set (#3).
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
KUDU-3386 Update macOS docs for ARM
This is the accompanying doc change to the ARM mac support patch [1].
As the introductory line says, we now support ARM. Added a link to the
known not working tests for transparency, and to encourage
contributions. The range of ARM Kudu compatible Xcode versions are
outlined. Finally, a pkg-config export is added for OpenSSL.
[1] commit hash: 543e128d473f8f7836e605bba8cd6512fa918550
Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
---
M docs/installation.adoc
1 file changed, 31 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18822/3
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG@10
PS2, Line 10: As the introductory line says, we now support ARM. Added a li
> nit: Maybe rephrase to "As the introductory line says, we now support ARM.
Done
http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG@12
PS2, Line 12: The range of ARM Kudu compatible Xcode versions are
: outlined. Finally,
> nit: rephrase to "The range of ARM Kudu compatible Xcode versions are outli
Done
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609
PS1, Line 609: .ARM Macs
> I always had this in my bash_profile on my Intel Mac. I don't remember what
Should I then move this out of the "ARM" label? Could someone please, with an Intel Mac, check a thirdparty build for JWT, whether the openssl pkg config export is needed?
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@568
PS2, Line 568: Apple introduced support for Apple silicon in Xcode version
: link:https://developer.apple.com/documentation/xcode-release-notes/xcode-12_2-release-notes[12.2].
: To build Kudu on ARM-based Macs (Apple M chips), use
> How about rephrasing this to be more specific what 'use' means and
Basically Xcode version 13.2.1 inclusive, can be used to build all thirdparty libs successfully. Going above 13.2.1, the first issue I encountered, is that gmock breaks. I created a jira for this issue: KUDU-3391. Maybe thats all, maybe other issues come up. As of right now Xcode 13.2.1 inclusive is the upper limit, which works out of the box. As last week's investigations show, this counts for Intel and ARM based Macs as well.
Included another sentence outside of the "ARM" label to highlight the max Xcode version for Intel based Macs.
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@611
PS2, Line 611: ,
> It would be great to clarify why this is necessary.
Done
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 19:42:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@568
PS2, Line 568: Xcode introduced support for Apple silicon in version
: link:https://developer.apple.com/documentation/xcode-release-notes/xcode-12_2-release-notes[12.2].
: Xcode versions up until 13.2.1 can be used with Kudu.
How about rephrasing this to be more specific what 'use' means and
To build Kudu on ARM-based Macs (Apple M chips), use Xcode of versions from <version A> to <version B> inclusive.
BTW, what's broken in Kudu build on M1 with Xcode 13.2.1? Is this just the maximum version reported to build Kudu or there is some fundamental issue that prevents Kudu to be build with newer versions? It would be great to clarify.
http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@611
PS2, Line 611: :
It would be great to clarify why this is necessary.
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 00:36:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3386 Update macOS docs for ARM
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@9
PS1, Line 9: ]
> as this commit is merged already, it's better to use the commit hash instea
Done
http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@13
PS1, Line 13: Finally
> nit: comma
Done
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@550
PS1, Line 550: Macs
> nit: Macs, and maybe mention Apple M chips for the first time in parenthese
Done
http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609
PS1, Line 609: .ARM Macs
> is this only for ARM Macs? Shouldn't this be done on Intel Macs as well?
Initially, while building on M1, the JWT build failed to find OpenSSL. JWT wasn't touched during the M1 upgrade, so I assumed that it is M1 specific, hence the ARM note.
However I think it would be good to double check. I don't have an Intel Mac. Could someone, with an Intel machine please try to build Kudu master? Ideally it would work, but if the process fails on the thirdparty JWT step, I will move this note out of the ARM label.
--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 10:02:48 +0000
Gerrit-HasComments: Yes