[GitHub] [zookeeper] ravowlga123 opened a new pull request #1180: ZOOKEEPER-3300 CLI "history" to show 10 commands

[GitBox <gi...@apache.org>]

ravowlga123 opened a new pull request #1180: ZOOKEEPER-3300 CLI "history" to show 10 commands
URL: https://github.com/apache/zookeeper/pull/1180
 
 
   Currently CLI: "history" shows 11 previous commands used. As per the ticket [ZOOKEEPER-3300](https://issues.apache.org/jira/browse/ZOOKEEPER-3300) intended behavior is to show 10.
   
   I saw two ways to do so which are mentioned as follows:
   
   - Include "history" in the list of 10 previous commands used. The changes made in this PR follows this. (I have changed the initialization of "i" in loop to commandCount -9) 
   - Don't include command "history" in the list of 10 previous commands. To do this change comparison part of loop to i < commandCount
   
   Please do let me know if the change I made is preferred, there might be some other way to address this or if I have missed something else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services