You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/19 05:19:08 UTC

[GitHub] [lucene] dsmiley opened a new pull request #216: Introduce DocTermVectors in lieu of Fields.

dsmiley opened a new pull request #216:
URL: https://github.com/apache/lucene/pull/216


   https://issues.apache.org/jira/browse/LUCENE-10018
   Let's not use the Fields class anymore for TermVectors.  In this PR, we introduce a new class "DocTermVectors" in its stead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] dsmiley commented on pull request #216: Introduce DocTermVectors in lieu of Fields.

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #216:
URL: https://github.com/apache/lucene/pull/216#issuecomment-882247189


   In the first commit of this PR, I introduce "DocTermVectors" subclassing Fields.  Another commit can inline Fields.
   
   What do we think of the name?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir commented on pull request #216: Introduce DocTermVectors in lieu of Fields.

Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #216:
URL: https://github.com/apache/lucene/pull/216#issuecomment-882337507


   what are all these commits just adding more public classes for no reason?: TermVectors, now DocTermVectors
   
   -1: Full stop.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org