You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/07/08 11:37:49 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #5036: HDDS-8986. Rebalance integration tests
adoroszlai opened a new pull request, #5036:
URL: https://github.com/apache/ozone/pull/5036
## What changes were proposed in this pull request?
Try to reduce overall integration test time by moving out some tests from the longest-running splits.
1. Create 2 new integration test splits:
* `contract` (extracted from `filesystem`): FS contract tests
* `shell` (extracted from `ozone`): CLI-related tests
2. Move some tests to more appropriate packages.
https://issues.apache.org/jira/browse/HDDS-8986
## How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5488447421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 merged pull request #5036: HDDS-8986. Rebalance integration tests
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 merged PR #5036:
URL: https://github.com/apache/ozone/pull/5036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #5036: HDDS-8986. Rebalance integration tests
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5036:
URL: https://github.com/apache/ozone/pull/5036#discussion_r1262460409
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java:
##########
@@ -296,12 +296,12 @@ default String getBaseDir() {
@SuppressWarnings("visibilitymodifier")
abstract class Builder {
- protected static final int DEFAULT_HB_INTERVAL_MS = 1000;
- protected static final int DEFAULT_HB_PROCESSOR_INTERVAL_MS = 100;
- protected static final int ACTIVE_OMS_NOT_SET = -1;
- protected static final int ACTIVE_SCMS_NOT_SET = -1;
- protected static final int DEFAULT_PIPELINE_LIMIT = 3;
- protected static final int DEFAULT_RATIS_RPC_TIMEOUT_SEC = 1;
+ public static final int DEFAULT_HB_INTERVAL_MS = 1000;
+ public static final int DEFAULT_HB_PROCESSOR_INTERVAL_MS = 100;
+ public static final int ACTIVE_OMS_NOT_SET = -1;
+ public static final int ACTIVE_SCMS_NOT_SET = -1;
+ public static final int DEFAULT_PIPELINE_LIMIT = 3;
+ public static final int DEFAULT_RATIS_RPC_TIMEOUT_SEC = 1;
Review Comment:
`DEFAULT_HB_INTERVAL_MS` is used from `TestStorageContainerManager`, which is being moved to a different package. Strictly speaking only that one needs to be `public`, I changed the rest for consistency.
On second look, probably `TestStorageContainerManager` should use the actual config, not the default one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 commented on a diff in pull request #5036: HDDS-8986. Rebalance integration tests
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on code in PR #5036:
URL: https://github.com/apache/ozone/pull/5036#discussion_r1262448739
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java:
##########
@@ -296,12 +296,12 @@ default String getBaseDir() {
@SuppressWarnings("visibilitymodifier")
abstract class Builder {
- protected static final int DEFAULT_HB_INTERVAL_MS = 1000;
- protected static final int DEFAULT_HB_PROCESSOR_INTERVAL_MS = 100;
- protected static final int ACTIVE_OMS_NOT_SET = -1;
- protected static final int ACTIVE_SCMS_NOT_SET = -1;
- protected static final int DEFAULT_PIPELINE_LIMIT = 3;
- protected static final int DEFAULT_RATIS_RPC_TIMEOUT_SEC = 1;
+ public static final int DEFAULT_HB_INTERVAL_MS = 1000;
+ public static final int DEFAULT_HB_PROCESSOR_INTERVAL_MS = 100;
+ public static final int ACTIVE_OMS_NOT_SET = -1;
+ public static final int ACTIVE_SCMS_NOT_SET = -1;
+ public static final int DEFAULT_PIPELINE_LIMIT = 3;
+ public static final int DEFAULT_RATIS_RPC_TIMEOUT_SEC = 1;
Review Comment:
Why do we have to make them `public`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #5036: HDDS-8986. Rebalance integration tests
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5036:
URL: https://github.com/apache/ozone/pull/5036#issuecomment-1634713720
Thanks @nandakumar131 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org