You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/11/04 08:11:34 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #3676: fix(plugins): add status RUNNING
warren830 opened a new pull request, #3676:
URL: https://github.com/apache/incubator-devlake/pull/3676
# Summary
use `RUNNING` to indicate that pipeline/task is unfinished
### Does this close any open issues?
closes #3660
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #3676: fix(plugins): add status RUNNING
Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #3676:
URL: https://github.com/apache/incubator-devlake/pull/3676#discussion_r1015189898
##########
models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -53,6 +53,7 @@ func (CICDPipelineRelationship) TableName() string {
const (
SUCCESS = "SUCCESS"
+ RUNNING = "RUNNING"
Review Comment:
What is the difference between RUNNING and IN_PROGRESS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3676: fix(plugins): add status RUNNING
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3676:
URL: https://github.com/apache/incubator-devlake/pull/3676#discussion_r1015194275
##########
models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -53,6 +53,7 @@ func (CICDPipelineRelationship) TableName() string {
const (
SUCCESS = "SUCCESS"
+ RUNNING = "RUNNING"
Review Comment:
Maybe we can keep it as empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #3676: fix(plugins): add status RUNNING
Posted by GitBox <gi...@apache.org>.
abeizn merged PR #3676:
URL: https://github.com/apache/incubator-devlake/pull/3676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3676: fix(plugins): add status RUNNING
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3676:
URL: https://github.com/apache/incubator-devlake/pull/3676#discussion_r1015193351
##########
models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -53,6 +53,7 @@ func (CICDPipelineRelationship) TableName() string {
const (
SUCCESS = "SUCCESS"
+ RUNNING = "RUNNING"
Review Comment:
RUNNING is for result, IN_PROGRESS is for status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #3676: fix(plugins): add status RUNNING
Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #3676:
URL: https://github.com/apache/incubator-devlake/pull/3676#discussion_r1015199876
##########
models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -53,6 +53,7 @@ func (CICDPipelineRelationship) TableName() string {
const (
SUCCESS = "SUCCESS"
+ RUNNING = "RUNNING"
Review Comment:
> RUNNING is for result, IN_PROGRESS is for status
then i think RUNNING and IN_PROGRESS maybe written separately, so that users can understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org