You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2024/02/29 04:54:31 UTC

[PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

zclllyybb opened a new pull request, #31573:
URL: https://github.com/apache/doris/pull/31573

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970472000

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.05 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0d1250d2d21e8a0c816de52f203ac23b74c94e93, data reload: false
   
   query1	0.02	0.03	0.03
   query2	0.07	0.02	0.02
   query3	0.24	0.04	0.05
   query4	1.81	0.06	0.07
   query5	0.53	0.52	0.51
   query6	1.28	0.60	0.60
   query7	0.01	0.01	0.01
   query8	0.03	0.02	0.02
   query9	0.51	0.46	0.48
   query10	0.53	0.54	0.53
   query11	0.12	0.08	0.09
   query12	0.11	0.09	0.09
   query13	0.62	0.62	0.61
   query14	0.79	0.78	0.79
   query15	0.77	0.76	0.77
   query16	0.36	0.36	0.36
   query17	1.01	1.01	1.00
   query18	0.23	0.25	0.24
   query19	1.92	1.80	1.89
   query20	0.01	0.01	0.01
   query21	15.49	0.58	0.57
   query22	1.97	2.30	2.06
   query23	17.25	0.97	0.93
   query24	6.25	0.84	0.91
   query25	0.41	0.10	0.06
   query26	0.56	0.13	0.14
   query27	0.05	0.04	0.05
   query28	7.34	0.79	0.72
   query29	12.68	2.34	2.32
   query30	0.58	0.53	0.54
   query31	2.81	0.38	0.37
   query32	3.40	0.49	0.51
   query33	3.09	3.05	3.10
   query34	15.25	4.82	4.83
   query35	4.86	4.87	4.86
   query36	1.04	1.02	1.01
   query37	0.06	0.05	0.04
   query38	0.04	0.02	0.02
   query39	0.02	0.01	0.01
   query40	0.16	0.14	0.14
   query41	0.06	0.01	0.01
   query42	0.02	0.01	0.02
   query43	0.02	0.02	0.01
   Total cold run time: 104.38 s
   Total hot run time: 31.05 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970455645

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 50179 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0d1250d2d21e8a0c816de52f203ac23b74c94e93, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17727	4371	4421	4371
   q2	2106	151	147	147
   q3	10490	1923	1873	1873
   q4	10407	1240	1320	1240
   q5	8667	4060	4018	4018
   q6	228	127	122	122
   q7	2060	1591	1604	1591
   q8	9265	2732	2746	2732
   q9	11236	10841	10706	10706
   q10	8582	3505	3513	3505
   q11	434	232	250	232
   q12	454	296	299	296
   q13	18343	3974	4043	3974
   q14	343	328	306	306
   q15	500	472	460	460
   q16	691	585	587	585
   q17	1141	1002	961	961
   q18	7301	6773	6870	6773
   q19	1697	1557	1547	1547
   q20	545	306	284	284
   q21	4483	4130	4072	4072
   q22	490	396	384	384
   Total cold run time: 117190 ms
   Total hot run time: 50179 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4291	4297	4290	4290
   q2	322	216	221	216
   q3	4155	4147	4140	4140
   q4	2739	2749	2741	2741
   q5	7404	7274	7245	7245
   q6	232	118	117	117
   q7	3194	2834	2857	2834
   q8	4433	4456	4479	4456
   q9	17629	17202	17463	17202
   q10	4271	4292	4275	4275
   q11	743	704	679	679
   q12	1015	840	873	840
   q13	6498	3709	3767	3709
   q14	444	416	422	416
   q15	501	460	463	460
   q16	751	703	706	703
   q17	3783	3808	3798	3798
   q18	8836	8760	8729	8729
   q19	1725	1702	1666	1666
   q20	2394	2110	2076	2076
   q21	8552	8566	8482	8482
   q22	1047	925	974	925
   Total cold run time: 84959 ms
   Total hot run time: 79999 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970466526

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 201848 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0d1250d2d21e8a0c816de52f203ac23b74c94e93, data reload: false
   
   query1	923	391	382	382
   query2	6521	2265	2200	2200
   query3	6919	200	196	196
   query4	21191	17884	17811	17811
   query5	19723	6517	6522	6517
   query6	291	215	226	215
   query7	4156	293	302	293
   query8	263	306	238	238
   query9	3103	2688	2616	2616
   query10	432	295	300	295
   query11	11247	10705	10659	10659
   query12	119	79	69	69
   query13	5572	632	616	616
   query14	17970	13707	13378	13378
   query15	370	232	237	232
   query16	6437	265	269	265
   query17	1704	1463	847	847
   query18	2336	403	414	403
   query19	202	142	153	142
   query20	77	78	77	77
   query21	185	96	92	92
   query22	5314	5166	5062	5062
   query23	32538	31851	32034	31851
   query24	6901	6460	6494	6460
   query25	534	435	412	412
   query26	522	163	157	157
   query27	1872	293	287	287
   query28	6110	2203	2180	2180
   query29	2974	2671	2699	2671
   query30	235	156	158	156
   query31	897	716	718	716
   query32	71	61	59	59
   query33	397	239	248	239
   query34	834	458	462	458
   query35	1115	929	946	929
   query36	1577	1532	1434	1434
   query37	91	62	57	57
   query38	3064	2908	2876	2876
   query39	1349	1321	1307	1307
   query40	198	96	94	94
   query41	39	34	31	31
   query42	81	82	78	78
   query43	665	693	534	534
   query44	1131	704	713	704
   query45	241	224	228	224
   query46	1236	980	978	978
   query47	1780	1693	1638	1638
   query48	977	674	658	658
   query49	612	380	362	362
   query50	859	593	562	562
   query51	4756	4726	4713	4713
   query52	88	87	89	87
   query53	436	313	315	313
   query54	2646	2482	2476	2476
   query55	86	80	74	74
   query56	226	219	207	207
   query57	1212	1078	1018	1018
   query58	208	199	202	199
   query59	3302	3404	3294	3294
   query60	199	203	184	184
   query61	86	98	83	83
   query62	854	494	494	494
   query63	460	339	332	332
   query64	2342	1505	1372	1372
   query65	3619	3586	3519	3519
   query66	779	383	358	358
   query67	15825	15984	15379	15379
   query68	8750	659	669	659
   query69	570	320	329	320
   query70	1914	1833	1785	1785
   query71	413	310	303	303
   query72	6605	3418	3389	3389
   query73	744	319	319	319
   query74	6335	5780	5803	5780
   query75	4633	3740	3739	3739
   query76	4789	1166	1205	1166
   query77	642	245	245	245
   query78	12614	11894	11649	11649
   query79	10129	646	646	646
   query80	1531	369	387	369
   query81	502	232	231	231
   query82	1643	97	91	91
   query83	169	132	129	129
   query84	255	71	67	67
   query85	852	282	278	278
   query86	388	365	409	365
   query87	3190	3063	2990	2990
   query88	4992	2334	2287	2287
   query89	475	275	291	275
   query90	1949	210	195	195
   query91	151	115	118	115
   query92	58	48	48	48
   query93	7070	588	599	588
   query94	746	191	196	191
   query95	1106	1071	1056	1056
   query96	631	325	317	317
   query97	6517	6408	6462	6408
   query98	198	184	167	167
   query99	3027	862	983	862
   Total cold run time: 314667 ms
   Total hot run time: 201848 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970463667

   TeamCity be ut coverage result:
    Function Coverage: 37.80% (8035/21256) 
    Line Coverage: 29.48% (65538/222283)
    Region Coverage: 28.95% (33717/116486)
    Branch Coverage: 24.80% (17303/69778)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/0d1250d2d21e8a0c816de52f203ac23b74c94e93_0d1250d2d21e8a0c816de52f203ac23b74c94e93/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970399799

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970395186

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #31573:
URL: https://github.com/apache/doris/pull/31573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970394747

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0](timezone) Introduce a config to use Doris tzdata directly #31561 [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31573:
URL: https://github.com/apache/doris/pull/31573#issuecomment-1970475006

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 0d1250d2d21e8a0c816de52f203ac23b74c94e93 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org