[GitHub] [geode] nabarunnag commented on a change in pull request #6044: GEODE-8962: add an option to escape dollar($) character in query

[GitBox <gi...@apache.org>]

nabarunnag commented on a change in pull request #6044:
URL: https://github.com/apache/geode/pull/6044#discussion_r580678544



##########
File path: geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##########
@@ -141,6 +141,19 @@ public void testSimpleQuery() {
         new String[] {"ID", "status", "createTime", "pk", "floatMinValue"});
   }
 
+  @Test
+  public void testSimpleQueryWithEscapingCharacter() {
+    server1.invoke(() -> prepareDataForRegionWithSpecialCharacters(DATA_PAR_REGION_NAME_PATH));
+    String query = "query --query=\"select * from " + DATA_PAR_REGION_NAME_PATH
+        + " e where e LIKE 'value\\$'\"";
+    String query1 = "query --query=\"select * from " + DATA_PAR_REGION_NAME_PATH
+        + " e where e LIKE 'value\\%'\"";
+    CommandResult commandResult = gfsh.executeCommand(query);
+    CommandResult commandResult1 = gfsh.executeCommand(query1);
+    validateSelectResult(commandResult, true, 1, null);
+    validateSelectResult(commandResult1, true, 1, null);

Review comment:
       ```suggestion
       gfsh.executeAndAssertThat(query).statusIsSuccess().containsOutput("value$");
       gfsh.executeAndAssertThat(query1).statusIsSuccess().containsOutput("value%");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org