You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/19 09:10:57 UTC

[GitHub] [incubator-kyuubi] Baoqi opened a new pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Baoqi opened a new pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964


   Just write some basic tests out in other projects. 
   
   Since this toJavaRegex is not a static function, which is hard to write unit test if don't move it out as  as static function in object.  (But in that case, the change may be too large for this).
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] Baoqi commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
Baoqi commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902507663


   > The changes LGTM, but may I know where the original implementations come from?
   
   Hi, as in the comments of source code:
   
         * (referred to Spark's implementation: convertPattern function in file MetadataOperation.java)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] Baoqi edited a comment on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
Baoqi edited a comment on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902507663


   > The changes LGTM, but may I know where the original implementations come from?
   
   Hi, as in the comments of source code:
   
         * (referred to Spark's implementation: convertPattern function in file MetadataOperation.java)
   see https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/MetadataOperation.java#L103
   
   only the 3 lines are likely same with Spark's implementation.
   
   Since Kyuubi is based on Spark, and both projects belongs to Apache Foundation, so, I assume this is fine. But please let me know if we need a modified version. Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-901790878


   can we add a test then for `if there is _ in schema's name` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902427489


   we can add an end to end test for this case，it’s very easy to use the current test framework


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-901778744


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#964](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb11189) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/32b18ba19c969206d3ce03637560ff84f88009d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32b18ba) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #964      +/-   ##
   ============================================
   - Coverage     79.85%   79.82%   -0.03%     
     Complexity       11       11              
   ============================================
     Files           147      147              
     Lines          5455     5448       -7     
     Branches        654      649       -5     
   ============================================
   - Hits           4356     4349       -7     
   - Misses          717      720       +3     
   + Partials        382      379       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...kyuubi/engine/spark/operation/SparkOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtPcGVyYXRpb24uc2NhbGE=) | `68.85% <100.00%> (+0.19%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `47.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `45.52% <0.00%> (-0.82%)` | :arrow_down: |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `89.02% <0.00%> (-0.14%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32b18ba...cb11189](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-901778744


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#964](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb11189) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/32b18ba19c969206d3ce03637560ff84f88009d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32b18ba) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head cb11189 differs from pull request most recent head 985a73b. Consider uploading reports for the commit 985a73b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #964      +/-   ##
   ============================================
   - Coverage     79.85%   79.82%   -0.03%     
     Complexity       11       11              
   ============================================
     Files           147      147              
     Lines          5455     5448       -7     
     Branches        654      649       -5     
   ============================================
   - Hits           4356     4349       -7     
   - Misses          717      720       +3     
   + Partials        382      379       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...kyuubi/engine/spark/operation/SparkOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtPcGVyYXRpb24uc2NhbGE=) | `68.85% <100.00%> (+0.19%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `47.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `45.52% <0.00%> (-0.82%)` | :arrow_down: |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `89.02% <0.00%> (-0.14%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32b18ba...985a73b](https://codecov.io/gh/apache/incubator-kyuubi/pull/964?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902509070


   > > can we add a test then for `if there is _ in schema's name` ?
   > 
   > Sure, after some check, it seems the best place to add this test is in "get schemas" of BasicJDBCTests.scala.
   > 
   > it will be included in the following 5 final test suites:
   > 
   > * KyuubiOperationHiveCatalogSuite
   > * KyuubiOperationPerServerSuite
   > * KyuubiOperationPerUserSuite
   > * KyuubiStatementMonitorSuite
   > * SparkOperationSuite
   > 
   > Without my fix, but with my unit test change, the first 3 suite still success, but the last 2 will fail. (haven't got time to learn what is different between first 3 suites with the last 2 suites)
   > 
   > After my fix, for the new unit test change, all 5 suites will success.
   
   The first 3 suites are `jdbc-client` ==> `kyuubi-spark-engine`.
   The later 2 suites are `jdbc-client` ==> `kyuubi-server` ==> `kyuubi-spark-engine`.
   
   Seems somethings happens in `kyuubi-server` when passing through the request, like remove escape chars.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] Baoqi commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
Baoqi commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902497505


   > can we add a test then for `if there is _ in schema's name` ?
   
   Sure, after some check, it seems the best place to add this test is in "get schemas" of BasicJDBCTests.scala.
   
   it will be included in the following 5 final test suites:
     - KyuubiOperationHiveCatalogSuite
     - KyuubiOperationPerServerSuite
     - KyuubiOperationPerUserSuite
     - KyuubiStatementMonitorSuite
     - SparkOperationSuite
   
   Without my fix, but with my unit test change,   the first 3 suite still success, but the last 2 will fail.  (haven't got time to learn what is different between first 3 suites with the last 2 suites)
   
   After my fix, for the new unit test change,  all 5 suites will success. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902511320


   > > The changes LGTM, but may I know where the original implementations come from?
   > 
   > Hi, as in the comments of source code:
   > 
   > ```
   >   * (referred to Spark's implementation: convertPattern function in file MetadataOperation.java)
   > ```
   > 
   > see https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/MetadataOperation.java#L103
   > 
   > only the 3 lines are likely same with Spark's implementation.
   > 
   > Since Kyuubi is based on Spark, and both projects belongs to Apache Foundation, so, I assume this is fine. But please let me know if we need a modified version. Thanks.
   
   Yea, I see, what I mean **original implementations** is the existing code before this PR. Have a quick look on Hive codebase, didn't find the clue. @yaooqinn Do you remember that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902806484


   thanks, merged to master and 1.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902502395


   The changes LGTM, but may I know where the original implementations come from?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902509070


   > > can we add a test then for `if there is _ in schema's name` ?
   > 
   > Sure, after some check, it seems the best place to add this test is in "get schemas" of BasicJDBCTests.scala.
   > 
   > it will be included in the following 5 final test suites:
   > 
   > * KyuubiOperationHiveCatalogSuite
   > * KyuubiOperationPerServerSuite
   > * KyuubiOperationPerUserSuite
   > * KyuubiStatementMonitorSuite
   > * SparkOperationSuite
   > 
   > Without my fix, but with my unit test change, the first 3 suite still success, but the last 2 will fail. (haven't got time to learn what is different between first 3 suites with the last 2 suites)
   > 
   > After my fix, for the new unit test change, all 5 suites will success.
   
   The first 3 suites are `jdbc-client` ==> `kyuubi-server` ==> `kyuubi-spark-engine`.
   The later 2 suites are `jdbc-client` ==> `kyuubi-spark-engine`.
   
   Seems somethings happens in `kyuubi-server` when passing through the request, like remove escape chars.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902492873


   also cc @pan3793 as the release manager of 1.3.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org