You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sam Schmit <sa...@appcore.com> on 2014/05/02 20:15:20 UTC
Review Request 21015: CLOUDSTACK-6472 listUsageRecords: Pull information
from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21015/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-6472
https://issues.apache.org/jira/browse/CLOUDSTACK-6472
Repository: cloudstack-git
Description
-------
Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
Diffs
-----
server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
Diff: https://reviews.apache.org/r/21015/diff/
Testing
-------
1) Created virtual machine
2) Ran usage
3) ran "listUsageRecords" API call, successful data returned
4) Expunged VM
5) Ran usage
6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
Thanks,
Sam Schmit
Re: Review Request 21015: CLOUDSTACK-6472 listUsageRecords: Pull information
from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21015/#review42056
-----------------------------------------------------------
Commit fe84b674c14b6494770b489100e92a116b3b1f49 in cloudstack's branch refs/heads/4.4-forward from Sam Schmit
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fe84b67 ]
CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
- ASF Subversion and Git Services
On May 2, 2014, 6:15 p.m., Sam Schmit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21015/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:15 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
>
> Diff: https://reviews.apache.org/r/21015/diff/
>
>
> Testing
> -------
>
> 1) Created virtual machine
> 2) Ran usage
> 3) ran "listUsageRecords" API call, successful data returned
> 4) Expunged VM
> 5) Ran usage
> 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
>
>
> Thanks,
>
> Sam Schmit
>
>
Re: Review Request 21015: CLOUDSTACK-6472 listUsageRecords: Pull information
from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21015/#review42052
-----------------------------------------------------------
Ship it!
applied to master with 81b4731e3b5265943017f88b850421154184f7c5
thanks you can mark the review as submitted
- Sebastien Goasguen
On May 2, 2014, 6:15 p.m., Sam Schmit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21015/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:15 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
>
> Diff: https://reviews.apache.org/r/21015/diff/
>
>
> Testing
> -------
>
> 1) Created virtual machine
> 2) Ran usage
> 3) ran "listUsageRecords" API call, successful data returned
> 4) Expunged VM
> 5) Ran usage
> 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
>
>
> Thanks,
>
> Sam Schmit
>
>
Re: Review Request 21015: CLOUDSTACK-6472 listUsageRecords: Pull information
from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21015/#review42051
-----------------------------------------------------------
Commit 81b4731e3b5265943017f88b850421154184f7c5 in cloudstack's branch refs/heads/master from Sam Schmit
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=81b4731 ]
CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
- ASF Subversion and Git Services
On May 2, 2014, 6:15 p.m., Sam Schmit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21015/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:15 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
>
> Diff: https://reviews.apache.org/r/21015/diff/
>
>
> Testing
> -------
>
> 1) Created virtual machine
> 2) Ran usage
> 3) ran "listUsageRecords" API call, successful data returned
> 4) Expunged VM
> 5) Ran usage
> 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
>
>
> Thanks,
>
> Sam Schmit
>
>
Re: Review Request 21015: CLOUDSTACK-6472 listUsageRecords: Pull information
from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21015/#review42292
-----------------------------------------------------------
Commit 3a3457e7132d22f52aa38179d40a6eb9b0b29677 in cloudstack's branch refs/heads/4.4 from Sam Schmit
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3a3457e ]
CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
- ASF Subversion and Git Services
On May 2, 2014, 6:15 p.m., Sam Schmit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21015/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:15 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
>
> Diff: https://reviews.apache.org/r/21015/diff/
>
>
> Testing
> -------
>
> 1) Created virtual machine
> 2) Ran usage
> 3) ran "listUsageRecords" API call, successful data returned
> 4) Expunged VM
> 5) Ran usage
> 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
>
>
> Thanks,
>
> Sam Schmit
>
>