You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2026/03/04 22:39:22 UTC
[PR] Fixed ScanServerGroupConfigurationIT [accumulo]
dlmarion opened a new pull request, #6176:
URL: https://github.com/apache/accumulo/pull/6176
ScanServerGroupConfigurationIT was failing because the ConfigurableScanServerSelector only checks for new ScanServers at 5 second intervals and the test was doing a lookup too quickly. The fix for the test is to just wait 5 seconds.
This change includes adding trace logging into the ConfigurableScanServerSelector for better debugging and formatting some of the large JSON blocks using Java text blocks.
Closes #6154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanServerGroupConfigurationIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #6176:
URL: https://github.com/apache/accumulo/pull/6176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanServerGroupConfigurationIT [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #6176:
URL: https://github.com/apache/accumulo/pull/6176#discussion_r2891073613
##########
test/src/main/java/org/apache/accumulo/test/ScanServerGroupConfigurationIT.java:
##########
@@ -46,56 +46,60 @@
public class ScanServerGroupConfigurationIT extends SharedMiniClusterBase {
// @formatter:off
- public static final String clientConfiguration =
- "["+
- " {"+
- " \"isDefault\": true,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"scanTypeActivations\": [],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " },"+
- " {"+
- " \"isDefault\": false,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"group\": \"GROUP1\","+
- " \"scanTypeActivations\": [\"use_group1\"],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " }"+
- "]";
+ public static final String clientConfiguration = """
+ [ \
Review Comment:
Was going to leave a comment but ended up just throwing up a quick PR #6179
Looked into where the properties were being written to the file and I think thats where the disconnect might have been. We manually wrote the .properties file without proper escaping. #6179 uses `.store()` off of a properties object instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanServerGroupConfigurationIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6176:
URL: https://github.com/apache/accumulo/pull/6176#discussion_r2889619882
##########
test/src/main/java/org/apache/accumulo/test/ScanServerGroupConfigurationIT.java:
##########
@@ -46,56 +46,60 @@
public class ScanServerGroupConfigurationIT extends SharedMiniClusterBase {
// @formatter:off
- public static final String clientConfiguration =
- "["+
- " {"+
- " \"isDefault\": true,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"scanTypeActivations\": [],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " },"+
- " {"+
- " \"isDefault\": false,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"group\": \"GROUP1\","+
- " \"scanTypeActivations\": [\"use_group1\"],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " }"+
- "]";
+ public static final String clientConfiguration = """
+ [ \
Review Comment:
It suppresses the newline character (ref [this](https://docs.oracle.com/en/java/javase/17/text-blocks/index.html#new-escape-sequences)). With the newlines in the JSON the json parsing was failing because it was only seeing the first line. So it appears that the client properties don't support a newline in the property value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanServerGroupConfigurationIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6176:
URL: https://github.com/apache/accumulo/pull/6176#discussion_r2889728575
##########
test/src/main/java/org/apache/accumulo/test/ScanServerGroupConfigurationIT.java:
##########
@@ -46,56 +46,60 @@
public class ScanServerGroupConfigurationIT extends SharedMiniClusterBase {
// @formatter:off
- public static final String clientConfiguration =
- "["+
- " {"+
- " \"isDefault\": true,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"scanTypeActivations\": [],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " },"+
- " {"+
- " \"isDefault\": false,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"group\": \"GROUP1\","+
- " \"scanTypeActivations\": [\"use_group1\"],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " }"+
- "]";
+ public static final String clientConfiguration = """
+ [ \
Review Comment:
I think I tracked down the issue. It has to do with the properties being written to a file and then read back in. When using ` \` at the end of each line in the text block, then the newlines are suppressed so that when the property is written out to a file it's just one line. Without the ` \` at the end of the line, each line contains a newline.
In MiniAccumuloCluster, the client properties are written to a file at
https://github.com/apache/accumulo/blob/4a4d84b3a955716a9a6751d2addd3cbcb5fc2a58/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java#L271-L272
and then read back in at
https://github.com/apache/accumulo/blob/4a4d84b3a955716a9a6751d2addd3cbcb5fc2a58/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java#L192-L193
After reading the client properties back in, the profile property contains just one line, which in this case is `[` and the json parsing fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanServerGroupConfigurationIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6176:
URL: https://github.com/apache/accumulo/pull/6176#discussion_r2886695742
##########
test/src/main/java/org/apache/accumulo/test/ScanServerGroupConfigurationIT.java:
##########
@@ -46,56 +46,60 @@
public class ScanServerGroupConfigurationIT extends SharedMiniClusterBase {
// @formatter:off
- public static final String clientConfiguration =
- "["+
- " {"+
- " \"isDefault\": true,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"scanTypeActivations\": [],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " },"+
- " {"+
- " \"isDefault\": false,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"group\": \"GROUP1\","+
- " \"scanTypeActivations\": [\"use_group1\"],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " }"+
- "]";
+ public static final String clientConfiguration = """
+ [ \
Review Comment:
What is the purpose of these trailing slashes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanServerGroupConfigurationIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6176:
URL: https://github.com/apache/accumulo/pull/6176#discussion_r2891397896
##########
test/src/main/java/org/apache/accumulo/test/ScanServerGroupConfigurationIT.java:
##########
@@ -46,56 +46,60 @@
public class ScanServerGroupConfigurationIT extends SharedMiniClusterBase {
// @formatter:off
- public static final String clientConfiguration =
- "["+
- " {"+
- " \"isDefault\": true,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"scanTypeActivations\": [],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " },"+
- " {"+
- " \"isDefault\": false,"+
- " \"maxBusyTimeout\": \"5m\","+
- " \"busyTimeoutMultiplier\": 8,"+
- " \"group\": \"GROUP1\","+
- " \"scanTypeActivations\": [\"use_group1\"],"+
- " \"timeToWaitForScanServers\":\"0s\","+
- " \"attemptPlans\": ["+
- " {"+
- " \"servers\": \"3\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"one\""+
- " },"+
- " {"+
- " \"servers\": \"13\","+
- " \"busyTimeout\": \"33ms\","+
- " \"salt\": \"two\""+
- " },"+
- " {"+
- " \"servers\": \"100%\","+
- " \"busyTimeout\": \"33ms\""+
- " }"+
- " ]"+
- " }"+
- "]";
+ public static final String clientConfiguration = """
+ [ \
Review Comment:
i'll merge your changes in and then update this PR to remove the ` \` chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org