You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/08/27 02:37:29 UTC
Review Request 37823: libprocess: Update vendored copy of google-glog
to 0.3.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37823/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3322
https://issues.apache.org/jira/browse/MESOS-3322
Repository: mesos
Description
-------
This means we no longer need to apply a custom patch to glog.
Fixes MESOS-3322.
Diffs
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b
3rdparty/libprocess/3rdparty/Makefile.am eb34251d24b1e5d1540151b59cf1062ca85aeb03
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 92fa52d296fea2884bd58d6010b0f869611999f7
3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am f44c7153166225279b973615ef0441c6f945da5b
3rdparty/libprocess/cmake/ProcessConfigure.cmake 12506a1369de005285268f895f365aba0c560f78
Diff: https://reviews.apache.org/r/37823/diff/
Testing
-------
Rebuilt, "make check". Briefly tested building with cmake, although that seems broken on my machine for reasons unrelated to glog.
Thanks,
Neil Conway
Re: Review Request 37823: libprocess: Update vendored copy of
google-glog to 0.3.4
Posted by Neil Conway <ne...@gmail.com>.
Happy to help out :) Although the particular issue I ran into has
already been reported:
https://reviews.apache.org/r/37370/
https://issues.apache.org/jira/browse/MESOS-3270
Neil
On Wed, Aug 26, 2015 at 8:11 PM, Artem Harutyunyan <ar...@mesosphere.io> wrote:
>
> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37823/
>
> cmake is still under heavy development, so it's not supposed to work yet. We could you some cycles though if there was someone interested in helping us ship it :-).
>
>
> - Artem Harutyunyan
>
>
> On August 26th, 2015, 5:37 p.m. PDT, Neil Conway wrote:
>
> Review request for mesos.
> By Neil Conway.
>
> Updated Aug. 26, 2015, 5:37 p.m.
>
> Bugs: MESOS-3322
> Repository: mesos
>
> Description
>
> This means we no longer need to apply a custom patch to glog.
> Fixes MESOS-3322.
>
> Testing
>
> Rebuilt, "make check". Briefly tested building with cmake, although that seems broken on my machine for reasons unrelated to glog.
>
> Diffs
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt (997cc0d0e316e316136d4746e50e9e292a82b36b)
> 3rdparty/libprocess/3rdparty/Makefile.am (eb34251d24b1e5d1540151b59cf1062ca85aeb03)
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch (76b8c0fe3b4615371e265bab713d62c896b7c3d6)
> 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz (92fa52d296fea2884bd58d6010b0f869611999f7)
> 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz (PRE-CREATION)
> 3rdparty/libprocess/3rdparty/versions.am (f44c7153166225279b973615ef0441c6f945da5b)
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake (12506a1369de005285268f895f365aba0c560f78)
>
> View Diff
Re: Review Request 37823: libprocess: Update vendored copy of
google-glog to 0.3.4
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37823/#review96632
-----------------------------------------------------------
cmake is still under heavy development, so it's not supposed to work yet. We could you some cycles though if there was someone interested in helping us ship it :-).
- Artem Harutyunyan
On Aug. 26, 2015, 5:37 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37823/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:37 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3322
> https://issues.apache.org/jira/browse/MESOS-3322
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This means we no longer need to apply a custom patch to glog.
> Fixes MESOS-3322.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b
> 3rdparty/libprocess/3rdparty/Makefile.am eb34251d24b1e5d1540151b59cf1062ca85aeb03
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
> 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 92fa52d296fea2884bd58d6010b0f869611999f7
> 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am f44c7153166225279b973615ef0441c6f945da5b
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake 12506a1369de005285268f895f365aba0c560f78
>
> Diff: https://reviews.apache.org/r/37823/diff/
>
>
> Testing
> -------
>
> Rebuilt, "make check". Briefly tested building with cmake, although that seems broken on my machine for reasons unrelated to glog.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 37823: libprocess: Update vendored copy of
google-glog to 0.3.4
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37823/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 8:11 p.m.)
Review request for mesos.
Bugs: MESOS-3322
https://issues.apache.org/jira/browse/MESOS-3322
Repository: mesos
Description
-------
This means we no longer need to apply a custom patch to glog.
Fixes MESOS-3322.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b
3rdparty/libprocess/3rdparty/Makefile.am eb34251d24b1e5d1540151b59cf1062ca85aeb03
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 92fa52d296fea2884bd58d6010b0f869611999f7
3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am f44c7153166225279b973615ef0441c6f945da5b
3rdparty/libprocess/cmake/ProcessConfigure.cmake 12506a1369de005285268f895f365aba0c560f78
Diff: https://reviews.apache.org/r/37823/diff/
Testing
-------
Rebuilt, "make check". Briefly tested building with cmake, although that seems broken on my machine for reasons unrelated to glog.
Thanks,
Neil Conway