You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/29 07:01:41 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9943: style(mypy): Enforcing typing for superset
john-bodley opened a new pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943
### SUMMARY
Yay! After starting this endeavor over three months ago with https://github.com/apache/incubator-superset/pull/9138, this PR adds `mypy` type enforcement for the remainder of the `superset` package.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `11.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
===========================================
- Coverage 71.31% 59.40% -11.92%
===========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
===========================================
- Hits 22027 7568 -14459
+ Misses 8750 4993 -3757
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [308 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...306a5f6](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434182759
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
@villebro I'm not sure if you're aware but numerous files have `pylint` checks and warnings (not errors) disabled including `viz.py` per the line `# pylint: disable=C,R,W`. Note the plan is to address this in [SIP-46](https://github.com/apache/incubator-superset/issues/9953). Note I'm not quite mentally prepared for that saga yet as the typing work has left me a tad battered and bruised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `11.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
===========================================
- Coverage 71.31% 59.40% -11.92%
===========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
===========================================
- Hits 22027 7568 -14459
+ Misses 8750 4993 -3757
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [308 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...374aeca](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `11.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
===========================================
- Coverage 71.31% 59.40% -11.92%
===========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
===========================================
- Hits 22027 7568 -14459
+ Misses 8750 4993 -3757
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [308 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...9f6cd0d](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434185547
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
😄 I'm sure it has, kudos for this work! I think we need to bump `pylint` first, as the current version isn't compatible with `3.7`. I'm looking to see if there's interest in the community to help with that effort, as it might be a good task to get acquainted with the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley edited a comment on pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-637085903
@villebro et al. would you mind taking a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `83.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
+ Coverage 71.31% 71.37% +0.05%
==========================================
Files 585 585
Lines 30887 30933 +46
Branches 3236 3246 +10
==========================================
+ Hits 22027 22078 +51
+ Misses 8750 8746 -4
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.06% <ø> (+0.22%)` | :arrow_up: |
| #javascript | `59.39% <ø> (-0.02%)` | :arrow_down: |
| #python | `71.54% <83.08%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <40.00%> (-0.78%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <79.33%> (-0.03%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.51% <80.76%> (+0.15%)` | :arrow_up: |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <87.50%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.06% <95.00%> (+0.20%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.75% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.45% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.35% <100.00%> (+0.09%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...6bcbf55](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
serenajiang commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434058182
##########
File path: superset/app.py
##########
@@ -109,8 +111,8 @@ class AppContextTask(task_base): # type: ignore
abstract = True
# Grab each call into the task and set up an app context
- def __call__(self, *args, **kwargs):
- with flask_app.app_context():
+ def __call__(self, *args: Any, **kwargs: Any) -> Any:
+ with flask_app.app_context(): # type: ignore
Review comment:
This probably is for later, we should look into using the [flask stubs in typeshed](https://github.com/python/typeshed/tree/master/third_party/2and3/flask)
##########
File path: superset/viz.py
##########
@@ -2866,12 +2903,20 @@ def nest_values(self, levels, level=0, metric=None, dims=()):
{
"name": i,
"val": levels[level][metric][dims][i],
- "children": self.nest_values(levels, level + 1, metric, dims + (i,)),
+ "children": self.nest_values(levels, level + 1, metric, dims + [i]),
}
for i in levels[level][metric][dims].index
]
- def nest_procs(self, procs, level=-1, dims=(), time=None):
+ def nest_procs(
+ self,
+ procs: Dict[int, pd.DataFrame],
+ level: int = -1,
+ dims: Optional[Tuple[str, ...]] = None,
+ time: Optional[Any] = None,
Review comment:
```suggestion
time: Any = None,
```
##########
File path: superset/viz.py
##########
@@ -559,7 +563,7 @@ class TableViz(BaseViz):
is_timeseries = False
enforce_numerical_metrics = False
- def should_be_timeseries(self):
+ def should_be_timeseries(self) -> Optional[bool]:
Review comment:
In this case, if `should_be_timeseries()` is `None`, does that mean this is `False`? It could be good to cast the results to `bool` to avoid the weird sorts of results that occur with short circuiting + `.get`. Then, we can replace most of the `Optional[bool]` types with `bool`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `11.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
===========================================
- Coverage 71.31% 59.40% -11.92%
===========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
===========================================
- Hits 22027 7568 -14459
+ Misses 8750 4993 -3757
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [308 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...9a5b77f](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434182759
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
@villebro I'm not sure if you're aware but numerous files have `pylint` checks and warnings (not errors) disabled including `viz.py` per the line:
```
# pylint: disable=C,R,W
```
Note the plan is to address this in [SIP-46](https://github.com/apache/incubator-superset/issues/9953). Note I'm not quite mentally prepared for that saga yet as the typing work has left me a tad battered and bruised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 71.05% -0.26%
==========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
==========================================
- Hits 22027 9053 -12974
+ Misses 8750 3578 -5172
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.96% <ø> (+0.12%)` | :arrow_up: |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | | |
| [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
| [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | | |
| [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | | |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | | |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | | |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | | |
| [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | | |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...9f6cd0d](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `4.99%`.
> The diff coverage is `83.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 66.31% -5.00%
==========================================
Files 585 585
Lines 30887 30851 -36
Branches 3236 3246 +10
==========================================
- Hits 22027 20460 -1567
- Misses 8750 10212 +1462
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.02%)` | :arrow_down: |
| #python | `71.20% <83.08%> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <40.00%> (-1.74%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <79.33%> (-0.03%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.51% <80.76%> (+0.15%)` | :arrow_up: |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <87.50%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.06% <95.00%> (+0.20%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.75% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.45% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.35% <100.00%> (+0.09%)` | :arrow_up: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...6bcbf55](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434891778
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
Agreed regarding bumping `pylint` (this is actually mentioned in the SIP) as I ran into an issue trying to use a newer feature. I'm not sure if we can automate this, but periodically I think it's good that we go through and bump all our dependencies which should help us be more nimble to accommodate us supporting more recent Python versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-637085903
@villebro would you mind taking a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434178282
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
`d` looks like a bad variable name. I thought these were forbidden in `.pylintrc`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `0.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 70.57% -0.75%
==========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
==========================================
- Hits 22027 8991 -13036
+ Misses 8750 3634 -5116
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.17% <ø> (-0.68%)` | :arrow_down: |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | | |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...374aeca](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r432292500
##########
File path: setup.cfg
##########
@@ -53,7 +53,7 @@ order_by_type = false
ignore_missing_imports = true
no_implicit_optional = true
-[mypy-superset.bin.*,superset.charts.*,superset.commands.*,superset.common.*,superset.connectors.*,superset.dao.*,superset.dashboards.*,superset.datasets.*,superset.db_engine_specs.*,superset.db_engines.*,superset.examples.*,superset.migrations.*,superset.models.*,uperset.queries.*,superset.security.*,superset.sql_validators.*,superset.tasks.*,superset.translations.*,superset.utils.*,superset.views.chart.*,superset.views.dashboard.*,superset.views.database.*]
+[mypy-superset,superset.app,superset.bin.*,superset.charts.*,superset.cli,superset.commands.*,superset.common.*,superset.config,superset.connectors.*,superset.constants,superset.dataframe,superset.dao.*,superset.dashboards.*,superset.datasets.*,superset.db_engine_specs.*,superset.db_engines.*,superset.errors,superset.examples.*,superset.exceptions,superset.extensions,superset.forms,superset.jinja_context,superset.legacy,superset.migrations.*,superset.models.*,superset.result_set,superset.queries.*,superset.security.*,superset.sql_lab,superset.sql_parse,superset.sql_validators.*,superset.stats_logger,superset.tasks.*,superset.translations.*,superset.typing,superset.utils.*,superset.views.chart.*,superset.views.dashboard.*,superset.views.database.*,superset.viz,superset.viz_sip38]
Review comment:
Note after this PR and https://github.com/apache/incubator-superset/pull/9939 are merged this should be updated to read,
```
[mypy-superset.*]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `4.99%`.
> The diff coverage is `83.52%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 66.32% -5.00%
==========================================
Files 585 585
Lines 30887 30826 -61
Branches 3236 3237 +1
==========================================
- Hits 22027 20445 -1582
- Misses 8750 10202 +1452
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.19% <83.52%> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <40.00%> (-1.74%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <79.19%> (-0.03%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.51% <80.76%> (+0.15%)` | :arrow_up: |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <87.50%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.06% <95.00%> (+0.20%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.45% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.35% <100.00%> (+0.09%)` | :arrow_up: |
| ... and [171 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...bb4eb34](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `0.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 70.57% -0.75%
==========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
==========================================
- Hits 22027 8991 -13036
+ Misses 8750 3634 -5116
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.17% <ø> (-0.67%)` | :arrow_down: |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | | |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...9f6cd0d](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434086449
##########
File path: superset/app.py
##########
@@ -109,8 +111,8 @@ class AppContextTask(task_base): # type: ignore
abstract = True
# Grab each call into the task and set up an app context
- def __call__(self, *args, **kwargs):
- with flask_app.app_context():
+ def __call__(self, *args: Any, **kwargs: Any) -> Any:
+ with flask_app.app_context(): # type: ignore
Review comment:
@serenajiang `mypy` does use these stubs. I presume the Flask types aren't fully flushed out. I plan on creating a follow up PR which will check for erroneous `# type: ignore` comments which then can be removed as `mypy` continues to evolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434182759
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
@villebro I'm not sure if you're aware, but numerous files have `pylint` checks and warnings (not errors) disabled including `viz.py` per the line:
```
# pylint: disable=C,R,W
```
Note the plan is to address this in [SIP-46](https://github.com/apache/incubator-superset/issues/9953). I'm not quite mentally prepared for that saga yet as the typing work has left me a tad battered and bruised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `11.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
===========================================
- Coverage 71.31% 59.40% -11.92%
===========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
===========================================
- Hits 22027 7568 -14459
+ Misses 8750 4993 -3757
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [308 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...96d7915](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `11.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
===========================================
- Coverage 71.31% 59.40% -11.92%
===========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
===========================================
- Hits 22027 7568 -14459
+ Misses 8750 4993 -3757
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [308 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...9a5b77f](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 71.05% -0.26%
==========================================
Files 585 401 -184
Lines 30887 12740 -18147
Branches 3236 3237 +1
==========================================
- Hits 22027 9053 -12974
+ Misses 8750 3578 -5172
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.95% <ø> (+0.11%)` | :arrow_up: |
| #javascript | `59.40% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/chart/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvbWl4aW4ucHk=) | | |
| [superset/datasets/commands/refresh.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvcmVmcmVzaC5weQ==) | | |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | | |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | | |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | | |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | | |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...374aeca](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9943: style(mypy): Enforcing typing for superset module
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org