You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/31 15:31:15 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #24850: Run change point analysis on GHA
AnandInguva opened a new pull request, #24850:
URL: https://github.com/apache/beam/pull/24850
Service account needs to have permission to read/write from `apache-beam-testing` project's BigQuery.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24850: Run change point analysis on GHA
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24850:
URL: https://github.com/apache/beam/pull/24850#issuecomment-1369856451
Otherwise, this mostly looks good to me, though @tvalentyn may have thoughts since he reviewed the initial change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24850: Run change point analysis on GHA
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24850:
URL: https://github.com/apache/beam/pull/24850#issuecomment-1369855759
> R: @damccorm We need to verify on if the service account has necessary permissions.
Right now, this won't work on GitHub Actions since we're using GitHub's pool of runners (ubuntu-latest), not our own self-hosted runners. We're planning to move to self-hosted this month, which should include adding service account access to those runners.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24850: Run change point analysis on GHA
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24850:
URL: https://github.com/apache/beam/pull/24850#issuecomment-1368243221
# [Codecov](https://codecov.io/gh/apache/beam/pull/24850?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24850](https://codecov.io/gh/apache/beam/pull/24850?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc74ce) into [master](https://codecov.io/gh/apache/beam/commit/3ee5b86a3f16dc92b6825773cf134d1315610251?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee5b86) will **decrease** coverage by `16.29%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #24850 +/- ##
===========================================
- Coverage 65.19% 48.90% -16.30%
===========================================
Files 731 731
Lines 97960 97960
===========================================
- Hits 63869 47910 -15959
- Misses 32736 48695 +15959
Partials 1355 1355
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `47.76% <0.00%> (-23.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/analyzers/constants.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9hbmFseXplcnMvY29uc3RhbnRzLnB5) | `0.00% <0.00%> (ø)` | |
| [...ache\_beam/testing/analyzers/github\_issues\_utils.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9hbmFseXplcnMvZ2l0aHViX2lzc3Vlc191dGlscy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/testing/analyzers/perf\_analysis.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9hbmFseXplcnMvcGVyZl9hbmFseXNpcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/ml/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvX19pbml0X18ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [sdks/python/apache\_beam/tools/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdG9vbHMvX19pbml0X18ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/snippets/util.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdXRpbC5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...on/apache\_beam/runners/direct/helper\_transforms.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvaGVscGVyX3RyYW5zZm9ybXMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...beam/transforms/fully\_qualified\_named\_transform.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9mdWxseV9xdWFsaWZpZWRfbmFtZWRfdHJhbnNmb3JtLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...am/examples/snippets/transforms/aggregation/max.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9tYXgucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...am/examples/snippets/transforms/aggregation/min.py](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9taW4ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [269 more](https://codecov.io/gh/apache/beam/pull/24850/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24850: Run change point analysis on GHA
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24850:
URL: https://github.com/apache/beam/pull/24850#issuecomment-1368242272
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva closed pull request #24850: Run change point analysis on GHA
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva closed pull request #24850: Run change point analysis on GHA
URL: https://github.com/apache/beam/pull/24850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #24850: Run change point analysis on GHA
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24850:
URL: https://github.com/apache/beam/pull/24850#issuecomment-1368242147
R: @damccorm We need to verify on if the service account has necessary permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #24850: Run change point analysis on GHA
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24850:
URL: https://github.com/apache/beam/pull/24850#issuecomment-1369865810
Yes, Valentyn is OOO as of now. I need to discuss one change with him. But wrt infra, I think once the service account is set, then this should be good for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org