You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "sjvanrossum (via GitHub)" <gi...@apache.org> on 2024/10/24 08:01:10 UTC
[PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
sjvanrossum opened a new pull request, #32921:
URL: https://github.com/apache/beam/pull/32921
This reverts #31137 and #31281. The changes in the former PR overwrite the per-split metric `backlog_bytes.${SPLIT}` with the per-partition metric rather than the accumulated value for the split. The latter PR introduced a map to store metrics for all past and current splits (1 partition) of the `ReadFromKafkaDoFn` instance and may repeatedly overwrite non-current splits with stale values. The map used to store these values is not thread-safe and may trigger a `ConcurrentModificationException` since `GetSize` and other SDF methods may concurrently attempt to read and write the map.
Finally, the per-split caches kept by the instance are keyed on `TopicPartition`, which is not unique among all splits since the split may override the bootstrap server. This has been fixed for this cache, all other caches will be patched in a separate PR.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2448570273
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2473524829
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @shunping for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2434651526
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2460302479
Done, thanks for reviewing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2473457339
Run Java_Examples_Dataflow PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2460102672
This LGTM, can you fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2473946257
Merge this as this was approved and merge conflict/test were cleared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2468490208
Can you check on the RAT test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #32921:
URL: https://github.com/apache/beam/pull/32921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #32921:
URL: https://github.com/apache/beam/pull/32921#issuecomment-2471702651
@johnjcasey rebased and updated where required. `PreCommit Java Examples Dataflow` seems to be failing, but passes for https://github.com/apache/beam/pull/32928 which is stacked on top of these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org