You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/17 16:12:55 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #26132: [SPARK-29387][SQL] Support `*` and `/` operators for intervals

MaxGekk commented on a change in pull request #26132: [SPARK-29387][SQL] Support `*` and `/` operators for intervals
URL: https://github.com/apache/spark/pull/26132#discussion_r336098564
 
 

 ##########
 File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
 ##########
 @@ -355,6 +355,18 @@ public CalendarInterval subtract(CalendarInterval that) {
     return new CalendarInterval(months, microseconds);
   }
 
+  public CalendarInterval multiply(double num) {
+    int months = Math.toIntExact((long)(num * this.months));
 
 Review comment:
   I will check what it does.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org