You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2023/10/05 19:09:22 UTC
[PR] GH-38049: [R] Prevent `on_rosetta()` from warning [WIP] [arrow]
jonkeane opened a new pull request, #38052:
URL: https://github.com/apache/arrow/pull/38052
### Rationale for this change
Stop extraneous warnings.
### What changes are included in this PR?
Prevent warning when detecting translation, but on x86
### Are these changes tested?
Yes
### Are there any user-facing changes?
Yes, there will be fewer extraneous warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1751882628
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fdecb6a0bee5fb482705de14c161853fe2ea2b41.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17497756830) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1750781795
Thanks for merging.
For posterity only:
> (It floated in last night that the `system("...", ignore.stdout = TRUE) == 1` might be sufficient if the return code is what's causing the warning. Either way!)
We actually do need to inter to get the output. `system("...", ignore.stdout = TRUE) == 1 ` will be 1 if you're on x86 (because the command failed to find `sysctl.proc_translated`), but 0 on an M* processor _regardless if you're under emulation or not_ since the command succeeded at finding the property and printing 0 or 1 to the console depending on if you're in emulation or not. There might be a cleaner `system2` incantation, but I didn't want to drift too far from what was there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [WIP] [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1749581245
Revision: 673a604e9ddd80bda2ed9d0b20939c7831f50e46
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7c4a2d95fb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7c4a2d95fb)
|Task|Status|
|----|------|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/6424015015/job/17443748184)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [WIP] [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1749578300
@github-actions crossbow submit test-r-install-local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #38052:
URL: https://github.com/apache/arrow/pull/38052#discussion_r1348136644
##########
r/tests/testthat/test-arrow-pacakge.R:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+test_that("on_rosetta() does not warn", {
+ # There is no warning
+ expect_warning(on_rosetta(), NA)
Review Comment:
I wasn't actually able to find a way to test that the console output from stderr doesn't show here. I tried both `expect_output(..., NA)` and `expect_silent(...)` as well as capturing the output with `capture_output(...)` and `capture.output(...)` but none of those seemed to actually capture the console warning I'm seeing. This is _probably_ fine. I've tested locally and the output is supressed on my system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [WIP] [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1749503730
Revision: 58ff39bdedc19b77511f481578eb7a65c59c8b67
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1c137994ff](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1c137994ff)
|Task|Status|
|----|------|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/6423500886/job/17442126260)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1750611636
(It floated in last night that the `system("...", ignore.stdout = TRUE) == 1` might be sufficient if the return code is what's causing the warning. Either way!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [WIP] [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1749500466
@github-actions crossbow submit test-r-install-local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1750763629
I also checked this on 10.13 where it correctly silenced a warning that occurred as a result of a non-zero exit status/unknown old. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #38052:
URL: https://github.com/apache/arrow/pull/38052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38049: [R] Prevent `on_rosetta()` from warning [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #38052:
URL: https://github.com/apache/arrow/pull/38052#issuecomment-1751069641
And, actually writting that out now made me realize I had introduced a bug resolved in #38083 I tested this code on x86 but not M*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org