You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2014/12/01 23:45:13 UTC
[jira] [Comment Edited] (HBASE-12576) Add metrics for rolling the
HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230602#comment-14230602 ]
Sean Busbey edited comment on HBASE-12576 at 12/1/14 10:44 PM:
---------------------------------------------------------------
{code}
- {
- ((Log4JLogger)DataNode.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)LeaseManager.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)LogFactory.getLog("org.apache.hadoop.hdfs.server.namenode.FSNamesystem"))
- .getLogger().setLevel(Level.ALL);
- ((Log4JLogger)DFSClient.LOG).getLogger().setLevel(Level.ALL);
- }
+// {
+// ((Log4JLogger)DataNode.LOG).getLogger().setLevel(Level.ALL);
+// ((Log4JLogger)LeaseManager.LOG).getLogger().setLevel(Level.ALL);
+// ((Log4JLogger)LogFactory.getLog("org.apache.hadoop.hdfs.server.namenode.FSNamesystem"))
+// .getLogger().setLevel(Level.ALL);
+// ((Log4JLogger)DFSClient.LOG).getLogger().setLevel(Level.ALL);
+// }
{code}
Can we just remove this? these kinds of log level tweaks should really be happening in log4j properties.
(edit to fix quote -> code block. sorry)
was (Author: busbey):
{quote}
- {
- ((Log4JLogger)DataNode.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)LeaseManager.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)LogFactory.getLog("org.apache.hadoop.hdfs.server.namenode.FSNamesystem"))
- .getLogger().setLevel(Level.ALL);
- ((Log4JLogger)DFSClient.LOG).getLogger().setLevel(Level.ALL);
- }
+// {
+// ((Log4JLogger)DataNode.LOG).getLogger().setLevel(Level.ALL);
+// ((Log4JLogger)LeaseManager.LOG).getLogger().setLevel(Level.ALL);
+// ((Log4JLogger)LogFactory.getLog("org.apache.hadoop.hdfs.server.namenode.FSNamesystem"))
+// .getLogger().setLevel(Level.ALL);
+// ((Log4JLogger)DFSClient.LOG).getLogger().setLevel(Level.ALL);
+// }
{quote}
Can we just remove this? these kinds of log level tweaks should really be happening in log4j properties.
> Add metrics for rolling the HLog if there are too few DN's in the write pipeline
> --------------------------------------------------------------------------------
>
> Key: HBASE-12576
> URL: https://issues.apache.org/jira/browse/HBASE-12576
> Project: HBase
> Issue Type: Bug
> Components: metrics, wal
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 2.0.0, 0.99.2
>
> Attachments: HBASE-12576-v1.patch, HBASE-12576-v3.patch, HBASE-12576.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)