You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/07 20:35:01 UTC
[GitHub] [ignite] NSAmelchev opened a new pull request #8005: IGNITE-13227 AssertionError on getting cache size from the mbean on the inactive cluster
NSAmelchev opened a new pull request #8005:
URL: https://github.com/apache/ignite/pull/8005
Metrics fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev commented on a change in pull request #8005: IGNITE-13227 AssertionError on getting cache size from the mbean on the inactive cluster
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #8005:
URL: https://github.com/apache/ignite/pull/8005#discussion_r454144966
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheMetricsImpl.java
##########
@@ -1221,6 +1221,11 @@ private boolean isValidForOperation(boolean read) {
* Calculates entries count/partitions count metrics using one iteration over local partitions for all metrics
*/
public EntriesStatMetrics getEntriesStat() {
+ AffinityTopologyVersion topVer = cctx.affinity().affinityTopologyVersion();
+
+ if (AffinityTopologyVersion.NONE.equals(topVer))
+ return new EntriesStatMetrics();
Review comment:
I have fixed with -1 values.
MTCGA rerun green visa: https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/8005/head&action=Latest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8005: IGNITE-13227 AssertionError on getting cache size from the mbean on the inactive cluster
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8005:
URL: https://github.com/apache/ignite/pull/8005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #8005: IGNITE-13227 AssertionError on getting cache size from the mbean on the inactive cluster
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #8005:
URL: https://github.com/apache/ignite/pull/8005#discussion_r453670446
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheMetricsImpl.java
##########
@@ -1221,6 +1221,11 @@ private boolean isValidForOperation(boolean read) {
* Calculates entries count/partitions count metrics using one iteration over local partitions for all metrics
*/
public EntriesStatMetrics getEntriesStat() {
+ AffinityTopologyVersion topVer = cctx.affinity().affinityTopologyVersion();
+
+ if (AffinityTopologyVersion.NONE.equals(topVer))
+ return new EntriesStatMetrics();
Review comment:
Shouldn't we treat not activated cluster as an error and return -1 field values instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org