You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/04 14:53:26 UTC
Review Request 62066: Updated Pylint similarities config to ignore
imports.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62066/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This is useful as CLI plugins have similar imports.
Diffs
-----
src/python/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818
Diff: https://reviews.apache.org/r/62066/diff/1/
Testing
-------
Thanks,
Armand Grillet
Re: Review Request 62066: Updated pylint to ignore errors for
'similar' imports across files.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62066/#review185984
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Sept. 22, 2017, 12:47 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62066/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 12:47 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without this change pylint will complain when multiple files have very similar imports. This happens in the Mesos CLI because all of our 'plugins' import the same modules. This commit tells pylint to ignore similarities in 'import' statements to avoid these errors.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818
>
>
> Diff: https://reviews.apache.org/r/62066/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62066: Updated pylint to ignore errors for
'similar' imports across files.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62066/
-----------------------------------------------------------
(Updated Sept. 22, 2017, 12:47 p.m.)
Review request for mesos and Kevin Klues.
Summary (updated)
-----------------
Updated pylint to ignore errors for 'similar' imports across files.
Repository: mesos
Description (updated)
-------
Without this change pylint will complain when multiple files have very similar imports. This happens in the Mesos CLI because all of our 'plugins' import the same modules. This commit tells pylint to ignore similarities in 'import' statements to avoid these errors.
Diffs
-----
src/python/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818
Diff: https://reviews.apache.org/r/62066/diff/1/
Testing
-------
Thanks,
Armand Grillet