You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jingsong Lee (JIRA)" <ji...@apache.org> on 2019/05/09 03:28:01 UTC

[jira] [Updated] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

     [ https://issues.apache.org/jira/browse/FLINK-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jingsong Lee updated FLINK-12453:
---------------------------------
    Description: 
In generateAggsHandler: 

val generator = new AggsHandlerCodeGenerator(
   CodeGeneratorContext(config),
   relBuilder,
   FlinkTypeFactory.toInternalRowType(inputRowType).getFieldTypes,
   needRetract = false,
   config.getNullCheck,
   inputFieldCopy)

but AggsHandlerCodeGenerator args is:

class AggsHandlerCodeGenerator(
   ctx: CodeGeneratorContext,
   relBuilder: RelBuilder,
   inputFieldTypes: Seq[InternalType],
   needRetract: Boolean,
   copyInputField: Boolean,
   needAccumulate: Boolean = true)

Same issue to StreamExecIncrementalGroupAggregate

  was:
In generateAggsHandler: 

val generator = new AggsHandlerCodeGenerator(
  CodeGeneratorContext(config),
  relBuilder,
  FlinkTypeFactory.toInternalRowType(inputRowType).getFieldTypes,
  needRetract = false,
  config.getNullCheck,
  inputFieldCopy)

but AggsHandlerCodeGenerator args is:

class AggsHandlerCodeGenerator(
  ctx: CodeGeneratorContext,
  relBuilder: RelBuilder,
  inputFieldTypes: Seq[InternalType],
  needRetract: Boolean,
  copyInputField: Boolean,
  needAccumulate: Boolean = true)


> StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-12453
>                 URL: https://issues.apache.org/jira/browse/FLINK-12453
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>            Reporter: Jingsong Lee
>            Assignee: Jark Wu
>            Priority: Major
>
> In generateAggsHandler: 
> val generator = new AggsHandlerCodeGenerator(
>    CodeGeneratorContext(config),
>    relBuilder,
>    FlinkTypeFactory.toInternalRowType(inputRowType).getFieldTypes,
>    needRetract = false,
>    config.getNullCheck,
>    inputFieldCopy)
> but AggsHandlerCodeGenerator args is:
> class AggsHandlerCodeGenerator(
>    ctx: CodeGeneratorContext,
>    relBuilder: RelBuilder,
>    inputFieldTypes: Seq[InternalType],
>    needRetract: Boolean,
>    copyInputField: Boolean,
>    needAccumulate: Boolean = true)
> Same issue to StreamExecIncrementalGroupAggregate



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)