[GitHub] [pulsar] RobertIndie commented on a diff in pull request #16248: [fix] [transaction] Cmd-Subscribe and Cmd-Producer will not succeed even after 100 retries

[GitBox <gi...@apache.org>]

RobertIndie commented on code in PR #16248:
URL: https://github.com/apache/pulsar/pull/16248#discussion_r907956787


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckReplyCallBack.java:
##########
@@ -53,8 +54,10 @@ public void replayComplete() {
                 log.info("Topic name : [{}], SubName : [{}] pending ack handle cache request success!",
                         pendingAckHandle.getTopicName(), pendingAckHandle.getSubName());
             } else {
-                log.error("Topic name : [{}], SubName : [{}] pending ack state reply fail!",
-                        pendingAckHandle.getTopicName(), pendingAckHandle.getSubName());
+                log.error("Topic name : [{}], SubName : [{}] pending ack state reply fail! current state: {}",
+                        pendingAckHandle.getTopicName(), pendingAckHandle.getSubName(), pendingAckHandle.state);
+                replayFailed(new TransactionPendingAckException.TransactionPendingAckStoreReplayException("Change"
+                        + " PendingAckHandle state to Ready failure, current state is : " + pendingAckHandle.state));

Review Comment:
   ```suggestion
                   replayFailed(new TransactionPendingAckException.TransactionPendingAckStoreReplayException("Failed"
                           + "to change PendingAckHandle state to Ready, current state is : " + pendingAckHandle.state));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org