You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/04 03:35:27 UTC

[GitHub] [kafka] zhaohaidao opened a new pull request #10971: KAFKA-12992 Make kraft configuration properties public

zhaohaidao opened a new pull request #10971:
URL: https://github.com/apache/kafka/pull/10971


   All of the Kraft configurations should be made public:
   `
   
           /*
            * KRaft mode configs. Note that these configs are defined as internal. We will make them public in the 3.0.0 release.
            */
           .defineInternal(ProcessRolesProp, LIST, Collections.emptyList(), ValidList.in("broker", "controller"), HIGH, ProcessRolesDoc)
           .defineInternal(NodeIdProp, INT, Defaults.EmptyNodeId, null, HIGH, NodeIdDoc)
           .defineInternal(InitialBrokerRegistrationTimeoutMsProp, INT, Defaults.InitialBrokerRegistrationTimeoutMs, null, MEDIUM, InitialBrokerRegistrationTimeoutMsDoc)
           .defineInternal(BrokerHeartbeatIntervalMsProp, INT, Defaults.BrokerHeartbeatIntervalMs, null, MEDIUM, BrokerHeartbeatIntervalMsDoc)
           .defineInternal(BrokerSessionTimeoutMsProp, INT, Defaults.BrokerSessionTimeoutMs, null, MEDIUM, BrokerSessionTimeoutMsDoc)
           .defineInternal(MetadataLogDirProp, STRING, null, null, HIGH, MetadataLogDirDoc)
           .defineInternal(ControllerListenerNamesProp, STRING, null, null, HIGH, ControllerListenerNamesDoc)
           .defineInternal(SaslMechanismControllerProtocolProp, STRING, SaslConfigs.DEFAULT_SASL_MECHANISM, null, HIGH, SaslMechanismControllerProtocolDoc)
   
   `
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10971: KAFKA-12992 Make kraft configuration properties public

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10971:
URL: https://github.com/apache/kafka/pull/10971


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10971: KAFKA-12992 Make kraft configuration properties public

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10971:
URL: https://github.com/apache/kafka/pull/10971


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] zhaohaidao commented on pull request #10971: KAFKA-12992 Make kraft configuration properties public

Posted by GitBox <gi...@apache.org>.
zhaohaidao commented on pull request #10971:
URL: https://github.com/apache/kafka/pull/10971#issuecomment-873511295


   @jsancio  Could you please review this pr if you have time, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org