[GitHub] [helix] alirezazamani commented on a change in pull request #944: Add CustomizedView Root Change Listener to the Router

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #944: Add CustomizedView Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944#discussion_r406877810
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
 ##########
 @@ -683,6 +694,27 @@ public void onCustomizedViewChange(List<CustomizedView> customizedViewList,
     }
   }
 
+  @Override
+  @PreFetch(enabled = false)
+  public void onCustomizedViewRootChange(List<String> customizedViewTypes,
 
 Review comment:
   I added prefetch to the code in case we want to enable it in the future. However, we do not use it here. At the end of the day, I think intersection does not matter and here we only need to register what user requested. Please let me know if that answers your question.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org