You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 02:02:08 UTC

[GitHub] [arrow] guyuqi opened a new pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

guyuqi opened a new pull request #12502:
URL: https://github.com/apache/arrow/pull/12502


   Implement 'bitmap_neon' with Arm64 GoLang Assembly:
   1. Implement 'extract_bits' with Arm64 GoLang Assembly. '_pext_u64' is the x86 bmi intrinsics for extract_bits.
   There is no equivalent of '_pext_u64' instruction on Arm64.
   The task is to implement equivalent of '_pext_u64' by Arm64 assembly.
   
   2. Implement 'levels_to_bitmap' with Arm64 GoLang Assembly for greaterThanBitmapNEON
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade closed pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12502:
URL: https://github.com/apache/arrow/pull/12502


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1051067417


   Benchmark runs are scheduled for baseline = f135b986db44358c1b41d7552d0e77009aa8c1c7 and contender = 960941cdeae1e6d3977176caa7f3fbb700ebbb11. 960941cdeae1e6d3977176caa7f3fbb700ebbb11 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/aea46201de69499daec3910592f35d2f...88a16517ba974dd2aed75329549970ad/)
   [Finished :arrow_down:1.47% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/24dba55113124b6392941f082c50b52d...5c5f4feedd684cd58cb0e5cb98c2a3ea/)
   [Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/081399effe43433bbb28ae7efb77a35b...7c0415eb47ec4493afca353429df1543/)
   [Finished :arrow_down:0.3% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/00cf8edfbbc04db49e89fa09bd57ee3d...f6709aacb0b947a08bc0bbbbeb4a50a3/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1050046342


   @guyuqi Was the Go build on Arm already failing or is it failing due to this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1049419648


   https://issues.apache.org/jira/browse/ARROW-15742


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1051067417


   Benchmark runs are scheduled for baseline = f135b986db44358c1b41d7552d0e77009aa8c1c7 and contender = 960941cdeae1e6d3977176caa7f3fbb700ebbb11. 960941cdeae1e6d3977176caa7f3fbb700ebbb11 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/aea46201de69499daec3910592f35d2f...88a16517ba974dd2aed75329549970ad/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/24dba55113124b6392941f082c50b52d...5c5f4feedd684cd58cb0e5cb98c2a3ea/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/081399effe43433bbb28ae7efb77a35b...7c0415eb47ec4493afca353429df1543/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/00cf8edfbbc04db49e89fa09bd57ee3d...f6709aacb0b947a08bc0bbbbeb4a50a3/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1051067417


   Benchmark runs are scheduled for baseline = f135b986db44358c1b41d7552d0e77009aa8c1c7 and contender = 960941cdeae1e6d3977176caa7f3fbb700ebbb11. 960941cdeae1e6d3977176caa7f3fbb700ebbb11 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/aea46201de69499daec3910592f35d2f...88a16517ba974dd2aed75329549970ad/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/24dba55113124b6392941f082c50b52d...5c5f4feedd684cd58cb0e5cb98c2a3ea/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/081399effe43433bbb28ae7efb77a35b...7c0415eb47ec4493afca353429df1543/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/00cf8edfbbc04db49e89fa09bd57ee3d...f6709aacb0b947a08bc0bbbbeb4a50a3/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] guyuqi commented on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1050584614


   @zeroshade Fixed related issues in 3rd commit.
   `TestDefLevelsToBitmap `passed on both x86 and Arm64.
   In `/arrow/go/parquet/file`:
   
   ```
   ARM_ENABLE_EXT=NEON go test
   PASS
   ok      github.com/apache/arrow/go/v8/parquet/file      13.898s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12502:
URL: https://github.com/apache/arrow/pull/12502#issuecomment-1051067417


   Benchmark runs are scheduled for baseline = f135b986db44358c1b41d7552d0e77009aa8c1c7 and contender = 960941cdeae1e6d3977176caa7f3fbb700ebbb11. 960941cdeae1e6d3977176caa7f3fbb700ebbb11 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/aea46201de69499daec3910592f35d2f...88a16517ba974dd2aed75329549970ad/)
   [Finished :arrow_down:1.47% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/24dba55113124b6392941f082c50b52d...5c5f4feedd684cd58cb0e5cb98c2a3ea/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/081399effe43433bbb28ae7efb77a35b...7c0415eb47ec4493afca353429df1543/)
   [Finished :arrow_down:0.3% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/00cf8edfbbc04db49e89fa09bd57ee3d...f6709aacb0b947a08bc0bbbbeb4a50a3/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org