You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/16 13:51:49 UTC

[GitHub] [iotdb] jun0315 opened a new pull request #3988: [IOTDB-1037] parse url param and add ut

jun0315 opened a new pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988


   parse url param and add UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3988: [IOTDB-1037] set rpc_compression as a parameter in JDBC URL

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988#issuecomment-920957330


   
   [![Coverage Status](https://coveralls.io/builds/43092524/badge)](https://coveralls.io/builds/43092524)
   
   Coverage increased (+0.0006%) to 67.479% when pulling **f6ac1e1335801d02ce27341e604590f0226e4593 on jun0315:feature_rpc_compression_jdbc** into **e5d86c9d1d5de1934c77d2ea4f97f8cd6d669bb8 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 merged pull request #3988: [IOTDB-1037] set rpc_compression as a parameter in JDBC URL

Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #3988: [IOTDB-1037] parse url param and add ut

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988#issuecomment-920957330


   
   [![Coverage Status](https://coveralls.io/builds/42924442/badge)](https://coveralls.io/builds/42924442)
   
   Coverage increased (+0.08%) to 67.559% when pulling **0c3d408d55966a659868628bea8f69721ed99e3e on jun0315:feature_rpc_compression_jdbc** into **e5d86c9d1d5de1934c77d2ea4f97f8cd6d669bb8 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 merged pull request #3988: [IOTDB-1037] set rpc_compression as a parameter in JDBC URL

Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jun0315 commented on pull request #3988: [IOTDB-1037] set rpc_compression as a parameter in JDBC URL

Posted by GitBox <gi...@apache.org>.
jun0315 commented on pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988#issuecomment-927960566


   > LGTM
   > Should we update the JDBC user guide to introduce this new feature?
   
   Hi, I have updated the JDBC user guide to introduce this new feature. :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3988: [IOTDB-1037] parse url param and add ut

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988#issuecomment-920957330


   
   [![Coverage Status](https://coveralls.io/builds/42924921/badge)](https://coveralls.io/builds/42924921)
   
   Coverage increased (+0.07%) to 67.551% when pulling **0c3d408d55966a659868628bea8f69721ed99e3e on jun0315:feature_rpc_compression_jdbc** into **e5d86c9d1d5de1934c77d2ea4f97f8cd6d669bb8 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jun0315 commented on pull request #3988: [IOTDB-1037] set rpc_compression as a parameter in JDBC URL

Posted by GitBox <gi...@apache.org>.
jun0315 commented on pull request #3988:
URL: https://github.com/apache/iotdb/pull/3988#issuecomment-927607378


   > LGTM
   > Should we update the JDBC user guide to introduce this new feature?
   
   Thanks for your review, If it needs to be updated, I will update it to the user manual recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org