You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/01/11 16:01:19 UTC

Review Request 42144: Removed deprecated constructor of http::Unauthorized in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42144/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Ben Mahler, and Till Toenshoff.


Repository: mesos


Description
-------

The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the libprocess codebase.

This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.


Diffs
-----

  3rdparty/libprocess/include/process/http.hpp ed708fe4b0006782a19f9c61603f152e32a02e8e 
  3rdparty/libprocess/src/authenticator.cpp 7371a62ecb2b3a42cb5ff5fb78bc4bcdb22875c4 
  3rdparty/libprocess/src/tests/http_tests.cpp e5999d8b49937a17033482c21536edb5c10420e6 

Diff: https://reviews.apache.org/r/42144/diff/


Testing
-------

make check


Thanks,

Alexander Rojas