You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/23 04:39:10 UTC
[GitHub] [superset] nikolagigic opened a new pull request #13294: feat(explore): Postgres datatype conversion
nikolagigic opened a new pull request #13294:
URL: https://github.com/apache/superset/pull/13294
### SUMMARY
Centralising postgresql datatype conversion.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `4.55%`.
> The diff coverage is `57.24%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 72.75% -4.56%
==========================================
Files 903 780 -123
Lines 45926 38445 -7481
Branches 5624 3670 -1954
==========================================
- Hits 35508 27971 -7537
- Misses 10282 10474 +192
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.75% <13.63%> (+2.29%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <97.22%> (-0.12%)` | :arrow_down: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `98.70% <ø> (-1.30%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `16.66% <16.66%> (-16.67%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `90.42% <20.00%> (-3.27%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `30.00% <33.33%> (-26.25%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...7e0d4d1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.92%`.
> The diff coverage is `63.90%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.38% -5.93%
==========================================
Files 903 823 -80
Lines 45926 41145 -4781
Branches 5624 4260 -1364
==========================================
- Hits 35508 29372 -6136
- Misses 10282 11773 +1491
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.16% <16.17%> (+0.70%)` | :arrow_up: |
| hive | `80.15% <96.03%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.91% <96.03%> (+0.18%)` | :arrow_up: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [502 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (4336ae5) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **increase** coverage by `2.90%`.
> The diff coverage is `98.73%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.31% 80.22% +2.90%
==========================================
Files 903 304 -599
Lines 45926 25064 -20862
Branches 5624 0 -5624
==========================================
- Hits 35508 20107 -15401
+ Misses 10282 4957 -5325
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `80.22% <98.73%> (?)` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.22% <98.73%> (-0.52%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.74% <90.90%> (-1.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.09% <100.00%> (-5.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `94.44% <100.00%> (+1.76%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <100.00%> (-0.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (-5.62%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.77% <100.00%> (-1.58%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| ... and [631 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r582315320
##########
File path: superset/db_engine_specs/base.py
##########
@@ -41,7 +41,8 @@
import sqlparse
from flask import g
from flask_babel import lazy_gettext as _
-from sqlalchemy import column, DateTime, select
+from sqlalchemy import column, DateTime, select, types
+from sqlalchemy.dialects.postgresql import DOUBLE_PRECISION
Review comment:
Seems like an extraneous import
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
Review comment:
Would it make sense to consolidate the structure of `db_column_types` and `column_type_mappings` as they are basically doing very similar things (one to convert db column type to generic types; one to convert to SQLA types)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...1bdebbf](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.91%`.
> The diff coverage is `63.90%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.40% -5.92%
==========================================
Files 903 823 -80
Lines 45926 41145 -4781
Branches 5624 4260 -1364
==========================================
- Hits 35508 29379 -6129
- Misses 10282 11766 +1484
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.20% <16.17%> (+0.75%)` | :arrow_up: |
| hive | `80.16% <96.03%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.91% <96.03%> (+0.18%)` | :arrow_up: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [501 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r592820389
##########
File path: superset/db_engine_specs/base.py
##########
@@ -145,8 +146,87 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
_date_trunc_functions: Dict[str, str] = {}
_time_grain_expressions: Dict[Optional[str], str] = {}
column_type_mappings: Tuple[
- Tuple[Pattern[str], Union[TypeEngine, Callable[[Match[str]], TypeEngine]]], ...,
- ] = ()
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SmallInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^integer", re.IGNORECASE),
Review comment:
There is an `INTEGEER` type in `mysql` dialect.
##########
File path: superset/db_engine_specs/base.py
##########
@@ -145,8 +146,87 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
_date_trunc_functions: Dict[str, str] = {}
_time_grain_expressions: Dict[Optional[str], str] = {}
column_type_mappings: Tuple[
- Tuple[Pattern[str], Union[TypeEngine, Callable[[Match[str]], TypeEngine]]], ...,
- ] = ()
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SmallInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^integer", re.IGNORECASE),
Review comment:
There is an `INTEGER` type in `mysql` dialect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.85%`.
> The diff coverage is `57.97%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.46% -5.86%
==========================================
Files 903 823 -80
Lines 45926 41141 -4785
Branches 5624 4262 -1362
==========================================
- Hits 35508 29400 -6108
- Misses 10282 11741 +1459
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.19% <13.63%> (+0.74%)` | :arrow_up: |
| hive | `80.16% <98.61%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `80.19% <98.61%> (+0.02%)` | :arrow_up: |
| python | `81.02% <98.61%> (+0.29%)` | :arrow_up: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `16.66% <16.66%> (-16.67%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `90.42% <20.00%> (-3.27%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `30.00% <33.33%> (-26.25%)` | :arrow_down: |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...7e0d4d1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (71a6671) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **increase** coverage by `3.19%`.
> The diff coverage is `76.44%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.31% 80.51% +3.19%
==========================================
Files 903 304 -599
Lines 45926 24807 -21119
Branches 5624 0 -5624
==========================================
- Hits 35508 19973 -15535
+ Misses 10282 4834 -5448
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| mysql | `80.37% <75.00%> (-0.09%)` | :arrow_down: |
| postgres | `80.42% <76.44%> (-0.08%)` | :arrow_down: |
| presto | `?` | |
| python | `80.51% <76.44%> (-0.22%)` | :arrow_down: |
| sqlite | `80.03% <75.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `50.00% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <87.50%> (-0.35%)` | :arrow_down: |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <92.30%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <92.30%> (-6.67%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.68% <100.00%> (+0.56%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `95.96% <100.00%> (+0.39%)` | :arrow_up: |
| ... and [594 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.85%`.
> The diff coverage is `57.97%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.46% -5.86%
==========================================
Files 903 823 -80
Lines 45926 41141 -4785
Branches 5624 4262 -1362
==========================================
- Hits 35508 29400 -6108
- Misses 10282 11741 +1459
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.19% <13.63%> (+0.74%)` | :arrow_up: |
| hive | `80.16% <98.61%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `80.19% <98.61%> (+0.02%)` | :arrow_up: |
| python | `81.02% <98.61%> (+0.29%)` | :arrow_up: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `16.66% <16.66%> (-16.67%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `90.42% <20.00%> (-3.27%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `30.00% <33.33%> (-26.25%)` | :arrow_down: |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.91%`.
> The diff coverage is `57.97%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.39% -5.92%
==========================================
Files 903 823 -80
Lines 45926 41141 -4785
Branches 5624 4262 -1362
==========================================
- Hits 35508 29373 -6135
- Misses 10282 11768 +1486
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.19% <13.63%> (+0.74%)` | :arrow_up: |
| hive | `80.16% <98.61%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.91% <98.61%> (+0.18%)` | :arrow_up: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `16.66% <16.66%> (-16.67%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `90.42% <20.00%> (-3.27%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `30.00% <33.33%> (-26.25%)` | :arrow_down: |
| ... and [497 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...7e0d4d1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...ebcbb53](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r587437139
##########
File path: superset/db_engine_specs/base.py
##########
@@ -145,8 +146,80 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
_date_trunc_functions: Dict[str, str] = {}
_time_grain_expressions: Dict[Optional[str], str] = {}
column_type_mappings: Tuple[
- Tuple[Pattern[str], Union[TypeEngine, Callable[[Match[str]], TypeEngine]]], ...,
- ] = ()
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
Review comment:
These should be instantiated: `types.SMALLINT()` instead of `types.SMALLINT`, otherwise the callback logic later on won't work where we check if the type is `callable` (see how Presto implements `VARCHAR`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r592803714
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -70,7 +70,7 @@ def test_is_db_column_type_match(self):
("TINYINT", GenericDataType.NUMERIC),
("SMALLINT", GenericDataType.NUMERIC),
("MEDIUMINT", GenericDataType.NUMERIC),
- ("INT", GenericDataType.NUMERIC),
+ ("INTEGER", GenericDataType.NUMERIC),
Review comment:
Isn't `INT` an official datatype in Mysql? https://dev.mysql.com/doc/refman/8.0/en/integer-types.html I think we need to keep this here.
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -89,18 +89,10 @@ def test_is_db_column_type_match(self):
("TIME", GenericDataType.TEMPORAL),
)
- for type_expectation in type_expectations:
- type_str = type_expectation[0]
- col_type = type_expectation[1]
- assert MySQLEngineSpec.is_db_column_type_match(
- type_str, GenericDataType.NUMERIC
- ) is (col_type == GenericDataType.NUMERIC)
- assert MySQLEngineSpec.is_db_column_type_match(
- type_str, GenericDataType.STRING
- ) is (col_type == GenericDataType.STRING)
- assert MySQLEngineSpec.is_db_column_type_match(
- type_str, GenericDataType.TEMPORAL
- ) is (col_type == GenericDataType.TEMPORAL)
+ for type_str, col_type in type_expectations:
+ print(">>> ", type_str)
Review comment:
assuming a leftover:
```suggestion
print(">>> ", type_str)
```
##########
File path: superset/db_engine_specs/base.py
##########
@@ -145,8 +146,87 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
_date_trunc_functions: Dict[str, str] = {}
_time_grain_expressions: Dict[Optional[str], str] = {}
column_type_mappings: Tuple[
- Tuple[Pattern[str], Union[TypeEngine, Callable[[Match[str]], TypeEngine]]], ...,
- ] = ()
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SmallInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^integer", re.IGNORECASE),
Review comment:
To make sure we match Mysql `INT` type, we could just change this to `^INT` to match both `INT` and `INTEGER`, unless there are any known incompatible types that could cause a collision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.11%`.
> The diff coverage is `63.31%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.20% -6.12%
==========================================
Files 903 823 -80
Lines 45926 41145 -4781
Branches 5624 4260 -1364
==========================================
- Hits 35508 29297 -6211
- Misses 10282 11848 +1566
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.16% <16.17%> (+0.70%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <95.04%> (-0.12%)` | :arrow_down: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [502 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (1f750da) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **increase** coverage by `3.14%`.
> The diff coverage is `69.19%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.31% 80.46% +3.14%
==========================================
Files 903 304 -599
Lines 45926 24742 -21184
Branches 5624 0 -5624
==========================================
- Hits 35508 19908 -15600
+ Misses 10282 4834 -5448
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| mysql | `80.32% <67.29%> (-0.14%)` | :arrow_down: |
| postgres | `80.37% <69.19%> (-0.13%)` | :arrow_down: |
| presto | `?` | |
| python | `80.46% <69.19%> (-0.28%)` | :arrow_down: |
| sqlite | `79.98% <67.29%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `50.00% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <87.50%> (-0.35%)` | :arrow_down: |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <92.30%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <92.30%> (-6.67%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `94.44% <100.00%> (+1.76%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (+1.49%)` | :arrow_up: |
| ... and [590 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...2fb975b](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (2f4242a) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `3.64%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 76.96% 80.61% +3.64%
==========================================
Files 930 301 -629
Lines 46278 24630 -21648
Branches 5554 0 -5554
==========================================
- Hits 35619 19856 -15763
+ Misses 10525 4774 -5751
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.61% <98.57%> (-0.28%)` | :arrow_down: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.68% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.00% <100.00%> (-0.48%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [627 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878426
@nikolagigic Hey Nikola, thanks for the PR, I understand there's no UI changes, but could you add more details and context in description? 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (83f3996) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `7.60%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 79.89% +7.60%
==========================================
Files 864 298 -566
Lines 44883 24283 -20600
Branches 5403 0 -5403
==========================================
- Hits 32450 19402 -13048
+ Misses 12224 4881 -7343
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `79.89% <50.00%> (-0.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `82.66% <27.77%> (-3.43%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [590 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...83f3996](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (dfe6185) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **decrease** coverage by `4.78%`.
> The diff coverage is `55.61%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.32% 71.54% -4.79%
==========================================
Files 906 807 -99
Lines 45739 40954 -4785
Branches 5524 4210 -1314
==========================================
- Hits 34911 29301 -5610
- Misses 10667 11653 +986
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <35.14%> (+1.43%)` | :arrow_up: |
| hive | `80.11% <94.56%> (+0.11%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.43% <92.39%> (+0.09%)` | :arrow_up: |
| postgres | `80.48% <94.56%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.87% <94.56%> (-0.01%)` | :arrow_down: |
| sqlite | `80.09% <92.39%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (+16.66%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.47% <0.00%> (-17.77%)` | :arrow_down: |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `61.53% <ø> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `33.33% <ø> (ø)` | |
| [...nd/src/components/BootstrapSliderWrapper/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci9pbmRleC5qc3g=) | `0.00% <ø> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/SearchInput/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...s/nativeFilters/FilterBar/CascadeFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJDb250cm9sLnRzeA==) | `100.00% <ø> (+14.28%)` | :arrow_up: |
| ... and [571 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...0189072](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...2f341b9](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r587790540
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +59,17 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (
+ re.compile(r"^double precision", re.IGNORECASE),
+ DOUBLE_PRECISION(),
+ GenericDataType.NUMERIC,
+ ),
+ (re.compile(r"^array.*", re.IGNORECASE), ARRAY(), utils.GenericDataType.STRING),
Review comment:
It appears `ARRAY()` needs to be instantiated with a type: https://docs.sqlalchemy.org/en/14/dialects/postgresql.html#sqlalchemy.dialects.postgresql.ARRAY I think you'll need to use a callback to match the type of the array and then pass that as `item_type` (see `VARCHAR` in Presto spec).
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -144,3 +169,15 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
engine_params["connect_args"] = connect_args
extra["engine_params"] = engine_params
return extra
+
+ def get_column_spec( # type: ignore
+ self, native_type: Optional[str],
+ ) -> Union[ColumnSpec, None]:
Review comment:
this should be a `@classmethod`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...d9afba7](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r581050786
##########
File path: superset/db_engine_specs/base.py
##########
@@ -1097,3 +1098,56 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
def is_readonly_query(cls, parsed_query: ParsedQuery) -> bool:
"""Pessimistic readonly, 100% sure statement won't mutate anything"""
return parsed_query.is_select() or parsed_query.is_explain()
+
+ @classmethod
+ def get_column_type(
+ cls,
+ source: utils.ColumnTypeSource,
+ db_type_map: Dict[utils.GenericDataType, List[str]],
+ native_type: Union[utils.GenericDataType, str],
+ ) -> Tuple[Union[utils.GenericDataType, str], bool]:
+ for generic_type in db_type_map:
+ is_dttm = generic_type == utils.GenericDataType.TEMPORAL
+ for db_type in db_type_map[generic_type]:
+ if db_type == native_type:
+ if source == utils.ColumnTypeSource.CURSOR_DESCRIPION:
+ return db_type, is_dttm
+ if source == utils.ColumnTypeSource.GET_TABLE:
+ return generic_type, is_dttm
+ return "", False
+
+ @classmethod
+ def get_column_spec(
+ cls,
+ source: utils.ColumnTypeSource,
+ column_name: str,
+ native_type: Union[utils.GenericDataType, str],
+ ) -> utils.ColumnSpec:
+ postgres_types_map: Dict[utils.GenericDataType, List[str]] = {
+ utils.GenericDataType.NUMERIC: [
+ "smallint",
+ "integer",
+ "bigint",
+ "decimal",
+ "numeric",
+ "real",
+ "double precision",
+ "smallserial",
+ "serial",
+ "bigserial",
+ ],
+ utils.GenericDataType.STRING: ["varchar", "char", "text",],
+ utils.GenericDataType.TEMPORAL: [
+ "DATE",
+ "TIME",
+ "TIMESTAMP",
+ "TIMESTAMPTZ",
+ "INTERVAL",
+ ],
+ utils.GenericDataType.BOOLEAN: ["boolean",],
+ }
Review comment:
I would break this out so that the base engine only provides a default mapping (can return `None` now), and then each engine would implement the method as they want. An example of similar logic: `convert_dttm`: `BaseEngineSpec` returns `None` (https://github.com/apache/superset/blob/99a0c8a8a129502d6253e000c14db31ab8b0bb19/superset/db_engine_specs/base.py#L533-L542), but e.g. `BigQueryEngineSpec` implements it (https://github.com/apache/superset/blob/99a0c8a8a129502d6253e000c14db31ab8b0bb19/superset/db_engine_specs/bigquery.py#L89-L100).
For matching the native type to specific types I would probably use a sequence of regexp to to find the first match. Something similar has been done on Presto t map the database type to SQLAlchemy types (this new functionality would replace the old logic): https://github.com/apache/superset/blob/99a0c8a8a129502d6253e000c14db31ab8b0bb19/superset/db_engine_specs/presto.py#L358-L384 . Some engines like Druid will also have fixed types for certain column names (e.g. `__time` is actually `TIMESTAMP` despite being returned as `STRING` on the cursor description), so these should probably be caught before doing the matching from the database type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586005878
##########
File path: superset/db_engine_specs/presto.py
##########
@@ -356,31 +356,89 @@ def _show_columns(
return columns
column_type_mappings = (
- (re.compile(r"^boolean.*", re.IGNORECASE), types.Boolean()),
- (re.compile(r"^tinyint.*", re.IGNORECASE), TinyInteger()),
- (re.compile(r"^smallint.*", re.IGNORECASE), types.SmallInteger()),
- (re.compile(r"^integer.*", re.IGNORECASE), types.Integer()),
- (re.compile(r"^bigint.*", re.IGNORECASE), types.BigInteger()),
- (re.compile(r"^real.*", re.IGNORECASE), types.Float()),
- (re.compile(r"^double.*", re.IGNORECASE), types.Float()),
- (re.compile(r"^decimal.*", re.IGNORECASE), types.DECIMAL()),
+ (
+ re.compile(r"^boolean.*", re.IGNORECASE),
+ types.Boolean(),
+ utils.GenericDataType.BOOLEAN,
+ ),
+ (
+ re.compile(r"^tinyint.*", re.IGNORECASE),
+ TinyInteger(),
+ utils.GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^smallint.*", re.IGNORECASE),
+ types.SmallInteger(),
Review comment:
Are `types.SMALLINT` and `types.SmallInteger()` interchangeable? If yes, can we stick to just one of them?
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +47,96 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
+ utils.GenericDataType.NUMERIC,
Review comment:
But, is adding `GenericDataType` here really necessary, though? I'd imagine all SQLA types could be definitively mapped to a `GenericDataType`, wouldn't they? Maybe `ColumnSpec` can just have an instance `@property` to map all known SQLA types to `GenericDataType`?
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +47,96 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
+ utils.GenericDataType.NUMERIC,
Review comment:
Nit: can we import `GenericDataType` directly and get rid of the `utils.` prefix? Just want the code the look cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (2f4242a) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **decrease** coverage by `4.97%`.
> The diff coverage is `58.55%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.32% 71.35% -4.98%
==========================================
Files 906 821 -85
Lines 45739 41055 -4684
Branches 5524 4227 -1297
==========================================
- Hits 34911 29293 -5618
- Misses 10667 11762 +1095
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <41.59%> (+1.38%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.47% <91.77%> (+0.13%)` | :arrow_up: |
| postgres | `80.53% <93.50%> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <93.50%> (-0.27%)` | :arrow_down: |
| sqlite | `80.13% <90.47%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (+16.66%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.47% <0.00%> (-17.77%)` | :arrow_down: |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `61.53% <ø> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `33.33% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
| [...rontend/src/components/AsyncEsmComponent/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQvaW5kZXgudHN4) | `94.11% <ø> (ø)` | |
| [...nd/src/components/BootstrapSliderWrapper/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci9pbmRleC5qc3g=) | `0.00% <ø> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <ø> (ø)` | |
| ... and [626 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...bfdc994](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.92%`.
> The diff coverage is `63.90%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.38% -5.93%
==========================================
Files 903 823 -80
Lines 45926 41145 -4781
Branches 5624 4260 -1364
==========================================
- Hits 35508 29372 -6136
- Misses 10282 11773 +1491
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.16% <16.17%> (+0.70%)` | :arrow_up: |
| hive | `80.16% <96.03%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.91% <96.03%> (+0.18%)` | :arrow_up: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [502 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (dfe6185) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **increase** coverage by `4.24%`.
> The diff coverage is `94.56%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 76.32% 80.57% +4.24%
==========================================
Files 906 301 -605
Lines 45739 24605 -21134
Branches 5524 0 -5524
==========================================
- Hits 34911 19825 -15086
+ Misses 10667 4780 -5887
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.43% <92.39%> (+0.09%)` | :arrow_up: |
| postgres | `80.48% <94.56%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.57% <94.56%> (-0.31%)` | :arrow_down: |
| sqlite | `80.09% <92.39%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.68% <ø> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.10% <10.00%> (+0.09%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.51% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.12% <100.00%> (+0.57%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `95.57% <100.00%> (+0.33%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.13% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.68% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.00% <100.00%> (-6.03%)` | :arrow_down: |
| ... and [566 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...0189072](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586272123
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +47,96 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
+ utils.GenericDataType.NUMERIC,
Review comment:
@ktmud Yes, it could've been mapped as you proposed. The reason behind the current way is that if we get multiple matches we can prioritise those at the start of the list without necessarily sorting the results for the most part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (0cb390e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `3.95%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 76.96% 80.91% +3.95%
==========================================
Files 930 301 -629
Lines 46278 24630 -21648
Branches 5554 0 -5554
==========================================
- Hits 35619 19930 -15689
+ Misses 10525 4700 -5825
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `80.14% <98.57%> (+0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.91% <98.57%> (+0.02%)` | :arrow_up: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.15% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (+0.36%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlQcmV2aWV3TW9kYWwudHN4) | | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | | |
| ... and [627 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **increase** coverage by `3.29%`.
> The diff coverage is `97.22%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.31% 80.61% +3.29%
==========================================
Files 903 301 -602
Lines 45926 24625 -21301
Branches 5624 0 -5624
==========================================
- Hits 35508 19851 -15657
+ Misses 10282 4774 -5508
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <97.22%> (-0.12%)` | :arrow_down: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <92.30%> (-6.67%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.68% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `94.44% <100.00%> (+1.76%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [594 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...7e0d4d1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586404100
##########
File path: superset/db_engine_specs/presto.py
##########
@@ -356,31 +356,89 @@ def _show_columns(
return columns
column_type_mappings = (
- (re.compile(r"^boolean.*", re.IGNORECASE), types.Boolean()),
- (re.compile(r"^tinyint.*", re.IGNORECASE), TinyInteger()),
- (re.compile(r"^smallint.*", re.IGNORECASE), types.SmallInteger()),
- (re.compile(r"^integer.*", re.IGNORECASE), types.Integer()),
- (re.compile(r"^bigint.*", re.IGNORECASE), types.BigInteger()),
- (re.compile(r"^real.*", re.IGNORECASE), types.Float()),
- (re.compile(r"^double.*", re.IGNORECASE), types.Float()),
- (re.compile(r"^decimal.*", re.IGNORECASE), types.DECIMAL()),
+ (
+ re.compile(r"^boolean.*", re.IGNORECASE),
+ types.Boolean(),
+ utils.GenericDataType.BOOLEAN,
+ ),
+ (
+ re.compile(r"^tinyint.*", re.IGNORECASE),
+ TinyInteger(),
+ utils.GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^smallint.*", re.IGNORECASE),
+ types.SmallInteger(),
Review comment:
Changed it to keep it consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (dfe6185) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **decrease** coverage by `4.78%`.
> The diff coverage is `55.61%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.32% 71.54% -4.79%
==========================================
Files 906 807 -99
Lines 45739 40954 -4785
Branches 5524 4210 -1314
==========================================
- Hits 34911 29301 -5610
- Misses 10667 11653 +986
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <35.14%> (+1.43%)` | :arrow_up: |
| hive | `80.11% <94.56%> (+0.11%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.43% <92.39%> (+0.09%)` | :arrow_up: |
| postgres | `80.48% <94.56%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.87% <94.56%> (-0.01%)` | :arrow_down: |
| sqlite | `80.09% <92.39%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (+16.66%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.47% <0.00%> (-17.77%)` | :arrow_down: |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `61.53% <ø> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `33.33% <ø> (ø)` | |
| [...nd/src/components/BootstrapSliderWrapper/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci9pbmRleC5qc3g=) | `0.00% <ø> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/SearchInput/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...s/nativeFilters/FilterBar/CascadeFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJDb250cm9sLnRzeA==) | `100.00% <ø> (+14.28%)` | :arrow_up: |
| ... and [571 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...0189072](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (8e330db) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `7.60%`.
> The diff coverage is `51.85%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 79.89% +7.60%
==========================================
Files 864 298 -566
Lines 44883 24283 -20600
Branches 5403 0 -5403
==========================================
- Hits 32450 19402 -13048
+ Misses 12224 4881 -7343
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `79.89% <51.85%> (-0.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `82.66% <27.77%> (-3.43%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [590 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...8e330db](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586061966
##########
File path: superset/db_engine_specs/base.py
##########
@@ -967,25 +973,27 @@ def make_label_compatible(cls, label: str) -> Union[str, quoted_name]:
return label_mutated
@classmethod
- def get_sqla_column_type(cls, type_: Optional[str]) -> Optional[TypeEngine]:
+ def get_sqla_column_type(
+ cls, column_type: Optional[str]
+ ) -> Tuple[Union[TypeEngine, utils.GenericDataType, None]]:
"""
Return a sqlalchemy native column type that corresponds to the column type
defined in the data source (return None to use default type inferred by
SQLAlchemy). Override `column_type_mappings` for specific needs
(see MSSQL for example of NCHAR/NVARCHAR handling).
- :param type_: Column type returned by inspector
+ :param column_type: Column type returned by inspector
:return: SqlAlchemy column type
"""
- if not type_:
- return None
- for regex, sqla_type in cls.column_type_mappings:
- match = regex.match(type_)
+ if not column_type:
+ return None, None
+ for regex, sqla_type, generic_type in cls.column_type_mappings:
+ match = regex.match(column_type)
if match:
if callable(sqla_type):
- return sqla_type(match)
- return sqla_type
- return None
+ return sqla_type(match), generic_type
Review comment:
some SQLAlchemy `Type Visitor` no argument, so we can not use type call the matched type. You can try postgresql `Date` datatype
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (0cb390e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `5.44%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.96% 71.52% -5.45%
==========================================
Files 930 821 -109
Lines 46278 41058 -5220
Branches 5554 4226 -1328
==========================================
- Hits 35619 29367 -6252
- Misses 10525 11691 +1166
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.44% <ø> (ø)` | |
| hive | `80.16% <98.57%> (+0.03%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.91% <98.57%> (+0.02%)` | :arrow_up: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.15% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (+0.36%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878426
@nikolagigic Hey Nikola, thanks for the PR, I understand there's no UI changes involved, but could you add more details and context in description? 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (8e330db) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `0.60%`.
> The diff coverage is `51.85%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 72.29% 71.69% -0.61%
==========================================
Files 864 776 -88
Lines 44883 40311 -4572
Branches 5403 4129 -1274
==========================================
- Hits 32450 28900 -3550
+ Misses 12224 11411 -813
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.51% <ø> (?)` | |
| javascript | `?` | |
| python | `80.36% <51.85%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [491 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...8e330db](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (83f3996) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `0.60%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 72.29% 71.69% -0.61%
==========================================
Files 864 776 -88
Lines 44883 40311 -4572
Branches 5403 4129 -1274
==========================================
- Hits 32450 28900 -3550
+ Misses 12224 11411 -813
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.51% <ø> (?)` | |
| javascript | `?` | |
| python | `80.36% <50.00%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [491 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...83f3996](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (2f4242a) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `5.61%`.
> The diff coverage is `98.71%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.96% 71.35% -5.62%
==========================================
Files 930 821 -109
Lines 46278 41055 -5223
Branches 5554 4227 -1327
==========================================
- Hits 35619 29293 -6326
- Misses 10525 11762 +1237
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <100.00%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.61% <98.57%> (-0.28%)` | :arrow_down: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
| [...rontend/src/components/AsyncEsmComponent/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQvaW5kZXgudHN4) | `94.11% <ø> (ø)` | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `52.40% <ø> (+1.23%)` | :arrow_up: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [...t-frontend/src/components/PopoverSection/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.68% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.00% <100.00%> (-0.48%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (8e330db) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `8.06%`.
> The diff coverage is `51.85%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 80.36% +8.06%
==========================================
Files 864 298 -566
Lines 44883 24311 -20572
Branches 5403 0 -5403
==========================================
- Hits 32450 19538 -12912
+ Misses 12224 4773 -7451
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `80.36% <51.85%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.32% <0.00%> (-0.16%)` | :arrow_down: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | | |
| ... and [567 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...8e330db](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `8.46%`.
> The diff coverage is `87.05%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 80.76% +8.46%
==========================================
Files 864 300 -564
Lines 44883 24406 -20477
Branches 5403 0 -5403
==========================================
- Hits 32450 19711 -12739
+ Misses 12224 4695 -7529
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `80.76% <87.05%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `76.77% <ø> (-1.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.28% <0.00%> (-0.20%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <61.11%> (-1.27%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.33% <75.00%> (-0.04%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.28% <87.50%> (-0.30%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.09% <90.90%> (-0.01%)` | :arrow_down: |
| ... and [562 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...488a840](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (8e330db) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `0.76%`.
> The diff coverage is `51.85%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 72.29% 71.53% -0.77%
==========================================
Files 864 776 -88
Lines 44883 40311 -4572
Branches 5403 4129 -1274
==========================================
- Hits 32450 28836 -3614
+ Misses 12224 11475 -749
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.11% <ø> (?)` | |
| javascript | `?` | |
| python | `80.36% <51.85%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [491 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...8e330db](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...ddcc14a](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (0cb390e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `5.44%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.96% 71.52% -5.45%
==========================================
Files 930 821 -109
Lines 46278 41058 -5220
Branches 5554 4226 -1328
==========================================
- Hits 35619 29367 -6252
- Misses 10525 11691 +1166
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.44% <ø> (ø)` | |
| hive | `80.16% <98.57%> (+0.03%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.91% <98.57%> (+0.02%)` | :arrow_up: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.15% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (+0.36%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586694615
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +47,96 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
+ utils.GenericDataType.NUMERIC,
Review comment:
I understand the need to use a list to have priority for RegExp matching, but will there be a case where two SQLA types may be matched to different `GenericDataType`? If not, isn't `GenericDataType` already inferred by SQLA `types`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (71a6671) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.07%`.
> The diff coverage is `66.05%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.24% -6.08%
==========================================
Files 903 826 -77
Lines 45926 41326 -4600
Branches 5624 4265 -1359
==========================================
- Hits 35508 29442 -6066
- Misses 10282 11884 +1602
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <37.50%> (+0.64%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.37% <75.00%> (-0.09%)` | :arrow_down: |
| postgres | `80.42% <76.44%> (-0.08%)` | :arrow_down: |
| presto | `80.10% <76.81%> (-0.07%)` | :arrow_down: |
| python | `80.66% <76.81%> (-0.08%)` | :arrow_down: |
| sqlite | `80.03% <75.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| ... and [514 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (1f750da) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `8.54%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 68.77% -8.55%
==========================================
Files 903 823 -80
Lines 45926 41206 -4720
Branches 5624 4241 -1383
==========================================
- Hits 35508 28339 -7169
- Misses 10282 12867 +2585
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.20% <32.69%> (-5.25%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.32% <67.29%> (-0.14%)` | :arrow_down: |
| postgres | `80.37% <69.19%> (-0.13%)` | :arrow_down: |
| presto | `?` | |
| python | `80.46% <69.19%> (-0.28%)` | :arrow_down: |
| sqlite | `79.98% <67.29%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `81.81% <ø> (-18.19%)` | :arrow_down: |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `28.12% <0.00%> (-39.45%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `6.25% <0.00%> (-58.97%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.84%`.
> The diff coverage is `63.90%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.46% -5.85%
==========================================
Files 903 823 -80
Lines 45926 41145 -4781
Branches 5624 4260 -1364
==========================================
- Hits 35508 29406 -6102
- Misses 10282 11739 +1457
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.20% <16.17%> (+0.75%)` | :arrow_up: |
| hive | `80.16% <96.03%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `80.19% <96.03%> (+0.02%)` | :arrow_up: |
| python | `81.02% <96.03%> (+0.29%)` | :arrow_up: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [500 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r587437139
##########
File path: superset/db_engine_specs/base.py
##########
@@ -145,8 +146,80 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
_date_trunc_functions: Dict[str, str] = {}
_time_grain_expressions: Dict[Optional[str], str] = {}
column_type_mappings: Tuple[
- Tuple[Pattern[str], Union[TypeEngine, Callable[[Match[str]], TypeEngine]]], ...,
- ] = ()
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
Review comment:
These should be instantiated: `types.SMALLINT()` instead of `types.SMALLINT`, otherwise the callback logic later on wont work where we check if the type is `callable` (see how Presto implements `VARCHAR`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (8e330db) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `8.00%`.
> The diff coverage is `51.85%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 80.30% +8.00%
==========================================
Files 864 298 -566
Lines 44883 24283 -20600
Branches 5403 0 -5403
==========================================
- Hits 32450 19500 -12950
+ Misses 12224 4783 -7441
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `80.30% <51.85%> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.62% <0.00%> (-2.21%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.16%)` | :arrow_down: |
| ... and [576 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...8e330db](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **increase** coverage by `4.43%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 76.32% 80.76% +4.43%
==========================================
Files 906 300 -606
Lines 45739 24406 -21333
Branches 5524 0 -5524
==========================================
- Hits 34911 19711 -15200
+ Misses 10667 4695 -5972
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.12%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/redirects.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | `70.00% <0.00%> (-18.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [...perset/dashboards/commands/importers/dispatcher.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvZGlzcGF0Y2hlci5weQ==) | `80.64% <0.00%> (-3.23%)` | :arrow_down: |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <0.00%> (-2.24%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| ... and [632 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...8c7cce9](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586061966
##########
File path: superset/db_engine_specs/base.py
##########
@@ -967,25 +973,27 @@ def make_label_compatible(cls, label: str) -> Union[str, quoted_name]:
return label_mutated
@classmethod
- def get_sqla_column_type(cls, type_: Optional[str]) -> Optional[TypeEngine]:
+ def get_sqla_column_type(
+ cls, column_type: Optional[str]
+ ) -> Tuple[Union[TypeEngine, utils.GenericDataType, None]]:
"""
Return a sqlalchemy native column type that corresponds to the column type
defined in the data source (return None to use default type inferred by
SQLAlchemy). Override `column_type_mappings` for specific needs
(see MSSQL for example of NCHAR/NVARCHAR handling).
- :param type_: Column type returned by inspector
+ :param column_type: Column type returned by inspector
:return: SqlAlchemy column type
"""
- if not type_:
- return None
- for regex, sqla_type in cls.column_type_mappings:
- match = regex.match(type_)
+ if not column_type:
+ return None, None
+ for regex, sqla_type, generic_type in cls.column_type_mappings:
+ match = regex.match(column_type)
if match:
if callable(sqla_type):
- return sqla_type(match)
- return sqla_type
- return None
+ return sqla_type(match), generic_type
Review comment:
some SQLAlchemy `Type Visitor` no argument, so we can not use type call the matched type. You can try postgresql `Date` datetype
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (dfe6185) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **decrease** coverage by `4.78%`.
> The diff coverage is `55.61%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.32% 71.54% -4.79%
==========================================
Files 906 807 -99
Lines 45739 40954 -4785
Branches 5524 4210 -1314
==========================================
- Hits 34911 29301 -5610
- Misses 10667 11653 +986
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <35.14%> (+1.43%)` | :arrow_up: |
| hive | `80.09% <94.56%> (+0.09%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.43% <92.39%> (+0.09%)` | :arrow_up: |
| postgres | `80.48% <94.56%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.87% <94.56%> (-0.01%)` | :arrow_down: |
| sqlite | `80.09% <92.39%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (+16.66%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.47% <0.00%> (-17.77%)` | :arrow_down: |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `61.53% <ø> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `33.33% <ø> (ø)` | |
| [...nd/src/components/BootstrapSliderWrapper/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci9pbmRleC5qc3g=) | `0.00% <ø> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/SearchInput/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...s/nativeFilters/FilterBar/CascadeFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJDb250cm9sLnRzeA==) | `100.00% <ø> (+14.28%)` | :arrow_up: |
| ... and [571 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...0189072](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (1f750da) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.20%`.
> The diff coverage is `58.73%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.10% -6.21%
==========================================
Files 903 826 -77
Lines 45926 41261 -4665
Branches 5624 4265 -1359
==========================================
- Hits 35508 29339 -6169
- Misses 10282 11922 +1640
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <37.50%> (+0.63%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.32% <67.29%> (-0.14%)` | :arrow_down: |
| postgres | `80.37% <69.19%> (-0.13%)` | :arrow_down: |
| presto | `?` | |
| python | `80.46% <69.19%> (-0.28%)` | :arrow_down: |
| sqlite | `79.98% <67.29%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| ... and [514 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r583015764
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (re.compile(r"^smallint", re.IGNORECASE), types.SMALLINT),
+ (re.compile(r"^integer", re.IGNORECASE), types.INTEGER),
+ (re.compile(r"^bigint", re.IGNORECASE), types.BIGINT),
+ (re.compile(r"^decimal", re.IGNORECASE), types.DECIMAL),
+ (re.compile(r"^numeric", re.IGNORECASE), types.NUMERIC),
+ (re.compile(r"^real", re.IGNORECASE), types.REAL),
+ (re.compile(r"^double precision", re.IGNORECASE), DOUBLE_PRECISION),
+ (re.compile(r"^smallserial", re.IGNORECASE), types.SMALLINT),
+ (re.compile(r"^serial", re.IGNORECASE), types.INTEGER),
+ (re.compile(r"^bigserial", re.IGNORECASE), types.BIGINT),
+ (re.compile(r"^varchar", re.IGNORECASE), types.VARCHAR),
+ (re.compile(r"^char", re.IGNORECASE), types.CHAR),
+ (re.compile(r"^text", re.IGNORECASE), types.TEXT),
+ (re.compile(r"^date", re.IGNORECASE), types.DATE),
+ (re.compile(r"^time", re.IGNORECASE), types.TIME),
+ (re.compile(r"^timestamp", re.IGNORECASE), types.TIMESTAMP),
+ (re.compile(r"^timestamptz", re.IGNORECASE), types.TIMESTAMP(timezone=True)),
Review comment:
Were you able to get these from `inspector.get_columns()` or `cursor.description`? When I check a table with timestamps it seems to return the unabbreviated format `TIMESTAMP WITHOUT TIME ZONE`, not `TIMESTAMP`:
I'm assuming the abbreviations are usually relevant when creating tables, not fetching table metadata, but I may be wrong (this may have changed over the versions/years):
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (re.compile(r"^smallint", re.IGNORECASE), types.SMALLINT),
+ (re.compile(r"^integer", re.IGNORECASE), types.INTEGER),
+ (re.compile(r"^bigint", re.IGNORECASE), types.BIGINT),
+ (re.compile(r"^decimal", re.IGNORECASE), types.DECIMAL),
+ (re.compile(r"^numeric", re.IGNORECASE), types.NUMERIC),
+ (re.compile(r"^real", re.IGNORECASE), types.REAL),
+ (re.compile(r"^double precision", re.IGNORECASE), DOUBLE_PRECISION),
+ (re.compile(r"^smallserial", re.IGNORECASE), types.SMALLINT),
+ (re.compile(r"^serial", re.IGNORECASE), types.INTEGER),
+ (re.compile(r"^bigserial", re.IGNORECASE), types.BIGINT),
+ (re.compile(r"^varchar", re.IGNORECASE), types.VARCHAR),
+ (re.compile(r"^char", re.IGNORECASE), types.CHAR),
+ (re.compile(r"^text", re.IGNORECASE), types.TEXT),
+ (re.compile(r"^date", re.IGNORECASE), types.DATE),
+ (re.compile(r"^time", re.IGNORECASE), types.TIME),
+ (re.compile(r"^timestamp", re.IGNORECASE), types.TIMESTAMP),
+ (re.compile(r"^timestamptz", re.IGNORECASE), types.TIMESTAMP(timezone=True)),
+ (re.compile(r"^interval", re.IGNORECASE), types.Interval),
+ (re.compile(r"^boolean", re.IGNORECASE), types.BOOLEAN),
+ )
Review comment:
We should add at least `DbColumnType` in this mapping, too (should be added to `ColumnSpec`), as we want to pass that when returning chart query data to the frontend. This will make `is_dttm` redundant, as that info is already covered by `DbColumnType.TEMPORAL`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...4b8d0ec](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (1f750da) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.20%`.
> The diff coverage is `58.73%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.10% -6.21%
==========================================
Files 903 826 -77
Lines 45926 41261 -4665
Branches 5624 4265 -1359
==========================================
- Hits 35508 29339 -6169
- Misses 10282 11922 +1640
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <37.50%> (+0.63%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.32% <67.29%> (-0.14%)` | :arrow_down: |
| postgres | `80.37% <69.19%> (-0.13%)` | :arrow_down: |
| presto | `?` | |
| python | `80.46% <69.19%> (-0.28%)` | :arrow_down: |
| sqlite | `79.98% <67.29%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| ... and [514 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `9.01%`.
> The diff coverage is `63.31%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 68.30% -9.02%
==========================================
Files 903 820 -83
Lines 45926 41090 -4836
Branches 5624 4236 -1388
==========================================
- Hits 35508 28065 -7443
- Misses 10282 13025 +2743
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.86% <16.17%> (-6.59%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <95.04%> (-0.12%)` | :arrow_down: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `94.80% <ø> (-5.20%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `28.12% <0.00%> (-39.45%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r590459217
##########
File path: tests/sqla_models_tests.py
##########
@@ -79,16 +79,16 @@ def test_db_column_types(self):
# string
"CHAR": GenericDataType.STRING,
"VARCHAR": GenericDataType.STRING,
- "NVARCHAR": GenericDataType.STRING,
- "STRING": GenericDataType.STRING,
+ # "NVARCHAR": GenericDataType.STRING, # MSSQL types; commeented out for now and will address in another PR
+ # "STRING": GenericDataType.STRING,
Review comment:
Were these causing problems in tests? This test might need some refactoring, as it will potentially give different results on different engines. We could potentially simplify this a bit by only checking types that are common for all databases supported by CI, and later potentially adding a few db specific tests.
##########
File path: superset/db_engine_specs/base.py
##########
@@ -967,24 +1040,35 @@ def make_label_compatible(cls, label: str) -> Union[str, quoted_name]:
return label_mutated
@classmethod
- def get_sqla_column_type(cls, type_: Optional[str]) -> Optional[TypeEngine]:
+ def get_sqla_column_type(
+ cls,
+ column_type: Optional[str],
+ column_type_mappings: Tuple[
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = column_type_mappings,
Review comment:
Instead of passing the mapping to the method, we can probably just call the `cls.column_type_mappings` property in the method call.
##########
File path: superset/db_engine_specs/mssql.py
##########
@@ -78,8 +78,16 @@ def fetch_data(
return cls.pyodbc_rows_to_tuples(data)
column_type_mappings = (
- (re.compile(r"^N((VAR)?CHAR|TEXT)", re.IGNORECASE), UnicodeText()),
- (re.compile(r"^((VAR)?CHAR|TEXT|STRING)", re.IGNORECASE), String()),
+ (
+ re.compile(r"^N((VAR)?CHAR|TEXT)", re.IGNORECASE),
+ UnicodeText(),
+ utils.GenericDataType.STRING,
+ ),
+ (
+ re.compile(r"^((VAR)?CHAR|TEXT|STRING)", re.IGNORECASE),
+ String(),
+ utils.GenericDataType.STRING,
+ ),
Review comment:
I would probably design this so that an engine spec can extend the base mapping. In the case of MSSQL, I believe the base mapping is a good fallback. Also, we might consider incorporating these types into the base spec, as I assume fairly many engines support N-prefixed character types, and some of those engines might also benefit from the `UnicodeText` SQLA type over the regular `String` one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.10%`.
> The diff coverage is `57.24%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.21% -6.11%
==========================================
Files 903 823 -80
Lines 45926 41141 -4785
Branches 5624 4262 -1362
==========================================
- Hits 35508 29298 -6210
- Misses 10282 11843 +1561
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.19% <13.63%> (+0.74%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <97.22%> (-0.12%)` | :arrow_down: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `16.66% <16.66%> (-16.67%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `90.42% <20.00%> (-3.27%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `30.00% <33.33%> (-26.25%)` | :arrow_down: |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...7e0d4d1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r582605459
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
Review comment:
Yes - this is the ultimate objective. However, we want to leave the existing structures untouched until we're certain this doesn't break existing functionality. We'll be including other types in this mapping that are missing in `db_column_types`, like `DbColumnType`, PyArrow types etc to make sure this is a one-stop-shop for making available all necessary types in one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (0cb390e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `3.64%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 76.96% 80.61% +3.64%
==========================================
Files 930 301 -629
Lines 46278 24630 -21648
Branches 5554 0 -5554
==========================================
- Hits 35619 19856 -15763
+ Misses 10525 4774 -5751
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.61% <98.57%> (-0.28%)` | :arrow_down: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.68% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.00% <100.00%> (-0.48%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [631 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...1050974](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **increase** coverage by `3.29%`.
> The diff coverage is `95.04%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.31% 80.61% +3.29%
==========================================
Files 903 301 -602
Lines 45926 24633 -21293
Branches 5624 0 -5624
==========================================
- Hits 35508 19858 -15650
+ Misses 10282 4775 -5507
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.61% <95.04%> (-0.12%)` | :arrow_down: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <87.50%> (-0.35%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <92.30%> (-6.67%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `94.44% <100.00%> (+1.76%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (+1.49%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| ... and [591 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...1e06266](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r592204273
##########
File path: superset/db_engine_specs/base.py
##########
@@ -162,21 +242,17 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
# default matching patterns to convert database specific column types to
# more generic types
- db_column_types: Dict[utils.GenericDataType, Tuple[Pattern[str], ...]] = {
- utils.GenericDataType.NUMERIC: (
+ db_column_types: Dict[GenericDataType, Tuple[Pattern[str], ...]] = {
+ GenericDataType.NUMERIC: (
Review comment:
Do we need this map anymore? I believe this can be achieved with `get_column_spec`
##########
File path: superset/db_engine_specs/base.py
##########
@@ -210,7 +286,7 @@ def get_dbapi_mapped_exception(cls, exception: Exception) -> Exception:
@classmethod
def is_db_column_type_match(
- cls, db_column_type: Optional[str], target_column_type: utils.GenericDataType
+ cls, db_column_type: Optional[str], target_column_type: GenericDataType
Review comment:
I believe we can remove this method, as I don't see it being used anymore
##########
File path: tests/db_engine_specs/mssql_tests.py
##########
@@ -24,49 +24,55 @@
from superset.db_engine_specs.base import BaseEngineSpec
from superset.db_engine_specs.mssql import MssqlEngineSpec
+from superset.utils.core import GenericDataType
from tests.db_engine_specs.base_tests import TestDbEngineSpec
class TestMssqlEngineSpec(TestDbEngineSpec):
def test_mssql_column_types(self):
- def assert_type(type_string, type_expected):
- type_assigned = MssqlEngineSpec.get_sqla_column_type(type_string)
+ def assert_type(type_string, type_expected, generic_type_expected):
if type_expected is None:
+ type_assigned = MssqlEngineSpec.get_sqla_column_type(type_string)
self.assertIsNone(type_assigned)
else:
- self.assertIsInstance(type_assigned, type_expected)
+ column_spec = MssqlEngineSpec.get_sqla_column_type(type_string)
+ if not column_spec is None:
+ (type_assigned, generic_type_assigned,) = column_spec
+ self.assertIsInstance(type_assigned, type_expected)
+ self.assertIsInstance(generic_type_assigned, generic_type_expected)
- assert_type("INT", None)
- assert_type("STRING", String)
- assert_type("CHAR(10)", String)
- assert_type("VARCHAR(10)", String)
- assert_type("TEXT", String)
- assert_type("NCHAR(10)", UnicodeText)
- assert_type("NVARCHAR(10)", UnicodeText)
- assert_type("NTEXT", UnicodeText)
+ # assert_type("STRING", String, GenericDataType.STRING)
+ # assert_type("CHAR(10)", String, GenericDataType.STRING)
+ # assert_type("VARCHAR(10)", String, GenericDataType.STRING)
+ # assert_type("TEXT", String, GenericDataType.STRING)
+ # assert_type("NCHAR(10)", UnicodeText, GenericDataType.STRING)
+ # assert_type("NVARCHAR(10)", UnicodeText, GenericDataType.STRING)
+ # assert_type("NTEXT", UnicodeText, GenericDataType.STRING)
Review comment:
Why are these removed? couldn't we assert this using `get_column_spec`?
##########
File path: tests/db_engine_specs/mssql_tests.py
##########
@@ -24,49 +24,55 @@
from superset.db_engine_specs.base import BaseEngineSpec
from superset.db_engine_specs.mssql import MssqlEngineSpec
+from superset.utils.core import GenericDataType
from tests.db_engine_specs.base_tests import TestDbEngineSpec
class TestMssqlEngineSpec(TestDbEngineSpec):
def test_mssql_column_types(self):
- def assert_type(type_string, type_expected):
- type_assigned = MssqlEngineSpec.get_sqla_column_type(type_string)
+ def assert_type(type_string, type_expected, generic_type_expected):
if type_expected is None:
+ type_assigned = MssqlEngineSpec.get_sqla_column_type(type_string)
self.assertIsNone(type_assigned)
else:
- self.assertIsInstance(type_assigned, type_expected)
+ column_spec = MssqlEngineSpec.get_sqla_column_type(type_string)
+ if not column_spec is None:
+ (type_assigned, generic_type_assigned,) = column_spec
+ self.assertIsInstance(type_assigned, type_expected)
+ self.assertIsInstance(generic_type_assigned, generic_type_expected)
- assert_type("INT", None)
- assert_type("STRING", String)
- assert_type("CHAR(10)", String)
- assert_type("VARCHAR(10)", String)
- assert_type("TEXT", String)
- assert_type("NCHAR(10)", UnicodeText)
- assert_type("NVARCHAR(10)", UnicodeText)
- assert_type("NTEXT", UnicodeText)
+ # assert_type("STRING", String, GenericDataType.STRING)
+ # assert_type("CHAR(10)", String, GenericDataType.STRING)
+ # assert_type("VARCHAR(10)", String, GenericDataType.STRING)
+ # assert_type("TEXT", String, GenericDataType.STRING)
+ # assert_type("NCHAR(10)", UnicodeText, GenericDataType.STRING)
+ # assert_type("NVARCHAR(10)", UnicodeText, GenericDataType.STRING)
+ # assert_type("NTEXT", UnicodeText, GenericDataType.STRING)
- def test_where_clause_n_prefix(self):
- dialect = mssql.dialect()
- spec = MssqlEngineSpec
- str_col = column("col", type_=spec.get_sqla_column_type("VARCHAR(10)"))
- unicode_col = column("unicode_col", type_=spec.get_sqla_column_type("NTEXT"))
- tbl = table("tbl")
- sel = (
- select([str_col, unicode_col])
- .select_from(tbl)
- .where(str_col == "abc")
- .where(unicode_col == "abc")
- )
+ # def test_where_clause_n_prefix(self):
+ # dialect = mssql.dialect()
+ # spec = MssqlEngineSpec
+ # type_, _ = spec.get_sqla_column_type("VARCHAR(10)")
+ # str_col = column("col", type_=type_)
+ # type_, _ = spec.get_sqla_column_type("NTEXT")
+ # unicode_col = column("unicode_col", type_=type_)
+ # tbl = table("tbl")
+ # sel = (
+ # select([str_col, unicode_col])
+ # .select_from(tbl)
+ # .where(str_col == "abc")
+ # .where(unicode_col == "abc")
+ # )
- query = str(
- sel.compile(dialect=dialect, compile_kwargs={"literal_binds": True})
- )
- query_expected = (
- "SELECT col, unicode_col \n"
- "FROM tbl \n"
- "WHERE col = 'abc' AND unicode_col = N'abc'"
- )
- self.assertEqual(query, query_expected)
+ # query = str(
+ # sel.compile(dialect=dialect, compile_kwargs={"literal_binds": True})
+ # )
+ # query_expected = (
+ # "SELECT col, unicode_col \n"
+ # "FROM tbl \n"
+ # "WHERE col = 'abc' AND unicode_col = N'abc'"
+ # )
+ # self.assertEqual(query, query_expected)
Review comment:
This is an important test - if it doesn't work we need to make sure it does
##########
File path: superset/db_engine_specs/base.py
##########
@@ -145,8 +146,87 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
_date_trunc_functions: Dict[str, str] = {}
_time_grain_expressions: Dict[Optional[str], str] = {}
column_type_mappings: Tuple[
- Tuple[Pattern[str], Union[TypeEngine, Callable[[Match[str]], TypeEngine]]], ...,
- ] = ()
+ Tuple[
+ Pattern[str],
+ Union[TypeEngine, Callable[[Match[str]], TypeEngine]],
+ GenericDataType,
+ ],
+ ...,
+ ] = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SmallInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^integer", re.IGNORECASE),
+ types.Integer(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^bigint", re.IGNORECASE),
+ types.BigInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^decimal", re.IGNORECASE),
+ types.Numeric(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^numeric", re.IGNORECASE),
+ types.Numeric(),
+ GenericDataType.NUMERIC,
+ ),
+ (re.compile(r"^real", re.IGNORECASE), types.REAL, GenericDataType.NUMERIC,),
+ (
+ re.compile(r"^smallserial", re.IGNORECASE),
+ types.SmallInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^serial", re.IGNORECASE),
+ types.Integer(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^bigserial", re.IGNORECASE),
+ types.BigInteger(),
+ GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^N((VAR)?CHAR|TEXT)", re.IGNORECASE),
+ UnicodeText(),
+ utils.GenericDataType.STRING,
+ ),
+ (
+ re.compile(r"^((VAR)?CHAR|TEXT|STRING)", re.IGNORECASE),
+ String(),
+ utils.GenericDataType.STRING,
+ ),
+ (re.compile(r"^date", re.IGNORECASE), types.Date(), GenericDataType.TEMPORAL,),
+ (
+ re.compile(r"^timestamp", re.IGNORECASE),
+ types.TIMESTAMP(),
+ GenericDataType.TEMPORAL,
+ ),
+ (
+ re.compile(r"^timestamptz", re.IGNORECASE),
+ types.TIMESTAMP(timezone=True),
+ GenericDataType.TEMPORAL,
+ ),
Review comment:
`^timestamptz` would never be caught as it's already matching `^timestamp` above. I suggest removing `timestamptz` support for now (timezones aren't really properly supported yet).
##########
File path: tests/databases/commands_tests.py
##########
@@ -259,7 +259,8 @@ def test_export_database_command(self, mock_g):
"version": "1.0.0",
}
expected_metadata["columns"].sort(key=lambda x: x["column_name"])
- assert metadata == expected_metadata
+ self.maxDiff = None
+ self.assertEquals(metadata, expected_metadata)
Review comment:
Let's not change this
```suggestion
assert metadata == expected_metadata
```
##########
File path: tests/db_engine_specs/mssql_tests.py
##########
@@ -134,9 +140,9 @@ def test_column_datatype_to_string(self):
(DATE(), "DATE"),
(VARCHAR(length=255), "VARCHAR(255)"),
(VARCHAR(length=255, collation="utf8_general_ci"), "VARCHAR(255)"),
- (NVARCHAR(length=128), "NVARCHAR(128)"),
+ # (NVARCHAR(length=128), "NVARCHAR(128)"),
(TEXT(), "TEXT"),
- (NTEXT(collation="utf8_general_ci"), "NTEXT"),
+ # (NTEXT(collation="utf8_general_ci"), "NTEXT"),
Review comment:
This functionality+test can be removed later, but I believe we need to make a db migration to resize the type column in the metadata (not sure if it was already).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (2f4242a) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `6.95%`.
> The diff coverage is `98.71%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.96% 70.01% -6.96%
==========================================
Files 930 820 -110
Lines 46278 40944 -5334
Branches 5554 4196 -1358
==========================================
- Hits 35619 28665 -6954
- Misses 10525 12279 +1754
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.99% <100.00%> (-3.45%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.61% <98.57%> (-0.28%)` | :arrow_down: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
| [...rontend/src/components/AsyncEsmComponent/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQvaW5kZXgudHN4) | `76.47% <ø> (ø)` | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `52.40% <ø> (+1.23%)` | :arrow_up: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [...t-frontend/src/components/PopoverSection/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.68% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.00% <100.00%> (-0.48%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| ... and [529 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r584719970
##########
File path: superset/db_engine_specs/base.py
##########
@@ -967,25 +980,27 @@ def make_label_compatible(cls, label: str) -> Union[str, quoted_name]:
return label_mutated
@classmethod
- def get_sqla_column_type(cls, type_: Optional[str]) -> Optional[TypeEngine]:
+ def get_sqla_column_type(
+ cls, column_type: Optional[str]
+ ) -> Tuple[Union[TypeEngine, utils.GenericDataType, None]]:
"""
Return a sqlalchemy native column type that corresponds to the column type
defined in the data source (return None to use default type inferred by
SQLAlchemy). Override `column_type_mappings` for specific needs
(see MSSQL for example of NCHAR/NVARCHAR handling).
- :param type_: Column type returned by inspector
+ :param column_type: Column type returned by inspector
:return: SqlAlchemy column type
"""
- if not type_:
- return None
- for regex, sqla_type in cls.column_type_mappings:
- match = regex.match(type_)
+ if not column_type:
+ return None, None
+ for regex, sqla_type, generic_type in cls.column_type_mappings:
+ match = regex.match(column_type)
if match:
if callable(sqla_type):
- return sqla_type(match)
- return sqla_type
- return None
+ return sqla_type(match), generic_type
+ return sqla_type, generic_type
+ return None, None
Review comment:
For cases where we want to return an empty value (=no match was made), I'd perhaps prefer returning a pure `None` instead of a `Tuple` with `None`s.
##########
File path: superset/db_engine_specs/base.py
##########
@@ -967,25 +980,27 @@ def make_label_compatible(cls, label: str) -> Union[str, quoted_name]:
return label_mutated
@classmethod
- def get_sqla_column_type(cls, type_: Optional[str]) -> Optional[TypeEngine]:
+ def get_sqla_column_type(
+ cls, column_type: Optional[str]
+ ) -> Tuple[Union[TypeEngine, utils.GenericDataType, None]]:
Review comment:
I would consider just leaving the signature of this method unchanged for now; otherwise I'd just remove this one and start using the new `get_column_spec` method and implement that wherever `get_sqla_column_type` is being used, as that's the end state we want to aim for.
##########
File path: superset/utils/core.py
##########
@@ -148,6 +148,10 @@ class GenericDataType(IntEnum):
STRING = 1
TEMPORAL = 2
BOOLEAN = 3
+ ARRAY = 4
+ JSON = 5
+ MAP = 6
+ ROW = 7
Review comment:
We need to make sure this logic is in synced with `superset-ui/core` - for now it might be a good idea to just map all complex types to `STRING` as has previously been done, and later introduce more complex generic types once we add proper support for them.
##########
File path: superset/db_engine_specs/base.py
##########
@@ -179,6 +185,13 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
),
}
+ dttm_types = [
+ types.TIME,
+ types.TIMESTAMP,
+ types.TIMESTAMP(timezone=True),
+ types.Interval,
+ ]
Review comment:
I don't believe this is needed anymore.
##########
File path: superset/db_engine_specs/base.py
##########
@@ -1097,3 +1112,26 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
def is_readonly_query(cls, parsed_query: ParsedQuery) -> bool:
"""Pessimistic readonly, 100% sure statement won't mutate anything"""
return parsed_query.is_select() or parsed_query.is_explain()
+
+ def get_column_spec(
+ self,
+ column_name: Optional[str],
+ native_type: str,
+ source: utils.ColumnTypeSource = utils.ColumnTypeSource.GET_TABLE,
+ ) -> utils.ColumnSpec:
+
+ column_type, generic_type = self.get_sqla_column_type(native_type)
+ is_dttm = generic_type == utils.GenericDataType.TEMPORAL
+
+ if column_name: # Further logic to be implemented
+ pass
+ if (
+ source == utils.ColumnTypeSource.CURSOR_DESCRIPION
+ ): # Further logic to be implemented
+ pass
Review comment:
For now we can assume `GET_TABLE` and `CURSOR_DESCRIPTION` is handled with the same matching logic - this can later be refined for engines where this makes a difference. Also, we might consider keeping the base implementation as simple as possible, and leaving the more complex logic to the individual db engine specs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r583015764
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (re.compile(r"^smallint", re.IGNORECASE), types.SMALLINT),
+ (re.compile(r"^integer", re.IGNORECASE), types.INTEGER),
+ (re.compile(r"^bigint", re.IGNORECASE), types.BIGINT),
+ (re.compile(r"^decimal", re.IGNORECASE), types.DECIMAL),
+ (re.compile(r"^numeric", re.IGNORECASE), types.NUMERIC),
+ (re.compile(r"^real", re.IGNORECASE), types.REAL),
+ (re.compile(r"^double precision", re.IGNORECASE), DOUBLE_PRECISION),
+ (re.compile(r"^smallserial", re.IGNORECASE), types.SMALLINT),
+ (re.compile(r"^serial", re.IGNORECASE), types.INTEGER),
+ (re.compile(r"^bigserial", re.IGNORECASE), types.BIGINT),
+ (re.compile(r"^varchar", re.IGNORECASE), types.VARCHAR),
+ (re.compile(r"^char", re.IGNORECASE), types.CHAR),
+ (re.compile(r"^text", re.IGNORECASE), types.TEXT),
+ (re.compile(r"^date", re.IGNORECASE), types.DATE),
+ (re.compile(r"^time", re.IGNORECASE), types.TIME),
+ (re.compile(r"^timestamp", re.IGNORECASE), types.TIMESTAMP),
+ (re.compile(r"^timestamptz", re.IGNORECASE), types.TIMESTAMP(timezone=True)),
Review comment:
Were you able to get these from `inspector.get_columns()` or `cursor.description`? When I check a table with timestamps it seems to return the unabbreviated format `TIMESTAMP WITHOUT TIME ZONE`, not `TIMESTAMP`:
I'm assuming the abbreviations are usually relevant when creating tables, not fetching table metadata, but I may be wrong (this may have changed over the versions/years):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (a0d9071) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.91%`.
> The diff coverage is `57.97%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.39% -5.92%
==========================================
Files 903 823 -80
Lines 45926 41141 -4785
Branches 5624 4262 -1362
==========================================
- Hits 35508 29373 -6135
- Misses 10282 11768 +1486
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.19% <13.63%> (+0.74%)` | :arrow_up: |
| hive | `80.14% <98.61%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.66%> (+0.01%)` | :arrow_up: |
| postgres | `80.52% <97.22%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.91% <98.61%> (+0.18%)` | :arrow_up: |
| sqlite | `80.13% <91.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `16.66% <16.66%> (-16.67%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `90.42% <20.00%> (-3.27%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `30.00% <33.33%> (-26.25%)` | :arrow_down: |
| ... and [497 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...7e0d4d1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...2f341b9](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (71a6671) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.73%`.
> The diff coverage is `64.47%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.57% -5.74%
==========================================
Files 903 779 -124
Lines 45926 38571 -7355
Branches 5624 3647 -1977
==========================================
- Hits 35508 27608 -7900
- Misses 10282 10963 +681
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.47% <32.69%> (-0.99%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.37% <75.00%> (-0.09%)` | :arrow_down: |
| postgres | `80.42% <76.44%> (-0.08%)` | :arrow_down: |
| presto | `?` | |
| python | `80.51% <76.44%> (-0.22%)` | :arrow_down: |
| sqlite | `80.03% <75.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `93.50% <ø> (-6.50%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `28.12% <0.00%> (-39.45%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `6.25% <0.00%> (-58.97%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| ... and [539 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (dfe6185) into [master](https://codecov.io/gh/apache/superset/commit/c91c45574be2c413484c62dd38f06a93166ef246?el=desc) (c91c455) will **decrease** coverage by `5.62%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.16% 71.54% -5.63%
==========================================
Files 917 807 -110
Lines 46135 40954 -5181
Branches 5600 4210 -1390
==========================================
- Hits 35602 29301 -6301
- Misses 10401 11653 +1252
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <ø> (+0.05%)` | :arrow_up: |
| hive | `80.11% <98.57%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.43% <92.85%> (-0.01%)` | :arrow_down: |
| postgres | `80.48% <98.57%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.87% <98.57%> (-0.11%)` | :arrow_down: |
| sqlite | `80.09% <92.85%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.51% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.15% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (-5.19%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.54% <100.00%> (+0.12%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [505 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (71a6671) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.16%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.15% -6.17%
==========================================
Files 903 826 -77
Lines 45926 41326 -4600
Branches 5624 4265 -1359
==========================================
- Hits 35508 29405 -6103
- Misses 10282 11921 +1639
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <37.50%> (+0.64%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.37% <75.00%> (-0.09%)` | :arrow_down: |
| postgres | `80.42% <76.44%> (-0.08%)` | :arrow_down: |
| presto | `?` | |
| python | `80.51% <76.44%> (-0.22%)` | :arrow_down: |
| sqlite | `80.03% <75.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (51b7a82) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `5.89%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.96% 71.07% -5.90%
==========================================
Files 930 821 -109
Lines 46278 41058 -5220
Branches 5554 4226 -1328
==========================================
- Hits 35619 29182 -6437
- Misses 10525 11876 +1351
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.44% <ø> (ø)` | |
| hive | `80.16% <98.57%> (+0.03%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| python | `80.16% <98.57%> (-0.73%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.05% <93.33%> (-0.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.19% <100.00%> (-5.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (+0.36%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.77% <100.00%> (-1.58%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [527 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (83f3996) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `0.76%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 72.29% 71.53% -0.77%
==========================================
Files 864 776 -88
Lines 44883 40311 -4572
Branches 5403 4129 -1274
==========================================
- Hits 32450 28836 -3614
+ Misses 12224 11475 -749
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.11% <ø> (?)` | |
| javascript | `?` | |
| python | `80.36% <50.00%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [491 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...83f3996](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (b41d38c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `5.84%`.
> The diff coverage is `63.90%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.46% -5.85%
==========================================
Files 903 823 -80
Lines 45926 41145 -4781
Branches 5624 4260 -1364
==========================================
- Hits 35508 29406 -6102
- Misses 10282 11739 +1457
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.20% <16.17%> (+0.75%)` | :arrow_up: |
| hive | `80.16% <96.03%> (?)` | |
| javascript | `?` | |
| mysql | `80.47% <91.08%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <95.04%> (+0.02%)` | :arrow_up: |
| presto | `80.19% <96.03%> (+0.02%)` | :arrow_up: |
| python | `81.02% <96.03%> (+0.29%)` | :arrow_up: |
| sqlite | `80.13% <91.08%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `62.50% <0.00%> (-5.07%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `18.75% <ø> (-22.16%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `6.45% <0.00%> (-11.74%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `20.00% <0.00%> (-20.91%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `15.15% <15.15%> (ø)` | |
| ... and [500 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...4336ae5](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...010e50e](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **increase** coverage by `4.43%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 76.32% 80.76% +4.43%
==========================================
Files 906 300 -606
Lines 45739 24406 -21333
Branches 5524 0 -5524
==========================================
- Hits 34911 19711 -15200
+ Misses 10667 4695 -5972
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.12%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/redirects.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | `70.00% <0.00%> (-18.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [...perset/dashboards/commands/importers/dispatcher.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvZGlzcGF0Y2hlci5weQ==) | `80.64% <0.00%> (-3.23%)` | :arrow_down: |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `36.36% <0.00%> (-2.24%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| ... and [632 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...1a799df](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `8.46%`.
> The diff coverage is `87.05%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 80.76% +8.46%
==========================================
Files 864 300 -564
Lines 44883 24406 -20477
Branches 5403 0 -5403
==========================================
- Hits 32450 19711 -12739
+ Misses 12224 4695 -7529
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `80.76% <87.05%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `76.77% <ø> (-1.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.28% <0.00%> (-0.20%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <61.11%> (-1.27%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.33% <75.00%> (-0.04%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.28% <87.50%> (-0.30%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.09% <90.90%> (-0.01%)` | :arrow_down: |
| ... and [562 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...c894b90](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (51b7a82) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `6.24%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 77.31% 71.07% -6.25%
==========================================
Files 903 821 -82
Lines 45926 41058 -4868
Branches 5624 4226 -1398
==========================================
- Hits 35508 29182 -6326
- Misses 10282 11876 +1594
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.44% <ø> (+0.98%)` | :arrow_up: |
| hive | `80.16% <98.57%> (?)` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <98.57%> (-0.57%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.05% <93.33%> (-0.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.19% <100.00%> (-5.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (-5.62%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.77% <100.00%> (-1.58%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [508 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1d1a1cd...8e1d813](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (83f3996) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `1.41%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 73.71% +1.41%
==========================================
Files 864 729 -135
Lines 44883 37385 -7498
Branches 5403 3452 -1951
==========================================
- Hits 32450 27558 -4892
+ Misses 12224 9827 -2397
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `61.34% <ø> (?)` | |
| javascript | `?` | |
| python | `80.36% <50.00%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [500 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...83f3996](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (83f3996) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `8.02%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 80.32% +8.02%
==========================================
Files 864 298 -566
Lines 44883 24311 -20572
Branches 5403 0 -5403
==========================================
- Hits 32450 19527 -12923
+ Misses 12224 4784 -7440
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `80.32% <50.00%> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.16%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.43%)` | :arrow_down: |
| ... and [569 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...83f3996](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (0cb390e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `5.44%`.
> The diff coverage is `98.57%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.96% 71.52% -5.45%
==========================================
Files 930 821 -109
Lines 46278 41058 -5220
Branches 5554 4226 -1328
==========================================
- Hits 35619 29367 -6252
- Misses 10525 11691 +1166
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.44% <ø> (ø)` | |
| hive | `80.14% <98.57%> (+0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.47% <92.85%> (+0.01%)` | :arrow_up: |
| postgres | `80.53% <98.57%> (+0.03%)` | :arrow_up: |
| python | `80.91% <98.57%> (+0.02%)` | :arrow_up: |
| sqlite | `80.13% <92.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `92.68% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <93.33%> (-0.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.15% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <100.00%> (+0.36%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [375797f...51b7a82](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...82a8c9d](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (9f74f2d) into [master](https://codecov.io/gh/apache/superset/commit/1e3130d58849a702088248872c65574040a534de?el=desc) (1e3130d) will **increase** coverage by `3.71%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.04% 80.76% +3.71%
==========================================
Files 894 300 -594
Lines 45664 24406 -21258
Branches 5490 0 -5490
==========================================
- Hits 35184 19711 -15473
+ Misses 10356 4695 -5661
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.76% <77.41%> (-0.10%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.83% <58.82%> (-1.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.25% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `78.50% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.54% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [599 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [1e3130d...641a16a](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic closed pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
nikolagigic closed pull request #13294:
URL: https://github.com/apache/superset/pull/13294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (fc0a7a1) into [master](https://codecov.io/gh/apache/superset/commit/29d6420ecc2187db951f08dd47289277a11f4db5?el=desc) (29d6420) will **increase** coverage by `2.74%`.
> The diff coverage is `77.41%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 77.20% 79.94% +2.74%
==========================================
Files 872 300 -572
Lines 45101 24378 -20723
Branches 5435 0 -5435
==========================================
- Hits 34820 19489 -15331
+ Misses 10158 4889 -5269
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `79.94% <77.41%> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.88% <58.82%> (-2.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.75% <100.00%> (-2.31%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.57% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| ... and [595 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [29d6420...fc0a7a1](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (dfe6185) into [master](https://codecov.io/gh/apache/superset/commit/94fc5d586e225e569250d16f7b1efc3b619af78c?el=desc) (94fc5d5) will **decrease** coverage by `4.96%`.
> The diff coverage is `55.61%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
- Coverage 76.32% 71.36% -4.97%
==========================================
Files 906 807 -99
Lines 45739 40954 -4785
Branches 5524 4210 -1314
==========================================
- Hits 34911 29227 -5684
- Misses 10667 11727 +1060
+ Partials 161 0 -161
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <35.14%> (+1.43%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.43% <92.39%> (+0.09%)` | :arrow_up: |
| postgres | `80.48% <94.56%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.57% <94.56%> (-0.31%)` | :arrow_down: |
| sqlite | `80.09% <92.39%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (+16.66%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.47% <0.00%> (-17.77%)` | :arrow_down: |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `61.53% <ø> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `33.33% <ø> (ø)` | |
| [...nd/src/components/BootstrapSliderWrapper/index.jsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci9pbmRleC5qc3g=) | `0.00% <ø> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/SearchInput/index.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...s/nativeFilters/FilterBar/CascadeFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJDb250cm9sLnRzeA==) | `100.00% <ø> (+14.28%)` | :arrow_up: |
| ... and [574 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [94fc5d5...0189072](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13294: feat(explore): Postgres datatype conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13294:
URL: https://github.com/apache/superset/pull/13294#issuecomment-783878424
# [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=h1) Report
> Merging [#13294](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=desc) (83f3996) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `8.06%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13294 +/- ##
==========================================
+ Coverage 72.29% 80.36% +8.06%
==========================================
Files 864 298 -566
Lines 44883 24311 -20572
Branches 5403 0 -5403
==========================================
- Hits 32450 19538 -12912
+ Misses 12224 4773 -7451
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `80.36% <50.00%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.13% <27.77%> (-2.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.39% <100.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.32% <0.00%> (-0.16%)` | :arrow_down: |
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | | |
| ... and [567 more](https://codecov.io/gh/apache/superset/pull/13294/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=footer). Last update [9b5e66b...83f3996](https://codecov.io/gh/apache/superset/pull/13294?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org