[GitHub] [nifi] tpalfy commented on a diff in pull request #7191: NIFI-8650 Flow Analysis

["tpalfy (via GitHub)" <gi...@apache.org>]

tpalfy commented on code in PR #7191:
URL: https://github.com/apache/nifi/pull/7191#discussion_r1224469176


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java:
##########
@@ -974,6 +993,9 @@ private ValidationResult validateControllerServiceApi(final PropertyDescriptor d
         return null;
     }
 
+    protected void analyze() {

Review Comment:
   That's true but I'm struggling to come up with a good name that's not too long.
   
   This type of analysis conceptually called `FlowAnalysis`. But something like `perfromFlowAnalysis` would suggest that this component wants to do a full-scale analysis. `performFlowAnalysisOnThisComponent` feels too long.
   Maybe `performFlowAnalysisOnThis`?
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org