You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/24 21:32:08 UTC

[GitHub] [superset] benjreinhart commented on a change in pull request #13735: fix(#13734): Properly escape special characters in CSV output

benjreinhart commented on a change in pull request #13735:
URL: https://github.com/apache/superset/pull/13735#discussion_r600888119



##########
File path: superset/views/core.py
##########
@@ -437,10 +437,7 @@ def generate_json(
     ) -> FlaskResponse:
         if response_type == utils.ChartDataResultFormat.CSV:
             return CsvResponse(
-                viz_obj.get_csv(),
-                status=200,
-                headers=generate_download_headers("csv"),
-                mimetype="application/csv",
+                viz_obj.get_csv(), headers=generate_download_headers("csv")

Review comment:
       Agreed, the status was removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org