You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2017/07/02 03:52:01 UTC
[jira] [Updated] (FLINK-6493) Ineffective null check in
RegisteredOperatorBackendStateMetaInfo#equals()
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated FLINK-6493:
--------------------------
Description:
{code}
&& ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer() == null)
|| partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
&& ((partitionStateSerializerConfigSnapshot == null && ((Snapshot) obj).getPartitionStateSerializerConfigSnapshot() == null)
|| partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
{code}
The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in combination with another clause.
This may lead to NPE in the partitionStateSerializer.equals() call.
was:
{code}
&& ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer() == null)
|| partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
&& ((partitionStateSerializerConfigSnapshot == null && ((Snapshot) obj).getPartitionStateSerializerConfigSnapshot() == null)
|| partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
{code}
The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in combination with another clause.
This may lead to NPE in the partitionStateSerializer.equals() call.
> Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
> -------------------------------------------------------------------------
>
> Key: FLINK-6493
> URL: https://issues.apache.org/jira/browse/FLINK-6493
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer() == null)
> || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
> && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot) obj).getPartitionStateSerializerConfigSnapshot() == null)
> || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
> {code}
> The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in combination with another clause.
> This may lead to NPE in the partitionStateSerializer.equals() call.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)