You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/05 09:06:44 UTC

[GitHub] [spark] rednaxelafx edited a comment on pull request #31747: [SPARK-34607][SQL][2.4] Add `Utils.isMemberClass` to fix a malformed class name error on jdk8u

rednaxelafx edited a comment on pull request #31747:
URL: https://github.com/apache/spark/pull/31747#issuecomment-791276429


   Let me briefly describe the situation in a new comment in my original PR: https://github.com/apache/spark/pull/31709#issuecomment-791275810
   
   We definitely still want the isMemberClass fix in @maropu san's PR, since it avoids a Java `InternalError` that Spark SQL didn't know how to handle. But the test case needs some massaging to not fail the test, c.f. my comment linked above.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org