[jira] Commented: (OFBIZ-1035) Price rounding, don't use UtilNumber.java for scale

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498855 ] 

Jacques Le Roux commented on OFBIZ-1035:
----------------------------------------

Nicolas,

2 remarks : 

1. braces are missing, you should write
while (condition) {
    expression
}
please see : http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html

2. It does not compile, I get  5 errors like this :

 [javac] D:\WorkspaceNew\ofbizClean\applications\product\src\org\ofbiz\product\price\PriceServices.java:642: cannot find symbol
    [javac] symbol  : method valueOf(java.lang.Double)
    [javac] location: class java.math.BigDecimal
    [javac] result.put("listPrice", BigDecimal.valueOf((Double) result.get("listPrice")).multiply(taxMultiplier).setScale( taxFinalScale, taxRounding ).doubleValue());

Sorry, I have no time to investigate, and a bit tired ;o) ...


> Price rounding, don't use UtilNumber.java for scale
> ---------------------------------------------------
>
>                 Key: OFBIZ-1035
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1035
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>         Assigned To: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: priceRounding-ofbiz.patch
>
>
> Apply correction on PriceService.java. When ecommerce price use VAT, BigDecimal scale don't use UtilNumber.java .
> exemple for a product price 7.53 and tax 19,6%, ecommerce price display 9.00 and order total is 9.01
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.