[jira] Resolved: (HARMONY-665) [classlib][nio]Charset.encode()/decode() should be more safer for multi thread using

["Tim Ellison (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/HARMONY-665?page=all ]
     
Tim Ellison resolved HARMONY-665:
---------------------------------

    Resolution: Fixed

Thanks Paulex,

Patch applied to NIO_CHAR module at repo revision r417174.

(I still think you may be able to reduce the synchronization on the cache read/write to improve performance.)

Please check that the patch was applied as you expected.


> [classlib][nio]Charset.encode()/decode() should be more safer for multi thread using
> ------------------------------------------------------------------------------------
>
>          Key: HARMONY-665
>          URL: http://issues.apache.org/jira/browse/HARMONY-665
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>  Attachments: Harmony-665.diff
>
> As discussion on the mailing list, current Harmony codes may throw exception for the scenario below:
>          for (int i = 0; i < THREAD_NUM; i++) {
>               thread[i] = new Thread() {
>                   public void run() {
>                      sink.write(ByteBuffer.wrap("bytes"
>                                         .getBytes(ISO8859_1)));
>                     }
>         }
> String.getBytes() actually invokes Charset.encode(), while spec requires Charset.encode() to be thread-safe. Current Harmony implementation of Charset.encode() holds lock on this Charset instance, but doesn't synchronize on the system wide cached CharsetEncoder, so it is not safe for multi Charset instances in multi threads to encode() concurrently. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira