[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4340: ARTEMIS-4137 MQTT sub-queue clean-up can fail due to auth

["brusdev (via GitHub)" <gi...@apache.org>]

brusdev commented on code in PR #4340:
URL: https://github.com/apache/activemq-artemis/pull/4340#discussion_r1082914768


##########
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSubscriptionManager.java:
##########
@@ -369,7 +373,7 @@ Map<Long, Integer> getConsumerQoSLevels() {
 
    void clean() {
       for (MqttTopicSubscription mqttTopicSubscription : session.getState().getSubscriptions()) {
-         removeSubscription(mqttTopicSubscription.topicName());
+         removeSubscription(mqttTopicSubscription.topicName(), true);

Review Comment:
   The `testSubscriptionQueueRemoved` test is failing, should enforceSecurity=false in this case?
   ```suggestion
            removeSubscription(mqttTopicSubscription.topicName(), false);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org