You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "zsy056 (via GitHub)" <gi...@apache.org> on 2026/03/25 22:57:06 UTC
[PR] Remove dependency on docker/login-action [thrift]
zsy056 opened a new pull request, #3363:
URL: https://github.com/apache/thrift/pull/3363
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dependency on docker/login-action [thrift]
Posted by "zsy056 (via GitHub)" <gi...@apache.org>.
zsy056 commented on code in PR #3363:
URL: https://github.com/apache/thrift/pull/3363#discussion_r3002147530
##########
.github/workflows/msvc.yml:
##########
@@ -12,11 +12,11 @@ concurrency:
permissions:
contents: read
+ packages: write
Review Comment:
Thanks, moved write permission to the job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dependency on docker/login-action [thrift]
Posted by "zsy056 (via GitHub)" <gi...@apache.org>.
zsy056 commented on PR #3363:
URL: https://github.com/apache/thrift/pull/3363#issuecomment-4139791028
> Whats the purpose of this change?
Hi Jens, it seems recently Apache org has enabled some policy that will block any unapproved GitHub Action like docker/login-action. This change removed that dependency so that this workflow can be run again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dependency on docker/login-action [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3363:
URL: https://github.com/apache/thrift/pull/3363#issuecomment-4139209085
Whats the purpose of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5936: Remove dependency on docker/login-action [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3363:
URL: https://github.com/apache/thrift/pull/3363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dependency on docker/login-action [thrift]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on code in PR #3363:
URL: https://github.com/apache/thrift/pull/3363#discussion_r3000516762
##########
.github/workflows/msvc.yml:
##########
@@ -12,11 +12,11 @@ concurrency:
permissions:
contents: read
+ packages: write
Review Comment:
Global write permission is considered a security risk. I would recommend to move it down to a specific job that needs write permissions.
See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org