You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/05/05 06:42:01 UTC
[PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
gnodet opened a new pull request, #22933:
URL: https://github.com/apache/camel/pull/22933
[CAMEL-23403](https://issues.apache.org/jira/browse/CAMEL-23403)
## Summary
Moves the route diagram rendering code from `camel-jbang-core` to a new standalone `components/camel-diagram` module so it can be reused by maven-plugin, Quarkus dev console, runtime Camel apps, and 3rd-party tools.
### Changes
- **New module `components/camel-diagram`** with public API:
- `RouteDiagramLayoutEngine` — tree building and layout computation
- `RouteDiagramRenderer` — image rendering and text diagram generation
- `RouteDiagramHelper` — utility for parsing route structure JSON
- **`printTextDiagram` returns `List<String>`** instead of taking a `Printer` parameter — makes the API framework-agnostic
- **`camel-jbang-core`** updated to depend on `camel-diagram` — `CamelRouteDiagramAction` stays in jbang as the CLI command
### Dependencies
The new module has minimal dependencies:
- `camel-util` + `camel-util-json` (for JSON parsing)
- `jline-core` (for ANSI color name resolution in DiagramColors)
## Test plan
- [x] 33 tests in `components/camel-diagram` (layout, rendering, colors, text diagram)
- [x] 2 tests in `camel-jbang-core` (parseRoutes JSON integration)
- [x] Both modules build successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22933:
URL: https://github.com/apache/camel/pull/22933#issuecomment-4377046163
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #22933:
URL: https://github.com/apache/camel/pull/22933#issuecomment-4377347072
you need to add docs in
camel-diagram/src/main/docs/diagram.adoc
You can take a look at camel-headersmap/src/main/docs/headersmap.adoc and use that as inspiration.
then rebuild the docs folder that will add a link to this doc file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #22933:
URL: https://github.com/apache/camel/pull/22933#issuecomment-4377160765
modified: bom/camel-bom/pom.xml
modified: catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/others.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #22933:
URL: https://github.com/apache/camel/pull/22933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22933:
URL: https://github.com/apache/camel/pull/22933#issuecomment-4377487360
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `bom/camel-bom`
- `catalog/camel-allcomponents`
- `catalog/camel-catalog`
- `components`
- `components/camel-diagram`
- `docs`
- `dsl/camel-jbang/camel-jbang-core`
- `parent`
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `dsl/camel-jbang/camel-jbang-core`: 1 test(s) disabled on GitHub Actions
- `components`: 144 test(s) disabled on GitHub Actions
:bulb: **Manual integration tests recommended:**
> You modified `dsl/camel-jbang/camel-jbang-core`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually:
> ```
> mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
> ```
<details><summary>All tested modules (10 modules)</summary>
- Camel :: Catalog :: Camel Catalog
- Camel :: Diagram
- Camel :: JBang :: Core
- Camel :: JBang :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Validate
- Camel :: Launcher :: Container
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25363779776)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23403: Move route diagram renderer to components/camel-diagram [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #22933:
URL: https://github.com/apache/camel/pull/22933#issuecomment-4377485251
@davsclaus Added documentation in `camel-diagram/src/main/docs/diagram.adoc` with usage examples (library API, text diagram, JBang integration, color themes). Also added nav link and doc symlink.
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org