You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/07/13 12:06:05 UTC
[GitHub] flink pull request #4322: [FLINK-7173][doc]Change the illustration of tumbli...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4322
[FLINK-7173][doc]Change the illustration of tumbling window.
Change the illustration of tumbling window.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-7173][doc]Change the illustration of tumbling window.")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-7173-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4322
----
commit fc1f954389010d9f7192f989c20d8b8b87c80244
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-07-13T12:04:00Z
[FLINK-7173][doc]Change the illustration of tumbling window.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4322: [FLINK-7173][doc]Change the illustration of tumbling wind...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4322
Yes @aljoscha I agree with you. I have updated the PR. -:)
Thanks, Jincheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4322: [FLINK-7173][doc]Change the illustration of tumbli...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 closed the pull request at:
https://github.com/apache/flink/pull/4322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4322: [FLINK-7173][doc]Change the illustration of tumbling wind...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4322
While on this, I think it would also make sense to fix the picture for sliding windows, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4322: [FLINK-7173][doc]Change the illustration of tumbling wind...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4322
@sunjincheng121 Thanks a lot! I merged, could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4322: [FLINK-7173][doc]Change the illustration of tumbling wind...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4322
Sure! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---