[GitHub] [systemds] mboehm7 commented on pull request #980: [SYSTEMDS-135] log4j.properties simplified

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #980:
URL: https://github.com/apache/systemds/pull/980#issuecomment-663902905


   LGTM - thanks @Baunsgaard for the cleanup. Just for the historical background: we actually created this log4j file as a copy from the hadoop log4j file (that's were the detailed hadoop configurations came from) and we kept INFO for SystemML by default, because all our messages went through logging (instead of stdout) in order to avoid filling up the stdout queue if nobody is reading from it. Meanwhile, most of our explain (including runtime explain), stats, etc go to stdout so this change is fine. However, I just double checked and a number of warnings/errors (e.g., of the parser - index identifier, parfor stats, codegen explani) go to LOG.info and thus will be silent by default. Let's clean these places up to put all errors/warnings into error level and explain/stats consistently to stdout.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org