You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "OmniaGM (via GitHub)" <gi...@apache.org> on 2024/01/09 16:04:29 UTC
[PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
OmniaGM opened a new pull request, #15160:
URL: https://github.com/apache/kafka/pull/15160
blocker for #15158
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #15160:
URL: https://github.com/apache/kafka/pull/15160#discussion_r1446301043
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
+ private final long quotaBytesPerSecondDefault;
+ private final int numQuotaSamples;
+ private final int quotaWindowSizeSeconds;
+
+ /**
+ * Configuration settings for replication quota management
+ *
+ * @param quotaBytesPerSecondDefault The default bytes per second quota allocated to internal replication
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+ public ReplicationQuotaManagerConfig(long quotaBytesPerSecondDefault, int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = quotaBytesPerSecondDefault;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+ public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
Review Comment:
Let's rework to chained constructors call like:
```
public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
this(DEFAULT_QUOTA_BYTES_PER_SECOND, numQuotaSamples, quotaWindowSizeSeconds);
}
public ReplicationQuotaManagerConfig() {
this(DEFAULT_QUOTA_BYTES_PER_SECOND, DEFAULT_NUM_QUOTA_SAMPLES, DEFAULT_QUOTA_WINDOW_SIZE_SECONDS);
}
```
This will simplify adding new fields with default to class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #15160:
URL: https://github.com/apache/kafka/pull/15160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on PR #15160:
URL: https://github.com/apache/kafka/pull/15160#issuecomment-1883399256
@mimaison
@ijuma
This PR are ready for merge for me. Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #15160:
URL: https://github.com/apache/kafka/pull/15160#discussion_r1446306950
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
+ private final long quotaBytesPerSecondDefault;
+ private final int numQuotaSamples;
+ private final int quotaWindowSizeSeconds;
+
+ /**
+ * Configuration settings for replication quota management
+ *
+ * @param quotaBytesPerSecondDefault The default bytes per second quota allocated to internal replication
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+ public ReplicationQuotaManagerConfig(long quotaBytesPerSecondDefault, int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = quotaBytesPerSecondDefault;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+ public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+
+ public ReplicationQuotaManagerConfig() {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = DEFAULT_NUM_QUOTA_SAMPLES;
+ this.quotaWindowSizeSeconds = DEFAULT_QUOTA_WINDOW_SIZE_SECONDS;
+ }
+ public long getQuotaBytesPerSecondDefault() {
+ return quotaBytesPerSecondDefault;
+ }
+
+ public int getNumQuotaSamples() {
Review Comment:
Do we really need getters for classes?
Looks like we can make all fields public as they are all final.
We use similar approach for java version of commands case classes - `ReassignPartitionsCommandOptions`, `CompletedMoveState` and others.
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
+ private final long quotaBytesPerSecondDefault;
+ private final int numQuotaSamples;
+ private final int quotaWindowSizeSeconds;
+
+ /**
+ * Configuration settings for replication quota management
+ *
+ * @param quotaBytesPerSecondDefault The default bytes per second quota allocated to internal replication
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+ public ReplicationQuotaManagerConfig(long quotaBytesPerSecondDefault, int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = quotaBytesPerSecondDefault;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+ public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+
+ public ReplicationQuotaManagerConfig() {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = DEFAULT_NUM_QUOTA_SAMPLES;
+ this.quotaWindowSizeSeconds = DEFAULT_QUOTA_WINDOW_SIZE_SECONDS;
+ }
+ public long getQuotaBytesPerSecondDefault() {
+ return quotaBytesPerSecondDefault;
+ }
+
+ public int getNumQuotaSamples() {
Review Comment:
Do we really need getters here?
Looks like we can make all fields public as they are all final.
We use similar approach for java version of commands case classes - `ReassignPartitionsCommandOptions`, `CompletedMoveState` and others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #15160:
URL: https://github.com/apache/kafka/pull/15160#discussion_r1446303922
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
+ private final long quotaBytesPerSecondDefault;
+ private final int numQuotaSamples;
+ private final int quotaWindowSizeSeconds;
+
+ /**
+ * Configuration settings for replication quota management
+ *
+ * @param quotaBytesPerSecondDefault The default bytes per second quota allocated to internal replication
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+ public ReplicationQuotaManagerConfig(long quotaBytesPerSecondDefault, int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = quotaBytesPerSecondDefault;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+ public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+
+ public ReplicationQuotaManagerConfig() {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = DEFAULT_NUM_QUOTA_SAMPLES;
+ this.quotaWindowSizeSeconds = DEFAULT_QUOTA_WINDOW_SIZE_SECONDS;
+ }
+ public long getQuotaBytesPerSecondDefault() {
Review Comment:
Please, add empty line between two methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #15160:
URL: https://github.com/apache/kafka/pull/15160#discussion_r1446303522
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
+ private final long quotaBytesPerSecondDefault;
+ private final int numQuotaSamples;
+ private final int quotaWindowSizeSeconds;
+
+ /**
+ * Configuration settings for replication quota management
+ *
+ * @param quotaBytesPerSecondDefault The default bytes per second quota allocated to internal replication
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+ public ReplicationQuotaManagerConfig(long quotaBytesPerSecondDefault, int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = quotaBytesPerSecondDefault;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+ public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
Review Comment:
Please, remove extra empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on code in PR #15160:
URL: https://github.com/apache/kafka/pull/15160#discussion_r1446319824
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
+ private final long quotaBytesPerSecondDefault;
+ private final int numQuotaSamples;
+ private final int quotaWindowSizeSeconds;
+
+ /**
+ * Configuration settings for replication quota management
+ *
+ * @param quotaBytesPerSecondDefault The default bytes per second quota allocated to internal replication
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+ public ReplicationQuotaManagerConfig(long quotaBytesPerSecondDefault, int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = quotaBytesPerSecondDefault;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+ public ReplicationQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = numQuotaSamples;
+ this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
+ }
+
+
+ public ReplicationQuotaManagerConfig() {
+ this.quotaBytesPerSecondDefault = DEFAULT_QUOTA_BYTES_PER_SECOND;
+ this.numQuotaSamples = DEFAULT_NUM_QUOTA_SAMPLES;
+ this.quotaWindowSizeSeconds = DEFAULT_QUOTA_WINDOW_SIZE_SECONDS;
+ }
+ public long getQuotaBytesPerSecondDefault() {
+ return quotaBytesPerSecondDefault;
+ }
+
+ public int getNumQuotaSamples() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15853: Move ReplicationQuotaManagerConfig to server module [kafka]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #15160:
URL: https://github.com/apache/kafka/pull/15160#discussion_r1446308263
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationQuotaManagerConfig.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.config;
+
+public class ReplicationQuotaManagerConfig {
+ public static final long DEFAULT_QUOTA_BYTES_PER_SECOND = Long.MAX_VALUE;
+ // Always have 10 whole windows + 1 current window
+ public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11;
+ public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1;
+ // Purge sensors after 1 hour of inactivity
+ public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
Review Comment:
Please, add empty line between constant and instance fields.
This will make code more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org