You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Raghav Gautam <ra...@apache.org> on 2014/10/03 01:59:54 UTC

Review Request 26297: Fixing PrismFeedUpdateTest and FeedInstanceStatus test issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26297/
-----------------------------------------------------------

Review request for Falcon.


Repository: falcon-git


Description
-------

Found multiple minor test issues:
EmbeddedPigScriptTest tests needs some more time on windows for oozie job creation
FeedInstanceStatusTest should have used coloname - (getColo call returns something else)
PrismFeedUpdateTest#dependentProcessSucceeded should have used cluster1's oozie client instead of prism(which has no oozie client associated with it)


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java ec8726c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 99ffe37 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 3b3ba71 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 55d69a3 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java a07161d 

Diff: https://reviews.apache.org/r/26297/diff/


Testing
-------

Modified EmbeddedPigScriptTest
FeedInstanceStatusTest


Thanks,

Raghav Gautam


Re: Review Request 26297: Fixing PrismFeedUpdateTest and FeedInstanceStatus test issues

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26297/#review55327
-----------------------------------------------------------

Ship it!


Ship It!

- Ruslan Ostafiychuk


On Oct. 2, 2014, 11:59 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26297/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 11:59 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Found multiple minor test issues:
> EmbeddedPigScriptTest tests needs some more time on windows for oozie job creation
> FeedInstanceStatusTest should have used coloname - (getColo call returns something else)
> PrismFeedUpdateTest#dependentProcessSucceeded should have used cluster1's oozie client instead of prism(which has no oozie client associated with it)
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java ec8726c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 99ffe37 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 3b3ba71 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 55d69a3 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java a07161d 
> 
> Diff: https://reviews.apache.org/r/26297/diff/
> 
> 
> Testing
> -------
> 
> Modified EmbeddedPigScriptTest
> FeedInstanceStatusTest
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>