[GitHub] [spark] yaooqinn commented on a change in pull request #29982: [SPARK-33100][SQL] Ignore the content inside bracketed comment and ignore the comment without content

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #29982:
URL: https://github.com/apache/spark/pull/29982#discussion_r503630325



##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -573,4 +573,14 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
     // the date formatter for `java.sql.LocalDate` must output negative years with sign.
     runCliWithin(1.minute)("SELECT MAKE_DATE(-44, 3, 15);" -> "-0044-03-15")
   }
+
+  test("SPARK-33100: Ignore the content inside bracketed comment and ignore the comment without" +
+    " content.") {
+    runCliWithin(1.minute)("/* SELECT 1;*/ SELECT 1;" -> "1" )
+    runCliWithin(1.minute)(";;/* SELECT 1;*/ SELECT 1;" -> "1" )
+    runCliWithin(1.minute)("/* SELECT 1;*/;; SELECT 1;" -> "1" )

Review comment:
       These cases are not good, `1` is not distinguishable as an expected answer. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org