You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "greyp9 (via GitHub)" <gi...@apache.org> on 2024/05/10 15:33:50 UTC
[PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
greyp9 opened a new pull request, #8809:
URL: https://github.com/apache/nifi/pull/8809
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### UI Contributions
- [x] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
### Licensing
- [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [x] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2104859624
I suspect that, if set to auto-start in the flow definition, things would work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #8809:
URL: https://github.com/apache/nifi/pull/8809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2104851122
[app1.log](https://github.com/apache/nifi/files/15277123/app1.log)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2104822113
@greyp9 Can you clarify the behavior you're seeing. I have a system i can try to reproduce this on but I have some python components that take some time to load and they show up invalid. But they did start on their own I thought.
Are you saying right now such components even if set to auto start would on restart not launch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2174197062
@greyp9 Is this still something to be resolved, or does the change no longer appear to be required. If it isn't too involved, having a unit test associated with the change would be helpful to illustrate the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2176341813
I'm not sure that there's anywhere that a unit test, per se, would be fruitful, but a system test might make a lot of sense. Add some components that are invalid but that will become valid, start the PG, and verify that they start running shortly after. But given the limited scope of changes here, and the fact that all existing tests still pass (and the fact that things appear to work when manually testing) i'm good with it as-is. Could always do a follow-on for system tests. You good with that @exceptionfactory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2176272592
> @greyp9 Is this still something to be resolved, or does the change no longer appear to be required. If it isn't too involved, having a unit test associated with the change would be helpful to illustrate the expected behavior.
Yes, my read is that this is still an issue. My understanding is that the current behavior differs from the behavior when a node rejoins a cluster.
When I did this research, I didn't immediately see a natural place to add a unit test. Maybe you could point me at an existing test that I could use to model a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2176351454
Thanks @greyp9 and @exceptionfactory all good from my side. +1 merged to main!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on PR #8809:
URL: https://github.com/apache/nifi/pull/8809#issuecomment-2104856467
I've not tested the case where the processors are set to auto-start.
In the case where a flow is imported, during the period of time where the dependencies are being resolved, the action "ProcessGroup / Start" excludes the processors with dependencies. So they end up Stopped, even after the dependencies become available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org