You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2026/03/25 21:23:04 UTC
[PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
dlmarion opened a new pull request, #6251:
URL: https://github.com/apache/accumulo/pull/6251
Closes #6247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed pull request #6251: Modified Endpoints for multiple managers and new compaction summary
URL: https://github.com/apache/accumulo/pull/6251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#issuecomment-4343449314
Closing this in favor of the solutions in #6318 and #6328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#issuecomment-4129874985
@DomGarguilo - this changes two endpoints. Let me know if you want any changes in the response object formats and I can make them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#discussion_r3060562776
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/next/SystemInformation.java:
##########
@@ -348,6 +349,23 @@ public Stream<RunningCompactionInfo> stream() {
}
+ public record CompactionSummary(Map<TableId,Long> tableCompactions,
+ Map<String,Long> groupCompactions,
+ Map<ServerId,Map<String,List<FMetric>>> compactionQueueMetrics) {
+
+ public List<FMetric> getQueueMetrics(String resourceGroup) {
Review Comment:
When I look at the json output for this I am seeing `_` replaced w/ `.` sometimes. Below are two examples of this. This is [code](https://github.com/apache/accumulo/blob/e47e63de95c292a942e4005bd00190293e8efe41/core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java#L34) is probably causing that.
```json
"tableCompactions": {
"1": 6
},
"groupCompactions": {
"ci_small": 3,
"ci_lrg": 3
},
```
```json
{
"name": "accumulo.compaction.queue.jobs.queued",
"type": "GAUGE",
"tags": [
{
"queue.id": "ci.small"
},
{
"statistic": "value"
}
],
"value": 0
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#issuecomment-4136814557
> @DomGarguilo - this changes two endpoints. Let me know if you want any changes in the response object formats and I can make them.
I think with these changes the JSON will be something like:
```json
{
"type=MANAGER;group=default;address=localhost:9995": [
{ "...": "metric..." },
{ "...": "metric..." }
]
}
```
That will work but is not quite as nice to parse. I'm thinking it might be better to send a list of objects instead of a map. so something like this:
```json
[
{
"server": {
"type": "MANAGER",
"resourceGroup": "default",
"address": "localhost:9995"
},
"metrics": [
{ "...": "metric..." },
{ "...": "metric..." }
]
}
]
```
Not exactly sure what the code will look like but could create something like `record ServerIdView(String type, String resourceGroup, String address)` for reuse in the other endpoints that need the ServerId too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#issuecomment-4210475477
Tried running these changes w/ #6217 and only saw primary manager metrics. Have not tested it yet, but #6304 may fix this by making [this code](https://github.com/apache/accumulo/blob/7732758a6099b3d19610e14ccc640ab29016543b/server/monitor/src/main/java/org/apache/accumulo/monitor/next/InformationFetcher.java#L291-L297) pull from all manager processes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#discussion_r3060520070
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/next/SystemInformation.java:
##########
@@ -348,6 +349,23 @@ public Stream<RunningCompactionInfo> stream() {
}
+ public record CompactionSummary(Map<TableId,Long> tableCompactions,
Review Comment:
Would probably be easier on the front end code to roll the metrics up. Could do something like the following.
```java
public record CompactionTableSummary(String tableId, long running){}
public record CompactionGroupSummary(String groupId, long running, long queued, long rejected/*, other metrics */){}
public record CompactionSummary(List<CompactionTableSummary> tableSummaries, List<CompactionGroupSummary> groupSummaries){}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#discussion_r3060523227
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/next/SystemInformation.java:
##########
@@ -348,6 +349,23 @@ public Stream<RunningCompactionInfo> stream() {
}
+ public record CompactionSummary(Map<TableId,Long> tableCompactions,
Review Comment:
Maybe the list above should be maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#discussion_r3074347314
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/next/SystemInformation.java:
##########
@@ -348,6 +349,23 @@ public Stream<RunningCompactionInfo> stream() {
}
+ public record CompactionSummary(Map<TableId,Long> tableCompactions,
+ Map<String,Long> groupCompactions,
+ Map<ServerId,Map<String,List<FMetric>>> compactionQueueMetrics) {
+
+ public List<FMetric> getQueueMetrics(String resourceGroup) {
Review Comment:
> This is [code](https://github.com/apache/accumulo/blob/e47e63de95c292a942e4005bd00190293e8efe41/core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java#L34) is probably causing that.
Looks right. I'm surprised we are not using that method in more places. I'll create a ticket for it. For now, suggest not using ` `, `_`, or `-` in a queue name as the metric data won't line up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified Endpoints for multiple managers and new compaction summary [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6251:
URL: https://github.com/apache/accumulo/pull/6251#issuecomment-4253862951
Merged `main` into branch. Since #6278 was merged multiple managers now show up on the Managers server page. Still need to adjust compaction summary based on prior comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org