You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by rogerthomas84 <gi...@git.apache.org> on 2014/11/04 11:11:57 UTC
[GitHub] thrift pull request: PHP CS Fix
GitHub user rogerthomas84 opened a pull request:
https://github.com/apache/thrift/pull/252
PHP CS Fix
A simple run of `php-cs-fixer` [https://github.com/fabpot/PHP-CS-Fixer](https://github.com/fabpot/PHP-CS-Fixer)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rogerthomas84/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit ae371377ef1fe9a79ee5cc2dc4fac863da1038b0
Author: Roger Thomas <ro...@gmail.com>
Date: 2014-11-04T10:09:23Z
PHP CS Fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: PHP CS Fix - #THRIFT-2807
Posted by rogerthomas84 <gi...@git.apache.org>.
Github user rogerthomas84 commented on the pull request:
https://github.com/apache/thrift/pull/252#issuecomment-62371239
@Jens-G Thank you. I've raised a ticket here: https://issues.apache.org/jira/browse/THRIFT-2807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: PHP CS Fix
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/252#issuecomment-62287604
Hi, could you just open a JIRA ticket?
http://thrift.apache.org/docs/HowToContribute
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: PHP CS Fix - #THRIFT-2807
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---