You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/07/10 01:25:59 UTC
[PR] [codegen] Fix floating point record equaliser semantics [paimon]
thswlsqls opened a new pull request, #8534:
URL: https://github.com/apache/paimon/pull/8534
### Purpose
fix #8532
- Generate `Float.compare(...) == 0` and `Double.compare(...) == 0` for floating-point `RecordEqualiser` fields.
- Use the same floating-point comparison in nested generated scalar equality.
- Disable raw `BinaryRow.equals()` / `BinaryArray.equals()` fast paths for compared type trees containing `FLOAT` or `DOUBLE`.
- Match map keys with generated equality when the key type tree contains floating-point fields.
- Keeps `NaN`, non-canonical NaN payloads, and signed-zero equality consistent with generated comparators after PR #8295.
### Tests
- Added `EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparison` for `NaN`, non-canonical NaN payloads, signed zero, infinities, nested arrays, map keys, `GenericRow`, hybrid rows, and `BinaryRow`/`BinaryRow`.
- `mvn -pl paimon-codegen -DwildcardSuites=none -DfailIfNoTests=false -Dtest=EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparison test` passed, 1 test.
- `mvn -pl paimon-codegen -DfailIfNoTests=false clean install` passed, 225 tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [codegen] Fix floating point record equaliser semantics [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #8534:
URL: https://github.com/apache/paimon/pull/8534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [codegen] Fix floating point record equaliser semantics [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #8534:
URL: https://github.com/apache/paimon/pull/8534#issuecomment-4954125845
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org